github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-03-03 02:00:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for inaccurate bidrectional edges on edge hover

Browse Source
This commit is contained in:
Jordan Pellizzari
2017-03-16 21:11:41 -07:00
committed by jpellizzari
parent 3e2144544b
commit 93e76a94c1
3 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
client/app/scripts/reducers/__tests__/root-test.js
View File

@@ -540,4 +540,15 @@ describe('RootReducer', () => {
expect(nextState.get('selectedNodeId')).toBeFalsy();
expect(nextState.getIn(['nodeDetails', 'n1'])).toBeFalsy();
});
it('highlights bidirectional edges', () => {
const action = {
type: ActionTypes.ENTER_EDGE,
edgeId: 'abc123-def456'
};
const nextState = reducer(initialState, action);
expect(nextState.get('highlightedEdgeIds').toJS()).toEqual([
'abc123-def456',
'def456-abc123'
]);
});
});

5
client/app/scripts/reducers/root.js
View File

@@ -421,7 +421,10 @@ export function rootReducer(state = initialState, action) {
// highlight edge
state = state.update('highlightedEdgeIds', (highlightedEdgeIds) => {
highlightedEdgeIds = highlightedEdgeIds.clear();
return highlightedEdgeIds.add(action.edgeId);
highlightedEdgeIds = highlightedEdgeIds.add(action.edgeId);
const opposite = action.edgeId.split(EDGE_ID_SEPARATOR).reverse().join(EDGE_ID_SEPARATOR);
highlightedEdgeIds = highlightedEdgeIds.add(opposite);
return highlightedEdgeIds;
});
return state;

2
client/app/scripts/utils/__tests__/layouter-utils-test.js
View File

@@ -1,7 +1,7 @@
import { fromJS } from 'immutable';
import {
initEdgesFromNodes,
initEdgesFromNodes
} from '../layouter-utils';