Merge pull request #2635 from weaveworks/color-connected-once

performance: only color connected once

render/container.go

@@ -34,7 +34,7 @@ var ContainerRenderer = MakeFilter(
 	MakeReduce(
 		MakeMap(
 			MapProcess2Container,
-			ProcessRenderer,
+			ColorConnectedProcessRenderer,
 		),
 
 		// This mapper brings in connections by joining with container

render/host.go

@@ -13,7 +13,7 @@ var HostRenderer = MakeReduce(
 	),
 	MakeMap(
 		MapX2Host,
-		ProcessRenderer,
+		ColorConnectedProcessRenderer,
 	),
 	MakeMap(
 		MapX2Host,

render/process.go

@@ -27,15 +27,21 @@ var EndpointRenderer = FilterProcspiedOrEBPF(SelectEndpoint)
 // ProcessRenderer is a Renderer which produces a renderable process
 // graph by merging the endpoint graph and the process topology.
 var ProcessRenderer = ConditionalRenderer(renderProcesses,
-	ColorConnected(MakeReduce(
+	MakeReduce(
 		MakeMap(
 			MapEndpoint2Process,
 			EndpointRenderer,
 		),
 		SelectProcess,
-	)),
+	),
 )
 
+// ColorConnectedProcessRenderer colors connected nodes from
+// ProcessRenderer. Since the process topology views only show
+// connected processes, we need this info to determine whether
+// processes appearing in a details panel are linkable.
+var ColorConnectedProcessRenderer = ColorConnected(ProcessRenderer)
+
 // processWithContainerNameRenderer is a Renderer which produces a process
 // graph enriched with container names where appropriate
 type processWithContainerNameRenderer struct {