github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-24 07:46:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1668 from weaveworks/report-size-histogram

Browse Source 
Store a histogram of report sizes
This commit is contained in:
Jonathan Lange
2016-07-12 19:08:44 +01:00
committed by GitHub
parent cafaff8960 d83d7318d0
commit 78bf236a9c
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/multitenant/aws_collector.go
View File

@@ -60,10 +60,11 @@ var (
Help: "Total count of reports found in the in-process cache.",
})
reportSize = prometheus.NewCounter(prometheus.CounterOpts{
reportSizeHistogram = prometheus.NewHistogram(prometheus.HistogramOpts{
Namespace: "scope",
Name: "report_size_bytes_total",
Help: "Total compressed size of reports received in bytes.",
Name: "report_size_bytes",
Help: "Distribution of memcache report sizes",
Buckets: prometheus.ExponentialBuckets(4096, 2.0, 10),
})
natsRequests = prometheus.NewCounterVec(prometheus.CounterOpts{
@@ -79,7 +80,7 @@ func init() {
prometheus.MustRegister(dynamoValueSize)
prometheus.MustRegister(inProcessCacheRequests)
prometheus.MustRegister(inProcessCacheHits)
prometheus.MustRegister(reportSize)
prometheus.MustRegister(reportSizeHistogram)
prometheus.MustRegister(natsRequests)
}
@@ -346,7 +347,7 @@ func (c *awsCollector) Add(ctx context.Context, rep report.Report) error {
// first, encode the report into a buffer and record its size
var buf bytes.Buffer
rep.WriteBinary(&buf)
reportSize.Add(float64(buf.Len()))
reportSizeHistogram.Observe(float64(buf.Len()))
// second, put the report on s3
now := time.Now()