mirror of
https://github.com/weaveworks/scope.git
synced 2026-07-28 09:41:57 +00:00
Review feedback
This commit is contained in:
6
scope
6
scope
@@ -153,7 +153,7 @@ launch_docker4mac_app_command() {
|
||||
$WEAVESCOPE_DOCKER_ARGS $SCOPE_IMAGE --no-probe "$@"
|
||||
}
|
||||
|
||||
launch_normally() {
|
||||
launch() {
|
||||
check_not_running $SCOPE_CONTAINER_NAME $SCOPE_IMAGE_NAME
|
||||
docker rm -f $SCOPE_CONTAINER_NAME >/dev/null 2>&1 || true
|
||||
CONTAINER=$($(launch_command "$@"))
|
||||
@@ -209,7 +209,7 @@ EOF
|
||||
if check_docker_for_mac ; then
|
||||
create_plugins_dir
|
||||
if check_probe_only ; then
|
||||
launch_normally "$@"
|
||||
launch "$@"
|
||||
return
|
||||
fi
|
||||
# Docker for Mac (as of beta9) does not ship vmnet driver and
|
||||
@@ -229,7 +229,7 @@ EOF
|
||||
return
|
||||
fi
|
||||
|
||||
launch_normally "$@"
|
||||
launch "$@"
|
||||
if ! check_probe_only ; then
|
||||
IP_ADDRS=$(docker run --rm --net=host --entrypoint /bin/sh $SCOPE_IMAGE -c "$IP_ADDR_CMD")
|
||||
print_app_endpoints $IP_ADDRS
|
||||
|
||||
Reference in New Issue
Block a user