github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-03-03 18:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

review feedback: better tracing info

Browse Source
This commit is contained in:
Bryan Boreham
2019-09-16 11:08:42 +00:00
parent b0915519df
commit 4e8000cbba
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/api_topology.go
View File

@@ -9,6 +9,7 @@ import (
"github.com/gorilla/mux"
ot "github.com/opentracing/opentracing-go"
otlog "github.com/opentracing/opentracing-go/log"
"github.com/pkg/errors"
log "github.com/sirupsen/logrus"
@@ -165,7 +166,7 @@ type websocketState struct {
}
func (wc *websocketState) update(ctx context.Context) error {
span := ot.StartSpan("ws.Render", ot.Tag{"topology", wc.topologyID})
span := ot.StartSpan("websocket.Render", ot.Tag{"topology", wc.topologyID})
defer span.Finish()
ctx = ot.ContextWithSpan(ctx, span)
// We measure how much time has passed since the channel was opened
@@ -176,6 +177,8 @@ func (wc *websocketState) update(ctx context.Context) error {
// might be interested in implementing in the future.
timestampDelta := time.Since(wc.channelOpenedAt)
reportTimestamp := wc.startReportingAt.Add(timestampDelta)
span.LogFields(otlog.String("opened-at", wc.channelOpenedAt.String()),
otlog.String("timestamp", reportTimestamp.String()))
re, err := wc.rep.Report(ctx, reportTimestamp)
if err != nil {
return errors.Wrapf(err, "Error generating report: %v")