lint: Fix 2 sites failing a recently introduced golint check

golint has gained a new check and we don't freeze the golint version so CI was
failing on unrelated PRs:

app/multitenant/consul_client.go:69:2: redundant if ...; err != nil check, just return error instead.
report/marshal.go:188:2: redundant if ...; err != nil check, just return error instead.

Fix those!
This commit is contained in:
Damien Lespiau
2017-09-26 12:15:09 +01:00
parent a3803cb292
commit 466927ce68
2 changed files with 2 additions and 10 deletions
+1 -4
View File
@@ -66,10 +66,7 @@ func (c *consulClient) Get(key string, out interface{}) error {
if kvp == nil {
return ErrNotFound
}
if err := json.NewDecoder(bytes.NewReader(kvp.Value)).Decode(out); err != nil {
return err
}
return nil
return json.NewDecoder(bytes.NewReader(kvp.Value)).Decode(out)
}
// CAS atomically modify a value in a callback.
+1 -6
View File
@@ -185,12 +185,7 @@ func (rep *Report) WriteToFile(path string, compressionLevel int) error {
w = gzwriter
}
if err = codec.NewEncoder(w, handle).Encode(rep); err != nil {
return err
}
return nil
return codec.NewEncoder(w, handle).Encode(rep)
}
func handlerFromFileType(path string) (codec.Handle, bool, error) {