mirror of
https://github.com/weaveworks/scope.git
synced 2026-07-17 04:19:32 +00:00
Review feedback.
This commit is contained in:
@@ -57,7 +57,7 @@ the Internet. Additionally traffic between the app and the probe is currently
|
||||
insecure and should not traverse the internet.
|
||||
|
||||
Scope will periodically check with our servers to see if a new version is
|
||||
availible. To disable this, run:
|
||||
available. To disable this, run:
|
||||
|
||||
```
|
||||
CHECKPOINT_DISABLE=true scope launch
|
||||
|
||||
@@ -44,14 +44,13 @@ func appMain() {
|
||||
defer log.Print("app exiting")
|
||||
|
||||
// Start background version checking
|
||||
params := checkpoint.CheckParams{
|
||||
checkpoint.CheckInterval(&checkpoint.CheckParams{
|
||||
Product: "scope-app",
|
||||
Version: app.Version,
|
||||
SignatureFile: signatureFile,
|
||||
}
|
||||
checkpoint.CheckInterval(¶ms, versionCheckPeriod, func(r *checkpoint.CheckResponse, err error) {
|
||||
}, versionCheckPeriod, func(r *checkpoint.CheckResponse, err error) {
|
||||
if r.Outdated {
|
||||
log.Printf("Scope version %s is availible; please update at %s",
|
||||
log.Printf("Scope version %s is available; please update at %s",
|
||||
r.CurrentVersion, r.CurrentDownloadURL)
|
||||
}
|
||||
})
|
||||
|
||||
@@ -33,7 +33,7 @@ import (
|
||||
|
||||
const (
|
||||
signatureFile = "/etc/weave/signature"
|
||||
versionCheckPeriod = 6 * 60 * time.Minute
|
||||
versionCheckPeriod = 6 * time.Hour
|
||||
)
|
||||
|
||||
func check() {
|
||||
|
||||
6
scope
6
scope
@@ -90,9 +90,13 @@ check_not_running() {
|
||||
}
|
||||
|
||||
launch_command() {
|
||||
local args="-v /etc/weave:/etc/weave"
|
||||
if (set +u; [ -n "$CHECKPOINT_DISABLE" ]); then
|
||||
args=
|
||||
fi
|
||||
echo docker run --privileged -d --name=$SCOPE_CONTAINER_NAME --net=host --pid=host \
|
||||
-v /var/run/docker.sock:/var/run/docker.sock \
|
||||
-v /etc/weave:/etc/weave \
|
||||
$args \
|
||||
-e CHECKPOINT_DISABLE \
|
||||
$WEAVESCOPE_DOCKER_ARGS $SCOPE_IMAGE --probe.docker true "$@"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user