github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-22 14:56:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Review comment: move pty's Close

Browse Source
This commit is contained in:
Alfonso Acosta
2016-04-01 12:14:55 +00:00
parent 4a496073b0
commit 2c4de6243a
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
probe/host/controls.go
View File

@@ -37,8 +37,10 @@ func (r *Reporter) execHost(req xfer.Request) xfer.Response {
}
pipe.OnClose(func() {
if err := cmd.Process.Kill(); err != nil {
log.Errorf("Error closing host shell: %v", err)
return
log.Errorf("Error stopping host shell: %v", err)
}
if err := ptyPipe.Close(); err != nil {
log.Errorf("Error closing host shell's pty: %v", err)
}
log.Info("Host shell closed.")
})
@@ -46,7 +48,6 @@ func (r *Reporter) execHost(req xfer.Request) xfer.Response {
if err := cmd.Wait(); err != nil {
log.Errorf("Error waiting on host shell: %v", err)
}
ptyPipe.Close()
pipe.Close()
}()