github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-03-03 02:00:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3025 from weaveworks/3024-stop-page-router-on-unmount

Browse Source 
Stop page router on App unmount
This commit is contained in:
Filip Barl
2018-01-17 16:22:43 +01:00
committed by GitHub
parent e37a147d94 acfe66c6fe
commit 0dedbeac07
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
client/app/scripts/components/app.js
View File

@@ -76,7 +76,9 @@ class App extends React.Component {
window.addEventListener('keypress', this.onKeyPress);
window.addEventListener('keyup', this.onKeyUp);
getRouter(this.props.dispatch, this.props.urlState).start({hashbang: true});
this.router = getRouter(this.props.dispatch, this.props.urlState);
this.router.start({ hashbang: true });
if (!this.props.routeSet || process.env.WEAVE_CLOUD) {
// dont request topologies when already done via router.
// If running as a component, always request topologies when the app mounts.
@@ -90,6 +92,7 @@ class App extends React.Component {
window.removeEventListener('keypress', this.onKeyPress);
window.removeEventListener('keyup', this.onKeyUp);
this.props.dispatch(shutdown());
this.router.stop();
}
onKeyUp(ev) {