github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-28 09:41:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: clarify and comment on summarisation logic

Browse Source
This commit is contained in:
Matthias Radestock
2017-12-27 13:49:34 +00:00
parent 705c6d159d
commit 0b4512bd9b
1 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
render/detailed/summary.go
View File

@@ -117,17 +117,28 @@ func MakeBasicNodeSummary(r report.Report, n report.Node) (BasicNodeSummary, boo
if t, ok := r.Topology(n.Topology); ok {
summary.Shape = t.GetShape()
}
// Do we have a renderer for the topology?
if renderer, ok := renderers[n.Topology]; ok {
// Skip (and don't fall through to fallback) if renderer maps to nil
if renderer != nil {
return renderer(summary, n), true
if renderer == nil { // we don't want to render this
return summary, false
}
} else if _, ok := r.Topology(n.Topology); ok {
return summary, true
return renderer(summary, n), true
}
// Is it a group topology?
if strings.HasPrefix(n.Topology, "group:") {
return groupNodeSummary(summary, r, n), true
}
// Is it any known topology?
if _, ok := r.Topology(n.Topology); ok {
// We should never get here, since all known topologies are in
// 'renderers'.
return summary, true
}
// We have no idea how to render this.
return summary, false
}