github/vim-ale
1
0
Fork 0
mirror of https://github.com/webinstall/webi-installers.git synced 2026-04-04 17:36:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(go): use early returns in pkg_link for clarity

Browse Source 
Co-authored-by: coolaj86 <122831+coolaj86@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-03-12 08:28:36 +00:00
parent cd7948c81f
commit 3cb1dc619e
2 changed files with 58 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
go/install.sh
View File

@@ -41,26 +41,38 @@ pkg_link() {
# all Go versions, so ~/go is kept stable rather than being swapped to a
# versioned directory on each upgrade.
b_gobin_stable="${HOME}/.local/opt/go-bin"
# New install: create ~/go as a real directory (not a symlink)
if ! test -e "$GOBIN" && ! test -L "$GOBIN"; then
# New install: create ~/go as a real directory (not a symlink)
mkdir -p "$GOBIN/bin"
elif test -L "$GOBIN"; then
b_old_target="$(readlink "$GOBIN")"
if test "$b_old_target" != "$b_gobin_stable" && test -d "$b_old_target"; then
# Migrate from old versioned-symlink (e.g. go-bin-v1.14.2):
# rename the versioned directory to the stable unversioned path
# so that all installed tools are preserved on upgrade.
mv "$b_old_target" "$b_gobin_stable"
rm -f "$GOBIN"
ln -s "$b_gobin_stable" "$GOBIN"
elif ! test -d "$b_old_target"; then
# Symlink target is gone; recreate ~/go as a real directory
rm -f "$GOBIN"
mkdir -p "$GOBIN/bin"
fi
# If already pointing to the stable unversioned dir, do nothing
return
fi
# If $GOBIN is already a real directory, leave it alone
# Real directory: leave it alone
if ! test -L "$GOBIN"; then
return
fi
b_old_target="$(readlink "$GOBIN")"
# Already pointing to the stable unversioned dir: nothing to do
if test "$b_old_target" = "$b_gobin_stable"; then
return
fi
# Migrate from old versioned-symlink (e.g. go-bin-v1.14.2):
# rename the versioned directory to the stable unversioned path
# so that all installed tools are preserved on upgrade.
if test -d "$b_old_target"; then
mv "$b_old_target" "$b_gobin_stable"
rm -f "$GOBIN"
ln -s "$b_gobin_stable" "$GOBIN"
return
fi
# Symlink target is gone; recreate ~/go as a real directory
rm -f "$GOBIN"
mkdir -p "$GOBIN/bin"
}
pkg_post_install() {

46
golang/install.sh
View File

@@ -41,26 +41,38 @@ pkg_link() {
# all Go versions, so ~/go is kept stable rather than being swapped to a
# versioned directory on each upgrade.
b_gobin_stable="${HOME}/.local/opt/go-bin"
# New install: create ~/go as a real directory (not a symlink)
if ! test -e "$GOBIN" && ! test -L "$GOBIN"; then
# New install: create ~/go as a real directory (not a symlink)
mkdir -p "$GOBIN/bin"
elif test -L "$GOBIN"; then
b_old_target="$(readlink "$GOBIN")"
if test "$b_old_target" != "$b_gobin_stable" && test -d "$b_old_target"; then
# Migrate from old versioned-symlink (e.g. go-bin-v1.14.2):
# rename the versioned directory to the stable unversioned path
# so that all installed tools are preserved on upgrade.
mv "$b_old_target" "$b_gobin_stable"
rm -f "$GOBIN"
ln -s "$b_gobin_stable" "$GOBIN"
elif ! test -d "$b_old_target"; then
# Symlink target is gone; recreate ~/go as a real directory
rm -f "$GOBIN"
mkdir -p "$GOBIN/bin"
fi
# If already pointing to the stable unversioned dir, do nothing
return
fi
# If $GOBIN is already a real directory, leave it alone
# Real directory: leave it alone
if ! test -L "$GOBIN"; then
return
fi
b_old_target="$(readlink "$GOBIN")"
# Already pointing to the stable unversioned dir: nothing to do
if test "$b_old_target" = "$b_gobin_stable"; then
return
fi
# Migrate from old versioned-symlink (e.g. go-bin-v1.14.2):
# rename the versioned directory to the stable unversioned path
# so that all installed tools are preserved on upgrade.
if test -d "$b_old_target"; then
mv "$b_old_target" "$b_gobin_stable"
rm -f "$GOBIN"
ln -s "$b_gobin_stable" "$GOBIN"
return
fi
# Symlink target is gone; recreate ~/go as a real directory
rm -f "$GOBIN"
mkdir -p "$GOBIN/bin"
}
pkg_post_install() {