change how controller checks are handled (#454)

* change how controller checks are handled

* add changelog

* simpler fix

checks/multipleReplicasForDeployment.yaml

@@ -8,19 +8,14 @@ controllers:
 schema:
   '$schema': http://json-schema.org/draft-07/schema
   type: object
-  required: 
-  - Object
+  required:
+  - spec
   properties:
-    Object:
+    spec:
       type: object
       required:
-      - spec
+      - replicas
       properties:
-        spec:
-          type: object
-          required:
-          - replicas
-          properties:
-            replicas:
-              type: integer
-              minimum: 2
+        replicas:
+          type: integer
+          minimum: 2

docs-md/changelog.md

@@ -1,6 +1,12 @@
 ---
 sidebarDepth: 0
 ---
+## Upcoming
+* **Breaking** - fixed inconsistency in how controller-level checks are handled
+
+## 2.0.1
+* Fixed Polaris deployment process
+
 ## 2.0.0
 * Standardize categories of checks into Security, Reliability, and Efficiency
 * Changes to the dashboard UI

pkg/kube/workload.go

@@ -136,7 +136,8 @@ func newGenericWorkload(ctx context.Context, podResource kubeAPICoreV1.Pod, dyna
 	}
 
 	if lastKey != "" {
-		bytes, err := json.Marshal(objectCache[lastKey])
+		unst := objectCache[lastKey]
+		bytes, err := json.Marshal(&unst)
 		if err != nil {
 			return workload, err
 		}