github/podinfo
1
0
Fork 0
mirror of https://github.com/stefanprodan/podinfo.git synced 2026-08-23 22:26:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

address review comments

Browse Source
This commit is contained in:
Danny Kulchinsky
2026-06-03 16:04:17 -04:00
parent 64c73da55a
commit 6614fe3543
2 changed files with 24 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/api/http/fault_injection.go
+2 -4
View File
@@ -72,8 +72,7 @@ func (s *Server) faultInjectionMiddleware(next http.Handler) http.Handler {
// @Success 202 {string} string "OK"
func (s *Server) enableFaultInjectionHandler(w http.ResponseWriter, r *http.Request) {
atomic.StoreInt32(&faultInjection, 1)
w.WriteHeader(http.StatusAccepted)
s.JSONResponse(w, r, map[string]string{"fault_injection": "enabled"})
s.JSONResponseCode(w, r, map[string]string{"fault_injection": "enabled"}, http.StatusAccepted)
}
// DisableFaultInjection godoc
@@ -86,8 +85,7 @@ func (s *Server) enableFaultInjectionHandler(w http.ResponseWriter, r *http.Requ
// @Success 202 {string} string "OK"
func (s *Server) disableFaultInjectionHandler(w http.ResponseWriter, r *http.Request) {
atomic.StoreInt32(&faultInjection, 0)
w.WriteHeader(http.StatusAccepted)
s.JSONResponse(w, r, map[string]string{"fault_injection": "disabled"})
s.JSONResponseCode(w, r, map[string]string{"fault_injection": "disabled"}, http.StatusAccepted)
}
// FaultInjectionStatus godoc
pkg/api/http/fault_injection_test.go
+22 -10
View File
@@ -18,6 +18,12 @@ func TestFaultInjection_EnableDisable(t *testing.T) {
if rr.Code != http.StatusAccepted {
t.Fatalf("enable: got %d want %d", rr.Code, http.StatusAccepted)
}
if ct := rr.Header().Get("Content-Type"); !strings.HasPrefix(ct, "application/json") {
t.Errorf("enable: Content-Type = %q, want application/json", ct)
}
if !strings.Contains(rr.Body.String(), `"enabled"`) {
t.Errorf("enable: expected enabled in body, got: %s", rr.Body.String())
}
if atomic.LoadInt32(&faultInjection) != 1 {
t.Fatalf("faultInjection flag not set after enable")
}
@@ -28,6 +34,12 @@ func TestFaultInjection_EnableDisable(t *testing.T) {
if rr.Code != http.StatusAccepted {
t.Fatalf("disable: got %d want %d", rr.Code, http.StatusAccepted)
}
if ct := rr.Header().Get("Content-Type"); !strings.HasPrefix(ct, "application/json") {
t.Errorf("disable: Content-Type = %q, want application/json", ct)
}
if !strings.Contains(rr.Body.String(), `"disabled"`) {
t.Errorf("disable: expected disabled in body, got: %s", rr.Body.String())
}
if atomic.LoadInt32(&faultInjection) != 0 {
t.Fatalf("faultInjection flag not cleared after disable")
}
@@ -99,16 +111,16 @@ func TestFaultInjectionMiddleware(t *testing.T) {
func TestFaultInjectionExcluded(t *testing.T) {
cases := map[string]bool{
"/": false,
"/api/info": false,
"/healthz": true,
"/readyz": true,
"/metrics": true,
"/debug/pprof/": true,
"/fault_injection/enable": true,
"/fault_injection/disable": true,
"/fault_injection/status": true,
"/healthzz": false,
"/": false,
"/api/info": false,
"/healthz": true,
"/readyz": true,
"/metrics": true,
"/debug/pprof/": true,
"/fault_injection/enable": true,
"/fault_injection/disable": true,
"/fault_injection/status": true,
"/healthzz": false,
}
for p, want := range cases {
if got := faultInjectionExcluded(p); got != want {