github/paralus
1
0
Fork 0
mirror of https://github.com/paralus/paralus.git synced 2026-08-24 15:47:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve test coverage for project

Browse Source
This commit is contained in:
Abin Simon
2022-06-17 13:19:25 +05:30
parent 16b8a530fe
commit d3eafc6c9a
2 changed files with 148 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/service/project_test.go
+147
View File
@@ -7,8 +7,10 @@ import (
"github.com/DATA-DOG/go-sqlmock"
"github.com/google/uuid"
"github.com/paralus/paralus/pkg/common"
v3 "github.com/paralus/paralus/proto/types/commonpb/v3"
systemv3 "github.com/paralus/paralus/proto/types/systempb/v3"
userv3 "github.com/paralus/paralus/proto/types/userpb/v3"
)
func performProjectBasicChecks(t *testing.T, project *systemv3.Project, puuid string) {
@@ -66,6 +68,50 @@ func TestCreateProjectDuplicate(t *testing.T) {
}
}
func TestCreateProjectFull(t *testing.T) {
db, mock := getDB(t)
defer db.Close()
mazc := mockAuthzClient{}
ps := NewProjectService(db, &mazc, getLogger(), true)
puuid := uuid.New().String()
addFetchExpectation(mock, "organization")
addFetchEmptyExpecteation(mock, "project") // not existing project
mock.ExpectBegin()
mock.ExpectQuery(`INSERT INTO "authsrv_project"`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"id"}).AddRow(puuid))
addFetchExpectation(mock, "resourcerole")
addFetchExpectation(mock, "group")
mock.ExpectQuery(`INSERT INTO "authsrv_projectgrouprole"`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"id"}).AddRow(uuid.NewString()))
mock.ExpectQuery(`SELECT "identities"."id".* FROM "identities" WHERE .*traits ->> 'email' = 'test-user'`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"id", "traits"}).AddRow(uuid.NewString(), []byte(`{"email":"test-user", "first_name": "John", "last_name": "Doe", "description": "The OG user."}`)))
addFetchExpectation(mock, "resourcerole")
mock.ExpectQuery(`INSERT INTO "authsrv_projectaccountresourcerole"`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"id"}).AddRow(uuid.NewString()))
mock.ExpectCommit()
te := []string{"test-project", "test-namespace", "test-group", "test-role", "test-user"}
project := &systemv3.Project{
Metadata: &v3.Metadata{Id: puuid, Name: "project-" + puuid, Organization: "orgname"},
Spec: &systemv3.ProjectSpec{
ProjectNamespaceRoles: []*userv3.ProjectNamespaceRole{
{Project: &te[0], Namespace: &te[1], Group: &te[2], Role: te[3]},
},
UserRoles: []*userv3.UserRole{
{User: te[4], Role: te[3]},
},
},
}
project, err := ps.Create(context.Background(), project)
if err != nil {
t.Fatal("could not create project:", err)
}
performProjectBasicChecks(t, project, puuid)
}
func TestProjectDelete(t *testing.T) {
db, mock := getDB(t)
defer db.Close()
@@ -222,3 +268,104 @@ func TestProjectUpdate(t *testing.T) {
t.Fatal("could not update project:", err)
}
}
func TestProjectList(t *testing.T) {
db, mock := getDB(t)
defer db.Close()
mazc := mockAuthzClient{}
ps := NewProjectService(db, &mazc, getLogger(), true)
uid := uuid.NewString()
ouuid := addFetchExpectation(mock, "organization")
puuid := addFetchExpectation(mock, "partner")
mock.ExpectQuery(`SELECT "project"."id", "project"."name", .* FROM "authsrv_project" AS "project" WHERE \(partner_id = '` + puuid + `'\) AND \(organization_id = '` + ouuid + `'\) AND \(trash = false\)`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"id", "name"}).AddRow(uid, "project-"+uid))
mock.ExpectQuery(`SELECT distinct authsrv_resourcerole.name as role, authsrv_project.name as project, authsrv_group.name as group FROM "authsrv_projectgrouprole" JOIN authsrv_resourcerole ON authsrv_resourcerole.id=authsrv_projectgrouprole.role_id JOIN authsrv_group ON authsrv_group.id=authsrv_projectgrouprole.group_id JOIN authsrv_project ON authsrv_project.id=authsrv_projectgrouprole.project_id WHERE \(authsrv_projectgrouprole.project_id = '` + uid + `'\)`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"role", "project", "group"}).AddRow("test-role1", "test-project1", "test-group1"))
mock.ExpectQuery(`SELECT distinct authsrv_resourcerole.name as role, authsrv_project.name as project, authsrv_group.name as group, namespace FROM "authsrv_projectgroupnamespacerole" JOIN authsrv_resourcerole ON authsrv_resourcerole.id=authsrv_projectgroupnamespacerole.role_id JOIN authsrv_project ON authsrv_project.id=authsrv_projectgroupnamespacerole.project_id JOIN authsrv_group ON authsrv_group.id=authsrv_projectgroupnamespacerole.group_id WHERE \(authsrv_projectgroupnamespacerole.project_id = '` + uid + `'\)`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"role", "project", "group", "namespace"}).AddRow("test-role2", "test-project2", "test-group2", "test-namespace2"))
mock.ExpectQuery(`SELECT distinct authsrv_resourcerole.name as role, identities.traits ->> 'email' as user FROM "authsrv_projectaccountresourcerole" JOIN authsrv_resourcerole ON authsrv_resourcerole.id=authsrv_projectaccountresourcerole.role_id JOIN identities ON identities.id=authsrv_projectaccountresourcerole.account_id WHERE \(authsrv_projectaccountresourcerole.project_id = '` + uid + `'\)`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"role", "user"}).AddRow("test-role3", "test-user3"))
project := &systemv3.Project{
Metadata: &v3.Metadata{
Organization: ouuid,
},
}
pl, err := ps.List(context.Background(), project)
if err != nil {
t.Fatal("could not get project:", err)
}
if pl.Metadata.Count != 1 {
t.Errorf("incorrect number of projects returned; expected '%v', got '%v'", 1, pl.Metadata.Count)
}
if pl.Items[0].Metadata.Name != "project-"+uid {
t.Errorf("incorrect project name; expected '%v', got '%v'", "project-"+uid, pl.Items[0].Metadata.Name)
}
if *pl.Items[0].Spec.ProjectNamespaceRoles[0].Project != "test-project1" {
t.Errorf("incorrect projectnamespacerole; expected '%v', got '%v'", "test-project1", *pl.Items[0].Spec.ProjectNamespaceRoles[0].Project)
}
if *pl.Items[0].Spec.ProjectNamespaceRoles[1].Namespace != "test-namespace2" {
t.Errorf("incorrect projectnamespacerole; expected '%v', got '%v'", "test-namespace2", *pl.Items[0].Spec.ProjectNamespaceRoles[1].Namespace)
}
if pl.Items[0].Spec.UserRoles[0].User != "test-user3" {
t.Errorf("incorrect userrole; expected '%v', got '%v'", "test-user3", pl.Items[0].Spec.UserRoles[0].User)
}
}
func TestProjectListNonDev(t *testing.T) {
db, mock := getDB(t)
defer db.Close()
mazc := mockAuthzClient{}
ps := NewProjectService(db, &mazc, getLogger(), false)
uid := uuid.NewString()
ouuid := addFetchExpectation(mock, "organization")
puuid := addFetchExpectation(mock, "partner")
uuuid := addUserFetchExpectation(mock)
mock.ExpectQuery(`SELECT distinct account_id, project_id FROM "sentry_account_permission" AS "sap" WHERE \(sap.partner_id = '` + puuid + `'\) AND \(sap.organization_id = '` + ouuid + `'\) AND \(sap.account_id = '` + uuuid + `'\) AND \(sap.permission_name IN \('project.read', 'ops_star.all'\)\)`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"account_id", "project_id"}).AddRow(uuuid, uid))
mock.ExpectQuery(`SELECT "project"."id", "project"."name", .* FROM "authsrv_project" AS "project" WHERE \(project.partner_id = '` + puuid + `'\) AND \(project.organization_id = '` + ouuid + `'\) AND \(project.trash = FALSE\) AND \(project.id IN \('` + uid + `'\)\)`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"id", "name"}).AddRow(uid, "project-"+uid))
mock.ExpectQuery(`SELECT distinct authsrv_resourcerole.name as role, authsrv_project.name as project, authsrv_group.name as group FROM "authsrv_projectgrouprole" JOIN authsrv_resourcerole ON authsrv_resourcerole.id=authsrv_projectgrouprole.role_id JOIN authsrv_group ON authsrv_group.id=authsrv_projectgrouprole.group_id JOIN authsrv_project ON authsrv_project.id=authsrv_projectgrouprole.project_id WHERE \(authsrv_projectgrouprole.project_id = '` + uid + `'\)`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"role", "project", "group"}).AddRow("test-role1", "test-project1", "test-group1"))
mock.ExpectQuery(`SELECT distinct authsrv_resourcerole.name as role, authsrv_project.name as project, authsrv_group.name as group, namespace FROM "authsrv_projectgroupnamespacerole" JOIN authsrv_resourcerole ON authsrv_resourcerole.id=authsrv_projectgroupnamespacerole.role_id JOIN authsrv_project ON authsrv_project.id=authsrv_projectgroupnamespacerole.project_id JOIN authsrv_group ON authsrv_group.id=authsrv_projectgroupnamespacerole.group_id WHERE \(authsrv_projectgroupnamespacerole.project_id = '` + uid + `'\)`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"role", "project", "group", "namespace"}).AddRow("test-role2", "test-project2", "test-group2", "test-namespace2"))
mock.ExpectQuery(`SELECT distinct authsrv_resourcerole.name as role, identities.traits ->> 'email' as user FROM "authsrv_projectaccountresourcerole" JOIN authsrv_resourcerole ON authsrv_resourcerole.id=authsrv_projectaccountresourcerole.role_id JOIN identities ON identities.id=authsrv_projectaccountresourcerole.account_id WHERE \(authsrv_projectaccountresourcerole.project_id = '` + uid + `'\)`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"role", "user"}).AddRow("test-role3", "test-user3"))
project := &systemv3.Project{
Metadata: &v3.Metadata{
Organization: ouuid,
},
}
sd := v3.SessionData{Username: "user-" + uuuid}
ctx := context.WithValue(context.Background(), common.SessionDataKey, &sd)
pl, err := ps.List(ctx, project)
if err != nil {
t.Fatal("could not get project:", err)
}
if pl.Metadata.Count != 1 {
t.Errorf("incorrect number of projects returned; expected '%v', got '%v'", 1, pl.Metadata.Count)
}
if pl.Items[0].Metadata.Name != "project-"+uid {
t.Errorf("incorrect project name; expected '%v', got '%v'", "project-"+uid, pl.Items[0].Metadata.Name)
}
if *pl.Items[0].Spec.ProjectNamespaceRoles[0].Project != "test-project1" {
t.Errorf("incorrect projectnamespacerole; expected '%v', got '%v'", "test-project1", *pl.Items[0].Spec.ProjectNamespaceRoles[0].Project)
}
if *pl.Items[0].Spec.ProjectNamespaceRoles[1].Namespace != "test-namespace2" {
t.Errorf("incorrect projectnamespacerole; expected '%v', got '%v'", "test-namespace2", *pl.Items[0].Spec.ProjectNamespaceRoles[1].Namespace)
}
if pl.Items[0].Spec.UserRoles[0].User != "test-user3" {
t.Errorf("incorrect userrole; expected '%v', got '%v'", "test-user3", pl.Items[0].Spec.UserRoles[0].User)
}
}
pkg/service/test_utils.go
+1 -1
View File
@@ -88,7 +88,7 @@ func addFetchByIdExpectation(mock sqlmock.Sqlmock, resource, uid string) {
}
func addFetchIdByNameExpectation(mock sqlmock.Sqlmock, resource, name string) string {
uid := uuid.New().String()
uid := uuid.NewString()
mock.ExpectQuery(`SELECT "` + resource + `"."id" FROM "authsrv_` + resource + `" AS "` + resource + `" WHERE .name = '` + name + `'.`).
WithArgs().WillReturnRows(sqlmock.NewRows([]string{"id"}).AddRow(uid))
return uid