separate manifest controllers

pkg/spoke/controllers/manifestcontroller/manifestwork_controller.go

@@ -1,4 +1,4 @@
-package controllers
+package manifestcontroller
 
 import (
 	"context"
@@ -103,6 +103,11 @@ func (m *ManifestWorkController) sync(ctx context.Context, controllerContext fac
 	}
 	manifestWork = manifestWork.DeepCopy()
 
+	// no work to do if we're deleted
+	if !manifestWork.DeletionTimestamp.IsZero() {
+		return nil
+	}
+
 	errs := []error{}
 	// Apply resources on spoke cluster.
 	resourceResults := m.applyManifest(manifestWork.Spec.Workload.Manifests, controllerContext.Recorder())

pkg/spoke/controllers/manifestcontroller/manifestwork_controller_test.go

@@ -1,4 +1,4 @@
-package controllers
+package manifestcontroller
 
 import (
 	"fmt"

pkg/spoke/spokeagent.go

@@ -4,6 +4,8 @@ import (
 	"context"
 	"time"
 
+	"github.com/open-cluster-management/work/pkg/spoke/controllers/manifestcontroller"
+
 	"github.com/open-cluster-management/work/pkg/spoke/controllers/finalizercontroller"
 
 	"github.com/openshift/library-go/pkg/controller/controllercmd"
@@ -17,7 +19,6 @@ import (
 
 	workclientset "github.com/open-cluster-management/api/client/work/clientset/versioned"
 	workinformers "github.com/open-cluster-management/api/client/work/informers/externalversions"
-	"github.com/open-cluster-management/work/pkg/spoke/controllers"
 	"github.com/open-cluster-management/work/pkg/spoke/resource"
 )
 
@@ -79,7 +80,7 @@ func (o *WorkloadAgentOptions) RunWorkloadAgent(ctx context.Context, controllerC
 	restMapper := resource.NewMapper(cachedSpokeDiscoveryClient)
 	go restMapper.Run(ctx.Done())
 
-	manifestWorkController := controllers.NewManifestWorkController(
+	manifestWorkController := manifestcontroller.NewManifestWorkController(
 		ctx,
 		controllerContext.EventRecorder,
 		spokeDynamicClient,