🌱 Remove resolved TODO comments (#1177)
Some checks failed
Scorecard supply-chain security / Scorecard analysis (push) Failing after 50s
Post / coverage (push) Failing after 55s
Post / images (amd64, addon-manager) (push) Failing after 36s
Post / images (amd64, placement) (push) Failing after 40s
Post / images (amd64, registration) (push) Failing after 28s
Post / images (amd64, registration-operator) (push) Failing after 20s
Post / images (amd64, work) (push) Failing after 29s
Post / images (arm64, addon-manager) (push) Failing after 33s
Post / images (arm64, placement) (push) Failing after 32s
Post / images (arm64, registration) (push) Failing after 25s
Post / images (arm64, registration-operator) (push) Failing after 33s
Post / images (arm64, work) (push) Failing after 29s
Post / image manifest (addon-manager) (push) Has been skipped
Post / image manifest (placement) (push) Has been skipped
Post / image manifest (registration) (push) Has been skipped
Post / image manifest (registration-operator) (push) Has been skipped
Post / image manifest (work) (push) Has been skipped
Post / trigger clusteradm e2e (push) Has been skipped

* 🧹 Remove resolved TODO comments

- Remove TODO comment about confirming subject in CustomSignerConfigurations
- Remove TODO comment about namespace value in manifestwork validating webhook

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: zhujian <jiazhu@redhat.com>

* Ensure addon namespace and image pull secret sync

- Remove outdated TODO comment about addon deployment in Hosted mode
- Namespace creation is responsibility of addon developers
- Image pull secrets are synced to namespaces with addon.open-cluster-management.io/namespace label by the AddonPullImageSecretController

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: zhujian <jiazhu@redhat.com>

---------

Signed-off-by: zhujian <jiazhu@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Jian Zhu
2025-09-15 10:20:53 +08:00
committed by GitHub
parent df5b456f88
commit 1125e4c33d
4 changed files with 2 additions and 4 deletions

View File

@@ -157,7 +157,6 @@ func CustomSignerConfigurations(addonName, agentName string,
}
config := addonapiv1alpha1.RegistrationConfig{
SignerName: customSignerConfig.SignerName,
// TODO: confirm the subject
Subject: addonapiv1alpha1.Subject{
User: agent.DefaultUser(cluster.Name, addonName, agentName),
Groups: agent.DefaultGroups(cluster.Name, addonName),

View File

@@ -60,7 +60,6 @@ func (r *managedReconcile) reconcile(ctx context.Context, klusterlet *operatorap
if !config.DisableAddonNamespace {
// For now, whether in Default or Hosted mode, the addons will be deployed on the managed cluster.
// sync image pull secret from management cluster to managed cluster for addon namespace
// TODO(zhujian7): In the future, we may consider deploy addons on the management cluster in Hosted mode.
// Ensure the addon namespace on the managed cluster
if err := ensureNamespace(
ctx,

View File

@@ -34,7 +34,7 @@ type Options struct {
// RunKlusterletOperator starts a new klusterlet operator
func (o *Options) RunKlusterletOperator(ctx context.Context, controllerContext *controllercmd.ControllerContext) error {
// Build kube client and informer for managed cluster
// Build kube client and informer
kubeClient, err := kubernetes.NewForConfig(controllerContext.KubeConfig)
if err != nil {
return err

View File

@@ -88,7 +88,7 @@ func validateExecutor(kubeClient kubernetes.Interface, work *workv1.ManifestWork
Type: workv1.ExecutorSubjectTypeServiceAccount,
ServiceAccount: &workv1.ManifestWorkSubjectServiceAccount{
// give the default value "system:serviceaccount::klusterlet-work-sa"
Namespace: "", // TODO: Not sure what value is reasonable
Namespace: "",
Name: "klusterlet-work-sa", // the default sa of the work agent
},
},