Commit Graph
182 Commits
Author SHA1 Message Date
gkGaneshR 821b8f41aa Modify unit testing of cmd/options
1. Why is this change necessary ?
   Modify unit testing of options in such a way that we specify
the WantedNodeName

2. How to verify this change ?
   Run, make test

Signed-off-by: gkGaneshR <gkganesh126@gmail.com>
2018-03-09 13:17:52 +05:30
gkGaneshR ca76dc12ee Add dot(.) at the end of comments
Signed-off-by: gkGaneshR <gkganesh126@gmail.com>
2018-03-09 12:08:05 +05:30
gkGaneshR c75a35099e Avoided changing hostname and changing var names
1. Why is this change necessary ?
 The program avoids changing hostname and the variable name "Options" is changed to
"options". Also, added more comments and formatted. Removed hostname in options since
it will not be changed in tests.

2. How does this change address the issue ?
 While the program is being run, the hostname is not changed. And options can't be
accessed outside(not exported).

3. How to verify this change ?
 Run, make test

Signed-off-by: gkGaneshR <gkganesh126@gmail.com>
2018-03-05 13:49:10 +05:30
gkGaneshR a591ce52f9 Added copyright 2018 statement
1. Why is this change necessary ?
 Added copyright 2018 statement on options_test.go and added space
between // and text on the comments.

Signed-off-by: gkGaneshR <gkganesh126@gmail.com>
2018-03-04 21:05:16 +05:30
gkGaneshR 3868f48586 Include cmd/options in Makefile's test
1. Why is this change necessary ?
 Solves kubernetes/node-problem-detector#163

2. How does this change address the issue ?
 Unit testing for node-problem-detector/cmd/options is yet to be
done and the corresponding package path needs to be included in makefile
test

3. How to verify this change ?
 make test command should run the test TestSetNodeNameOrDie with admin
privileges.

Signed-off-by: gkGaneshR <gkganesh126@gmail.com>
2018-03-02 21:49:07 +05:30
gkGaneshR 25b6c169a2 Unit testing for SetNodeNameOrDie in package cmd/options
1. Why is this change necessary ?
fixes: kubernetes/node-problem-detector#161

2. How does this change address the issue ?
Under package cmd/options, the testing for SetNodeNameOrDie need
to decide Nodename based on environment variable "NODE_NAME" or
hostname or hostnameoverride variable.

3. How to verify this change ?
Run "go test" with admin privilege

Signed-off-by: gkGaneshR <gkganesh126@gmail.com>
2018-03-02 21:03:59 +05:30
Lantao LiuandGitHub cf3519a3e9 Merge pull request #152 from rramkumar1/network-problem-script
Network problem script
2018-01-02 19:54:10 -08:00
Lantao LiuandGitHub eab61e8df9 Merge pull request #154 from thockin-tmp/gcr-vanity
Convert registry to k8s.gcr.io
2018-01-02 17:16:54 -08:00
Lantao LiuandGitHub c10c302d31 Merge pull request #153 from spiffxp/add-code-of-conduct
Add code-of-conduct.md
2018-01-02 17:15:35 -08:00
Tim Hockin 547c65ef89 Convert registry to k8s.gcr.io 2017-12-22 09:55:16 -08:00
Aaron Crickenberger 5438c1b5fa Add code-of-conduct.md
Refer to kubernetes/community as authoritative source for code of conduct
2017-12-20 13:39:38 -05:00
Rohit Ramkumar 69b6b58ee3 Addressed comments 2017-12-19 08:32:27 -08:00
Rohit Ramkumar cd472c7765 Add empty conditions list 2017-11-27 11:35:48 -08:00
Rohit Ramkumar fb12f3b70e Add network monitor script as plugin 2017-11-27 11:33:38 -08:00
Lantao LiuandGitHub ec470b65b0 Merge pull request #145 from andyxning/add_custom_problem_detector_plugin
add custom problem detector plugin
2017-11-22 10:53:06 -08:00
Andy Xie 10dbfef1a8 add custom problem detector plugin 2017-11-22 10:14:09 +08:00
Lantao LiuandGitHub ffc790976b Merge pull request #140 from andyxning/adapt_for_golang_1.8_and_1.9
update golang to 1.8 and 1.9
2017-10-10 23:14:25 -07:00
Andy Xie 7f72f11d60 update golang to 1.8 and 1.9 2017-10-11 13:25:07 +08:00
Lantao LiuandGitHub 92a3294018 Merge pull request #139 from CaoShuFeng/README
update README
2017-09-22 10:38:55 -07:00
Cao Shufeng b18ddc86d2 update README
update description about `Build Image`. When running `make`, it will
not push image to registry.
2017-09-19 15:04:03 +08:00
Lantao LiuandGitHub c0bd1df745 Merge pull request #134 from CaoShuFeng/trival
return an error when error happens in SetConditions()
2017-08-23 11:01:25 -07:00
Cao Shufeng b939fb575a return an error when error happens in SetConditions() 2017-08-23 17:56:15 +08:00
Lantao LiuandGitHub 93d38ce067 Merge pull request #132 from asifdxtreme/patch-1
Split Test and Build in Different Stages
2017-08-07 10:06:57 -07:00
Lantao LiuandGitHub 7e282b520c Merge pull request #131 from mbssaiakhil/patch-1
Fixed Typo in README of node-problem-detecter
2017-08-07 10:05:52 -07:00
Mohammad Asif SiddiquiandGitHub ac09ce8d32 Split Test and Build in Different Stages 2017-08-07 16:43:50 +08:00
Malepati Bala Siva Sai AkhilandGitHub 6753f10933 Fixed Typo in README of node-problem-detecter 2017-08-06 09:02:35 +05:30
Lantao LiuandGitHub 4f19101a65 Merge pull request #130 from fisherxu/master
fix typo
2017-08-04 10:18:27 -07:00
Lantao LiuandGitHub d53eae080e Merge pull request #129 from asifdxtreme/master
Add Build Status and GoReportCard badge
2017-08-04 10:10:42 -07:00
fisherxu 06c82c0af4 fix typo 2017-08-05 01:06:07 +08:00
Mohammad Asif SiddiquiandGitHub 6700a1e6df Add Build Status and GoReportCard badge 2017-08-04 18:32:40 +08:00
Lantao LiuandGitHub 8bda8dae48 Merge pull request #128 from ajitak/port
change NPD port as there is a port collision with kube-proxy
2017-07-27 07:46:28 -07:00
Ajit Kumar 5cfe97cd15 change NPD port 2017-07-20 10:36:41 -07:00
Lantao LiuandGitHub 0237e4dbf4 Merge pull request #119 from Random-Liu/fix-doc
Clarify the limitation of log matching pattern.
2017-06-27 09:15:14 -07:00
Lantao LiuandGitHub 9b2892670b Merge pull request #123 from Random-Liu/fix-gcloud-push
Now gcloud enforce `--` before docker args.
2017-06-27 09:15:09 -07:00
Random-Liu b4714a4b79 Now gcloud enforce -- before docker args.
Signed-off-by: Random-Liu <lantaol@google.com>
2017-06-21 16:14:41 -07:00
Lantao LiuandGitHub b6205ea2d9 Merge pull request #117 from ajitak/npd-config
Add rule for docker image pull error
2017-06-21 14:08:18 -07:00
Ajit Kumar d2de52f090 Add rule for docker image pull error 2017-06-21 13:48:58 -07:00
Random-Liu f5a7ead8d6 Clarify the limitation of log matching pattern. 2017-06-20 18:11:29 -07:00
Dawn ChenandGitHub f076eafcb1 Merge pull request #112 from Random-Liu/cleanup-kmsg-log-watcher
Cleanup kmsg log watcher
v0.4.0
2017-05-30 16:45:37 -07:00
Random-Liu 51351f91b2 Cleanup kmsg log wather. 2017-05-30 15:58:45 -07:00
Lantao LiuandGitHub be6c516cfd Merge pull request #41 from euank/kmsg-parser
logwatchers: add new kmsg-based kernel log watcher
2017-05-30 15:53:24 -07:00
Lantao LiuandGitHub 9f20903fe0 Merge pull request #111 from juliusmilan/abrt-readme-and-ccpp-fix
Abrt readme and ccpp fix
2017-05-15 08:58:21 -07:00
Julius Milan 69667975d0 Update README.md
Add description of ABRT usage.
2017-05-12 15:20:26 +02:00
Julius Milan b579984f0a Fix abrt-adaptor config for cpp problems
This modifies pattern for catching cpp problem messages produced by
ABRT. Found that not all mentioned messages fit into former pattern.
For example following is valid cpp problem message produced by ABRT:

Process xxx (bad_binary) crashed in Will::Fail::a() [clone .isra.2]()

but doesn't fit former pattern, since it's last part contains
whitespaces.
2017-05-11 15:40:25 +02:00
Lantao LiuandGitHub 9c29602e32 Merge pull request #105 from juliusmilan/abrt-adaptor-config
Add ABRT adaptor config
2017-03-29 10:44:41 -07:00
Lantao LiuandGitHub 7843f6e70e Merge pull request #103 from zhangxiaoyu-zidif/patch-2
update README.md
2017-03-27 10:55:43 -07:00
Julius Milan abcf6a4f4b Add ABRT adaptor config 2017-03-23 16:15:56 +01:00
Xiaoyu ZhangandGitHub 9e06774034 update README.md
add "which" into the document.
2017-03-19 18:46:16 +08:00
Dawn ChenandGitHub c7a9ab7784 Merge pull request #99 from Random-Liu/add-test-kernel-log-generator
Add test kernel log generator.
2017-03-15 13:28:39 -07:00
Dawn ChenandGitHub b3b5766d8f Merge pull request #98 from Random-Liu/fix-journald-plugin
Fix journald plugin to only look at the current boot.
2017-03-13 20:24:05 -07:00