github/node-problem-detector
1
0
Fork 0
mirror of https://github.com/kubernetes/node-problem-detector.git synced 2026-08-19 12:16:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use debian-base image from kubernetes repository as base for NPD.

Browse Source 
This image is based on Debian Stretch (9) which has a recent version of
systemd libraries that includes all necessary compression algorithms.

I propose using that image unconditionally (instead of Alpine when
journald is disabled) since the image size with debian-base is not that
much of a concern anymore.
This commit is contained in:
Filipe Brandenburger
2018-02-14 11:54:19 -08:00
parent c430627afa
commit ca2fc22678
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Makefile
+4 -5
View File
@@ -50,18 +50,17 @@ IMAGE:=$(REGISTRY)/node-problem-detector:$(TAG)
ENABLE_JOURNALD?=1
# TODO(random-liu): Support different architectures.
BASEIMAGE:=alpine:3.4
# The debian-base:0.3 image built from kubernetes repository is based on Debian Stretch.
# It includes systemd 232 with support for both +XZ and +LZ4 compression.
# +LZ4 is needed on some os distros such as COS.
BASEIMAGE:=gcr.io/google-containers/debian-base-amd64:0.3
# Disable cgo by default to make the binary statically linked.
CGO_ENABLED:=0
# NOTE that enable journald will increase the image size.
ifeq ($(ENABLE_JOURNALD), 1)
# Enable journald build tag.
BUILD_TAGS:=-tags journald
# Use fedora because it has newer systemd version (229) and support +LZ4. +LZ4 is needed
# on some os distros such as GCI.
BASEIMAGE:=fedora
# Enable cgo because sdjournal needs cgo to compile. The binary will be dynamically
# linked if CGO_ENABLED is enabled. This is fine because fedora already has necessary
# dynamic library. We can not use `-extldflags "-static"` here, because go-systemd uses