Merge pull request #1094 from hakman/fix-tests
CodeQL / Analyze (go) (push) Failing after 3m16s
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1m36s

Fix test instance name
This commit is contained in:
Kubernetes Prow Robot
2025-08-11 23:29:06 -07:00
committed by GitHub
+3 -1
View File
@@ -51,7 +51,7 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() {
}
instance, err = gce.CreateInstance(
gce.Instance{
Name: "npd-metrics-" + *image + "-" + uuid.NewUUID().String()[:8],
Name: "npd-metrics-" + uuid.NewUUID().String()[:8],
Zone: *zone,
Project: *project,
SshKey: *sshKey,
@@ -130,6 +130,7 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() {
})
ginkgo.It("NPD should update problem_counter{reason:Ext4Error} and problem_gauge{type:ReadonlyFilesystem}", func() {
ginkgo.Skip("Writing to /sys/fs/ext4/sda1/trigger_fs_error breaks SSH: https://github.com/kubernetes/node-problem-detector/issues/970")
time.Sleep(5 * time.Second)
assertMetricValueAtLeast(instance,
"problem_counter", map[string]string{"reason": "Ext4Error"},
@@ -140,6 +141,7 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() {
})
ginkgo.It("NPD should remain healthy", func() {
ginkgo.Skip("Writing to /sys/fs/ext4/sda1/trigger_fs_error breaks SSH: https://github.com/kubernetes/node-problem-detector/issues/970")
npdStates := instance.RunCommandOrFail("sudo systemctl show node-problem-detector -p ActiveState -p SubState")
Expect(npdStates.Stdout).To(ContainSubstring("ActiveState=active"), "NPD is no longer active: %v", npdStates)
Expect(npdStates.Stdout).To(ContainSubstring("SubState=running"), "NPD is no longer running: %v", npdStates)