github/kured
1
0
Fork 0
mirror of https://github.com/kubereboot/kured.git synced 2026-08-23 21:36:33 +00:00
Code Issues Packages Projects Releases Wiki Activity
371 Commits 14 Branches 50 Tags
837bd4eb2a02dede484cd4a1684ae0dd262d4fdb
Commit Graph
371 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jean-Philippe Evrard 837bd4eb2a Refactor reboot blocks 
Without this patch, we rely on global state in many functions for
which we check the reboot blockers.

This is a problem, as it's harder to test.

This patch fixes it by refactoring the reboot blockers. This also
includes a first series of unit tests for our main.
 2021-03-29 09:50:56 +02:00
Jean-Philippe Evrard 2a95f0b6c8 Fix periodic jobs 
Without this patch, the version of 1.20 is taken in jobs as 1.2.
This is a problem, as it breaks all jobs, because there is no
file to provision a cluster with kubernetes 1.2 (and we shouldn't
do this!)

This fixes it by ensuring there is no mangling of the version
strings, and therefore the right file is used.
 2021-03-24 14:29:26 +01:00
Jean-Philippe Evrard 15c57927c8 Update the deprecated DeleteLocalData 
DeleteLocalData was deprecated for users of kubectl in 0.20 [1].
At the same time of the deprecation, the relevant code was also
removed [2] without warning: The DeleteLocalData from the helper
structure was simply renamed DeleteEmptyDirData, without shims
on the exposed pkg.

This is a problem, as it completely breaks kured.

This should fix it, by using the new field name.

[1]:
https://github.com/kubernetes/kubectl/commit/56ea9621b7fc333d2d2dde8ae39c15cacf28dbf7
[2]:
https://github.com/kubernetes/kubectl/commit/56ea9621b7fc333d2d2dde8ae39c15cacf28dbf7#diff-041bdcdedca650a38a8d82cf15ab6f3665b7b84a0fb44a8bb5dcdc5cd944c63d
 2021-03-22 14:28:17 +01:00
Jean-Philippe Evrard 20cbf6112d Bouncing go.mod with latest kubernetes packages 
Without this patch, go.mod will lag behind for the kubernetes
packages, as it's not automatically tested by dependabot.

We should bump versions with each new minor release of kured.

This should fix it.
 2021-03-22 14:28:17 +01:00
Christian Kotzbauer f668bdb1ba Merge pull request #325 from weaveworks/stale-duration 
Extend close-duration for stale issues and prs
 2021-03-19 11:36:18 +01:00
Christian Kotzbauer 8209647e69 change comment accordingly 
Signed-off-by: Christian Kotzbauer <christian.kotzbauer@gmail.com>
 2021-03-19 10:20:32 +01:00
Christian Kotzbauer 46354837f9 extend close-duration for stale issues and prs 
Signed-off-by: Christian Kotzbauer <christian.kotzbauer@gmail.com>
 2021-03-19 08:26:11 +01:00
Jean-Philippe Evrard de2e0bb2c8 Merge pull request #321 from dholbach/add-maintainers 
Adding a MAINTAINERS file
 2021-03-11 14:41:49 +01:00
Daniel Holbach 2b88b72d38 Merge pull request #318 from jackfrancis/node-annotations-chart 
update chart definition to include --annotate-nodes
 2021-03-11 12:04:39 +01:00
Jack Francis 87e610c25f update chart definition to include --annotate-nodes 2021-03-10 16:03:46 -08:00
Daniel Holbach fe4ad73c2d Adding a MAINTAINERS file 
Signed-off-by: Daniel Holbach <daniel@weave.works>
 2021-03-10 18:16:11 +01:00
Daniel Holbach f6ada05c5d Merge pull request #320 from dholbach/alpine-3.13 
update to alpine 3.13
 2021-03-10 08:50:42 +01:00
Daniel Holbach 355813de30 update to alpine 3.13 
Signed-off-by: Daniel Holbach <daniel@weave.works>
 2021-03-10 08:10:36 +01:00
Daniel Holbach 8a5f69480b Merge pull request #319 from weaveworks/dependabot/go_modules/github.com/sirupsen/logrus-1.8.1 
Bump github.com/sirupsen/logrus from 1.8.0 to 1.8.1
 2021-03-10 08:07:11 +01:00
Daniel Holbach 1e0fc11b01 Merge pull request #316 from weaveworks/dependabot/github_actions/actions/stale-v3.0.18 
Bump actions/stale from v3.0.17 to v3.0.18
 2021-03-10 07:55:11 +01:00
dependabot[bot] 2218e29504 Bump github.com/sirupsen/logrus from 1.8.0 to 1.8.1 
Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/sirupsen/logrus/releases)
- [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sirupsen/logrus/compare/v1.8.0...v1.8.1)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-03-10 05:55:36 +00:00
Daniel Holbach 250b9bad05 Merge pull request #296 from jackfrancis/node-annotations 
add node annotations to identify kured reboot operations
 2021-03-09 10:14:46 +01:00
Daniel Holbach 32e01a8417 Merge pull request #294 from jackfrancis/always-drain 
always drain before reboot
 2021-03-09 10:13:36 +01:00
Jack Francis baf83408b8 add node annotations 
adds a new --annotate-nodes daemonset runtime argument, which does the following when enabled:

- adds a new node annotation "weave.works/kured-most-recent-reboot-needed" with a value of the current RFC3339 timestamp as soon as kured identifies that a node needs to be rebooted
- adds a new node annotation "weave.works/kured-reboot-in-progress" with a value of the current RFC3339 timestamp as soon as kured identifies that a node needs to be rebooted
- removes the annotation "weave.works/kured-reboot-in-progress" when kured has successfully rebooted the node
 2021-03-08 17:22:47 -08:00
Jack Francis 93c8242b89 always drain before reboot 
This changes the pre-reboot drain functionality so that it always runs, regardless of the value of the Unschedulable node property.

Because kubectl drain is idempotent, we shouldn't have to worry about whether the node has already been set to Unschedulable (perhaps due to a prior, unsuccessful loop of the kured reboot cycle): we can run it over and over again. And because this drain func actually does a cordon + drain (and it only performs the drain if a cordon is successful), we can be sure that we aren't going to be thrashing this node w/ respect to scheduled pods.

This also fixes an edge case: if the node has been marked Unschedulable out-of-band, but workloads remain Running on this node, kured will no longer reboot the node's underlying VM/machine while it is actively running pods.
 2021-03-08 17:20:31 -08:00
dependabot[bot] c3d4c36493 Bump actions/stale from v3.0.17 to v3.0.18 
Bumps [actions/stale](https://github.com/actions/stale) from v3.0.17 to v3.0.18.
- [Release notes](https://github.com/actions/stale/releases)
- [Commits](https://github.com/actions/stale/compare/v3.0.17...3b3c3f03cd4d8e2b61e179ef744a0d20efbe90b4)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-03-08 06:35:26 +00:00
Daniel Holbach 1fd09dd572 Merge pull request #310 from weaveworks/dependabot/go_modules/github.com/sirupsen/logrus-1.8.0 
Bump github.com/sirupsen/logrus from 1.7.0 to 1.8.0
 2021-03-02 10:48:41 +01:00
Daniel Holbach d21a438197 Merge pull request #311 from weaveworks/dependabot/github_actions/actions/stale-v3.0.17 
Bump actions/stale from v3.0.16 to v3.0.17
 2021-03-02 10:48:15 +01:00
dependabot[bot] 3fdd1cf6f7 Bump actions/stale from v3.0.16 to v3.0.17 
Bumps [actions/stale](https://github.com/actions/stale) from v3.0.16 to v3.0.17.
- [Release notes](https://github.com/actions/stale/releases)
- [Commits](https://github.com/actions/stale/compare/v3.0.16...996798eb71ef485dc4c7b4d3285842d714040c4a)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-02-19 05:49:06 +00:00
dependabot[bot] 48688044d5 Bump github.com/sirupsen/logrus from 1.7.0 to 1.8.0 
Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/sirupsen/logrus/releases)
- [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sirupsen/logrus/compare/v1.7.0...v1.8.0)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-02-18 05:49:25 +00:00
Daniel Holbach 640613565d Merge pull request #305 from weaveworks/dependabot/go_modules/github.com/spf13/cobra-1.1.3 
Bump github.com/spf13/cobra from 1.1.2 to 1.1.3
 2021-02-16 12:18:40 +01:00
dependabot[bot] 763695de5c Bump github.com/spf13/cobra from 1.1.2 to 1.1.3 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.2 to 1.1.3.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spf13/cobra/compare/v1.1.2...v1.1.3)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-02-11 05:52:43 +00:00
Daniel Holbach 6ff5722728 Merge pull request #304 from weaveworks/dependabot/go_modules/github.com/spf13/cobra-1.1.2 
Bump github.com/spf13/cobra from 1.1.1 to 1.1.2
 2021-02-10 12:40:27 +01:00
dependabot[bot] 472934e958 Bump github.com/spf13/cobra from 1.1.1 to 1.1.2 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spf13/cobra/compare/v1.1.1...v1.1.2)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-02-10 05:53:05 +00:00
Daniel Holbach b7f29c76ce Merge pull request #302 from weaveworks/coc 
Point to CNCF Code of Conduct
 2021-02-08 17:40:40 +01:00
Daniel Holbach fa4e458f1f Merge pull request #300 from t3mi/master 
add podLabels parameter
 2021-02-08 16:05:24 +01:00
Daniel Holbach 4fc93d550d Merge pull request #301 from weaveworks/dependabot/github_actions/actions/stale-v3.0.16 
Bump actions/stale from v3.0.15 to v3.0.16
 2021-02-08 16:04:16 +01:00
Daniel Holbach 6eb9050156 Point to CNCF Code of Conduct 2021-02-08 11:35:50 +01:00
dependabot[bot] d8b7669ab4 Bump actions/stale from v3.0.15 to v3.0.16 
Bumps [actions/stale](https://github.com/actions/stale) from v3.0.15 to v3.0.16.
- [Release notes](https://github.com/actions/stale/releases)
- [Commits](https://github.com/actions/stale/compare/v3.0.15...9d6f46564a515a9ea11e7762ab3957ee58ca50da)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-02-08 06:26:07 +00:00
t3mi d52d78a303 add podLabels parameter 2021-02-07 23:58:55 +02:00
Daniel Holbach 6a8e3f1e98 Merge pull request #298 from weaveworks/dependabot/github_actions/actions/stale-v3.0.15 
Bump actions/stale from v3.0.14 to v3.0.15
 2021-01-25 10:05:12 +01:00
dependabot[bot] b39c9011ea Bump actions/stale from v3.0.14 to v3.0.15 
Bumps [actions/stale](https://github.com/actions/stale) from v3.0.14 to v3.0.15.
- [Release notes](https://github.com/actions/stale/releases)
- [Commits](https://github.com/actions/stale/compare/v3.0.14...86561461b92875de77a8b2d2e75f004c826e8f45)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-01-25 06:54:10 +00:00
Daniel Holbach fade706cbf Merge pull request #250 from damoon/19-PreferNoSchedule 
implement issue-19 add prefer no schedule taint to avoid double draining of pods
 2021-01-12 14:28:23 +01:00
David Sauer 5a4e197d27 change taint config to be disabled by default 2021-01-11 18:24:17 +01:00
Daniel Holbach 1320c5d318 Merge pull request #293 from evrardjp/fix-make-helm-chart 
Update helm chart README using Make
 2021-01-11 16:39:23 +01:00
Jean-Philippe Evrard 0640683fbb Update helm chart README using Make 
Without this, it's possible that the helm chart documentation
contains the `image tag` version which might not be equal to
the version in the helm chart, as it's only an example.

This is a confusing, so instead we should use make to edit the
application version everywhere.

This fixes it by updating the Makefile to modify text of the
chart's README using a regex looking for something similar to
a version; then I used the updated makefile to edit the README,
which in turns requires a bump of the version of the chart
itself.
 2021-01-11 16:14:18 +01:00
Daniel Holbach ec1a931a39 Merge pull request #292 from evrardjp/update-helm-chart 
Update helm chart
 2021-01-11 15:18:50 +01:00
Jean-Philippe Evrard 36308cee91 Update helm chart 
Bumping the helm chart with minor version bump, due to minor
version bump of the kured appVersion.
 2021-01-11 14:57:42 +01:00
Daniel Holbach b733d00550 Merge pull request #280 from cnmcavoy/cnmcavoy/helm-updates 
Expose the service name and maxUnavailable for rolling updates in helm chart
 2021-01-11 14:53:53 +01:00
Daniel Holbach 56e2c12d38 Merge pull request #291 from evrardjp/fix-tagging 
Fix automated tagging
1.6.1 		2021-01-11 14:29:28 +01:00
Jean-Philippe Evrard 48e7ff28bf Fix automated tagging 
Without this patch, the name of the image is not templated, which
cause the action to fail.

This should fix it, by ensuring the image scan action uses a
templated value, instead of incorrectly relying on shell templating,
which doesn't run in the action.
 2021-01-11 14:23:14 +01:00
Daniel Holbach 14fcc7bf37 Merge pull request #289 from evrardjp/update-README-for-1.6.0 
Update README
1.6.0 		2021-01-11 11:51:20 +01:00
Daniel Holbach 5b4e5b8533 Merge pull request #288 from evrardjp/update-versions-testing 
Refresh kind cluster versions
 2021-01-11 11:39:54 +01:00
Jean-Philippe Evrard 0162288ecf Update README 
This will prepare the README for 1.6.0 release, showing the
planned version.
 2021-01-11 11:26:23 +01:00
Jean-Philippe Evrard 2e09425a45 Refresh kind cluster versions 
Without this patch, we are using outdated images in kind cluster
setup.

This should fix it, by removing 1.17 cluster (which is not tested
anymore), and updating 1.19 images.
 2021-01-11 11:16:09 +01:00