github/kured
1
0
Fork 0
mirror of https://github.com/kubereboot/kured.git synced 2026-05-06 00:17:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: log on unusual sentinel-command exit code (#806)

Browse Source 
Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de>
This commit is contained in:
Christian Kotzbauer
2023-08-02 19:04:52 +02:00
committed by GitHub
parent aa971697ff
commit 16dc5e30d9
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/kured/main.go
View File

@@ -315,7 +315,8 @@ func buildHostCommand(pid int, command []string) []string {
}
func rebootRequired(sentinelCommand []string) bool {
if err := newCommand(sentinelCommand[0], sentinelCommand[1:]...).Run(); err != nil {
cmd := newCommand(sentinelCommand[0], sentinelCommand[1:]...)
if err := cmd.Run(); err != nil {
switch err := err.(type) {
case *exec.ExitError:
// We assume a non-zero exit code means 'reboot not required', but of course
@@ -323,6 +324,9 @@ func rebootRequired(sentinelCommand []string) bool {
// went wrong during its execution. In that case, not entering a reboot loop
// is the right thing to do, and we are logging stdout/stderr of the command
// so it should be obvious what is wrong.
if cmd.ProcessState.ExitCode() != 1 {
log.Warnf("sentinel command ended with unexpected exit code: %v", cmd.ProcessState.ExitCode())
}
return false
default:
// Something was grossly misconfigured, such as the command path being wrong.