github/kubevela
1
0
Fork 0
mirror of https://github.com/kubevela/kubevela.git synced 2026-02-14 10:00:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

mark vela install as deprecated (#989)

Browse Source 
* mark `vela install` as deprecated

* refactor vela install to helm install

* refactor vela install to helm install

fix

* Update pkg/commands/system.go

Co-authored-by: Jianbo Sun <wonderflow.sun@gmail.com>

* Update pkg/commands/system.go

Co-authored-by: Jianbo Sun <wonderflow.sun@gmail.com>

* Update README.md

* Update CONTRIBUTING.md

Co-authored-by: Jianbo Sun <wonderflow.sun@gmail.com>

* Update _sidebar.md

* Update README.md

* revert

Co-authored-by: Jianbo Sun <wonderflow.sun@gmail.com>
This commit is contained in:
Kai
2021-02-03 16:14:58 +08:00
committed by GitHub
parent 2524a3e5fb
commit dafbbbb606
3 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@@ -74,7 +74,7 @@ make core-run
This command will run controller locally, it will use your local KubeConfig which means you need to have a k8s cluster
locally. If you don't have a one, we suggest that you could setup up a cluster with [kind](https://kind.sigs.k8s.io/).
When you're developing `vela-core`, make sure the controller installed by `vela install` is not running.
When you're developing `vela-core`, make sure the controller installed by helm chart is not running.
Otherwise, it will conflict with your local running controller.
You can check and uninstall it by using helm.

8
pkg/commands/dashboard.go
View File

@@ -221,11 +221,13 @@ func OpenBrowser(url string) error {
func CheckVelaRuntimeInstalledAndReady(ioStreams cmdutil.IOStreams, c client.Client) (bool, error) {
if !helm.IsHelmReleaseRunning(types.DefaultKubeVelaReleaseName, types.DefaultKubeVelaChartName, types.DefaultKubeVelaNS, ioStreams) {
ioStreams.Info(fmt.Sprintf("\n%s %s", emojiFail, "KubeVela runtime is not installed yet."))
ioStreams.Info(fmt.Sprintf("\n%s %s%s or %s",
ioStreams.Info(fmt.Sprintf("\n%s %s%s",
emojiLightBulb,
"Please use this command to install: ",
white.Sprint("vela install -w"),
white.Sprint("vela install --help")))
white.Sprint("helm repo add kubevela https://kubevelacharts.oss-cn-hangzhou.aliyuncs.com/core && "+
"helm repo update \n kubectl create namespace vela-system \n "+
"helm install -n vela-system kubevela kubevela/vela-core"),
))
return false, nil
}
return PrintTrackVelaRuntimeStatus(context.Background(), c, ioStreams, 5*time.Minute)

3
pkg/commands/system.go
View File

@@ -123,6 +123,7 @@ func NewInstallCommand(c types.Args, chartContent string, ioStreams cmdutil.IOSt
Annotations: map[string]string{
types.TagCommandType: types.TypeStart,
},
Deprecated: "vela install is DEPRECATED and we will remove it after Kubevela 1.0. Please use helm chart instead",
}
flag := cmd.Flags()
@@ -282,7 +283,7 @@ func GetOAMReleaseVersion(ns string) (string, error) {
return result.Chart.AppVersion(), nil
}
}
return "", errors.New("kubevela not found in your kubernetes cluster, try `vela install` to install")
return "", errors.New("kubevela chart not found in your kubernetes cluster, refer to 'https://kubevela.io/#/en/install' for installation")
}
// PrintTrackVelaRuntimeStatus prints status of installing vela-core runtime