fix ut

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

pkg/controller/core.oam.dev/v1alpha2/application/application_controller.go

@@ -375,8 +375,6 @@ func (r *Reconciler) handleFinalizers(ctx monitorContext.Context, app *v1beta1.A
 			if wfContext.EnableInMemoryContext {
 				wfContext.MemStore.DeleteInMemoryContext(app.Name)
 			}
-			workflow.StepStatusCache.Delete(fmt.Sprintf("%s-%s", app.Name, app.Namespace))
-			wfContext.CleanupMemoryStore(app.Name, app.Namespace)
 			return true, result, err
 		}
 	}

pkg/workflow/workflow.go

@@ -124,6 +124,8 @@ func (w *workflow) ExecuteSteps(ctx monitorContext.Context, appRev *oamcore.Appl
 			}
 		}
 		w.app.Status.Conditions = reservedConditions
+		StepStatusCache.Delete(fmt.Sprintf("%s-%s", w.app.Name, w.app.Namespace))
+		wfContext.CleanupMemoryStore(w.app.Name, w.app.Namespace)
 		return common.WorkflowStateInitializing, nil
 	}
 

pkg/workflow/workflow_test.go

@@ -142,7 +142,6 @@ var _ = Describe("Test Workflow", func() {
 				Phase: common.WorkflowStepPhaseSucceeded,
 			}},
 		})).Should(BeEquivalentTo(""))
-
 	})
 
 	It("Workflow test for failed after retries", func() {
@@ -237,7 +236,6 @@ var _ = Describe("Test Workflow", func() {
 				Phase: common.WorkflowStepPhaseSucceeded,
 			}},
 		})).Should(BeEquivalentTo(""))
-
 	})
 
 	It("Test get backoff time and clean", func() {
@@ -249,15 +247,8 @@ var _ = Describe("Test Workflow", func() {
 		})
 		ctx := monitorContext.NewTraceContext(context.Background(), "test-app")
 		wf := NewWorkflow(app, k8sClient, common.WorkflowModeDAG)
-		StepStatusCache.Store("app-default", 1)
 		_, err := wf.ExecuteSteps(ctx, revision, runners)
 		Expect(err).ToNot(HaveOccurred())
-		app.Status.Workflow.Steps = []common.WorkflowStepStatus{
-			{
-				ID:    "test-step-id",
-				Phase: common.WorkflowStepPhaseRunning,
-			},
-		}
 		_, err = wf.ExecuteSteps(ctx, revision, runners)
 		Expect(err).ToNot(HaveOccurred())
 		wfCtx, err := wfContext.LoadContext(k8sClient, app.Namespace, app.Name)