github/kubevela
1
0
Fork 0
mirror of https://github.com/kubevela/kubevela.git synced 2026-08-18 12:06:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

delete health scope when delete app

Browse Source
This commit is contained in:
天元
2021-03-11 15:34:38 +08:00
parent 66c111be6c
commit bdf239f1ae
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
references/common/application.go
+15 -1
View File
@@ -224,7 +224,21 @@ func (o *DeleteOptions) DeleteApp() (string, error) {
return "", fmt.Errorf("delete application err: %w", err)
}
// TODO(wonderflow): delete the default health scope here
for _, cmp := range app.Spec.Components {
healthScopeName, ok := cmp.Scopes[api.DefaultHealthScopeKey]
if ok {
var healthScope corev1alpha2.HealthScope
if err := o.Client.Get(ctx, client.ObjectKey{Namespace: o.Env.Namespace, Name: healthScopeName}, &healthScope); err != nil {
if apierrors.IsNotFound(err) {
continue
}
return "", fmt.Errorf("delete health scope %s err: %w", healthScopeName, err)
}
if err = o.Client.Delete(ctx, &healthScope); err != nil {
return "", fmt.Errorf("delete health scope %s err: %w", healthScopeName, err)
}
}
}
return fmt.Sprintf("app \"%s\" deleted from env \"%s\"", o.AppName, o.Env.Name), nil
}