github/kubevela
1
0
Fork 0
mirror of https://github.com/kubevela/kubevela.git synced 2026-08-18 03:56:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Vela not deleting the definition revisions after cleaning up the definitions (#6738)

Browse Source 
Signed-off-by: svc-gh-gokarna_gwre <svc-gh-gokarna@guidewire.com>
Co-authored-by: svc-gh-gokarna_gwre <svc-gh-gokarna@guidewire.com>
This commit is contained in:
Chaitanyareddy0702
2025-03-29 06:16:03 +08:00
committed by GitHub
co-authored by svc-gh-gokarna_gwre
parent dba2676cd9
commit bde50df3e5
1 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/controller/core.oam.dev/v1beta1/core/revison.go
+28
View File
@@ -27,6 +27,7 @@ import (
"github.com/pkg/errors"
apiequality "k8s.io/apimachinery/pkg/api/equality"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
@@ -164,21 +165,48 @@ func GatherRevisionInfo(def runtime.Object) (*v1beta1.DefinitionRevision, *commo
defRev.Spec.DefinitionType = common.ComponentType
defRev.Spec.ComponentDefinition = *copiedCompDef
LastRevision = copiedCompDef.Status.LatestRevision
defRev.ObjectMeta.OwnerReferences = []metav1.OwnerReference{{
APIVersion: copiedCompDef.APIVersion,
Kind: copiedCompDef.Kind,
Name: copiedCompDef.Name,
UID: copiedCompDef.UID,
}}
case *v1beta1.TraitDefinition:
copiedTraitDef := definition.DeepCopy()
defRev.Spec.DefinitionType = common.TraitType
defRev.Spec.TraitDefinition = *copiedTraitDef
LastRevision = copiedTraitDef.Status.LatestRevision
defRev.ObjectMeta.OwnerReferences = []metav1.OwnerReference{{
APIVersion: copiedTraitDef.APIVersion,
Kind: copiedTraitDef.Kind,
Name: copiedTraitDef.Name,
UID: copiedTraitDef.UID,
}}
case *v1beta1.PolicyDefinition:
defCopy := definition.DeepCopy()
defRev.Spec.DefinitionType = common.PolicyType
defRev.Spec.PolicyDefinition = *defCopy
LastRevision = defCopy.Status.LatestRevision
defRev.ObjectMeta.OwnerReferences = []metav1.OwnerReference{{
APIVersion: defCopy.APIVersion,
Kind: defCopy.Kind,
Name: defCopy.Name,
UID: defCopy.UID,
}}
case *v1beta1.WorkflowStepDefinition:
defCopy := definition.DeepCopy()
defRev.Spec.DefinitionType = common.WorkflowStepType
defRev.Spec.WorkflowStepDefinition = *defCopy
LastRevision = defCopy.Status.LatestRevision
defRev.ObjectMeta.OwnerReferences = []metav1.OwnerReference{{
APIVersion: defCopy.APIVersion,
Kind: defCopy.Kind,
Name: defCopy.Name,
UID: defCopy.UID,
}}
default:
return nil, nil, fmt.Errorf("unsupported type %v", definition)
}