github/kubevela
1
0
Fork 0
mirror of https://github.com/kubevela/kubevela.git synced 2026-08-27 16:17:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: controllerrevision can not be updated (#2764)

Browse Source
This commit is contained in:
Tianxin Dong
2021-11-22 10:58:23 +08:00
committed by GitHub
parent 4ad27e9bcd
commit 47a565d00d
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/workflow/recorder/recorder.go
+13 -2
View File
@@ -66,7 +66,9 @@ func (r *recorder) Save(version string, data []byte) Store {
if version == "" {
wfStatus := r.source.Status.Workflow
if wfStatus != nil {
version = strings.ReplaceAll(wfStatus.AppRevision, ":", "-")
if !strings.Contains(wfStatus.AppRevision, ":") {
version = wfStatus.AppRevision
}
}
}
@@ -89,7 +91,16 @@ func (r *recorder) Save(version string, data []byte) Store {
}
if err := r.cli.Create(context.Background(), rv); err != nil {
if kerrors.IsAlreadyExists(err) {
r.err = r.cli.Update(context.Background(), rv)
// ControllerRevision implements an immutable snapshot of state data
// Once a ControllerRevision has been successfully created, it can not be updated.
// So we need to delete the old one and create a new one.
r.err = r.cli.Delete(context.Background(), &apps.ControllerRevision{
ObjectMeta: metav1.ObjectMeta{
Name: rv.Name,
Namespace: rv.Namespace,
},
})
r.err = r.cli.Create(context.Background(), rv)
} else {
r.err = errors.WithMessagef(err, "save record %s/%s", rv.Namespace, rv.Name)
}