make sure we don't create more pods (#1452)

test/e2e-test/rollout_plan_test.go

@@ -272,10 +272,9 @@ var _ = Describe("Cloneset based rollout tests", func() {
 
 	AfterEach(func() {
 		By("Clean up resources after a test")
+		k8sClient.Delete(ctx, &app)
 		k8sClient.Delete(ctx, &appRollout)
 		verifyRolloutDeleted()
-		By("Delete the application")
-		k8sClient.Delete(ctx, &app)
 		By(fmt.Sprintf("Delete the entire namespaceName %s", ns.Name))
 		// delete the namespaceName with all its resources
 		Expect(k8sClient.Delete(ctx, &ns, client.PropagationPolicy(metav1.DeletePropagationBackground))).Should(BeNil())

test/e2e-test/testdata/rollout/cloneset/app-no-replica.yaml

@@ -14,4 +14,4 @@ spec:
           - stress-cpu=1
         image: stefanprodan/podinfo:4.0.3
         port: 8080
-        updateStrategyType: InPlaceIfPossible
+        updateStrategyType: InPlaceOnly

test/e2e-test/testdata/rollout/cloneset/app-source.yaml

@@ -14,5 +14,5 @@ spec:
           - stress-cpu=1
         image: stefanprodan/podinfo:4.0.3
         port: 8080
-        updateStrategyType: InPlaceIfPossible
+        updateStrategyType: InPlaceOnly
         replicas: 5

test/e2e-test/testdata/rollout/cloneset/app-target.yaml

@@ -14,5 +14,5 @@ spec:
           - stress-cpu=1
         image: stefanprodan/podinfo:5.0.2
         port: 8080
-        updateStrategyType: InPlaceIfPossible
+        updateStrategyType: InPlaceOnly
         replicas: 5