#patch

#hotfix

agent/go.mod

@@ -51,7 +51,7 @@ require (
 	github.com/beevik/etree v1.1.0 // indirect
 	github.com/chai2010/gettext-go v0.0.0-20160711120539-c6fed771bfd5 // indirect
 	github.com/chanced/dynamic v0.0.0-20211210164248-f8fadb1d735b // indirect
-	github.com/cilium/ebpf v0.9.0 // indirect
+	github.com/cilium/ebpf v0.8.1 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/evanphx/json-patch v5.6.0+incompatible // indirect
 	github.com/exponent-io/jsonpath v0.0.0-20210407135951-1de76d718b3f // indirect
@@ -89,7 +89,6 @@ require (
 	github.com/mattn/go-isatty v0.0.14 // indirect
 	github.com/mertyildiran/gqlparser/v2 v2.4.6 // indirect
 	github.com/mitchellh/go-wordwrap v1.0.1 // indirect
-	github.com/moby/moby v20.10.17+incompatible // indirect
 	github.com/moby/spdystream v0.2.0 // indirect
 	github.com/moby/term v0.0.0-20210619224110-3f7ff695adc6 // indirect
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
@@ -105,7 +104,6 @@ require (
 	github.com/santhosh-tekuri/jsonschema/v5 v5.0.0 // indirect
 	github.com/segmentio/kafka-go v0.4.27 // indirect
 	github.com/shirou/gopsutil v3.21.11+incompatible // indirect
-	github.com/sirupsen/logrus v1.8.1 // indirect
 	github.com/spf13/cobra v1.3.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/struCoder/pidusage v0.2.1 // indirect

agent/go.sum

@@ -128,8 +128,8 @@ github.com/chanced/openapi v0.0.8/go.mod h1:SxE2VMLPw+T7Vq8nwbVVhDF2PigvRF4n5Xyq
 github.com/chzyer/logex v1.1.10/go.mod h1:+Ywpsq7O8HXn0nuIou7OrIPyXbp3wmkHB+jjWRnGsAI=
 github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e/go.mod h1:nSuG5e5PlCu98SY8svDHJxuZscDgtXS6KTTbou5AhLI=
 github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMnBNeIyt5eFwwo7qiLfzFZmjNmxjkiQlU=
-github.com/cilium/ebpf v0.9.0 h1:ldiV+FscPCQ/p3mNEV4O02EPbUZJFsoEtHvIr9xLTvk=
-github.com/cilium/ebpf v0.9.0/go.mod h1:+OhNOIXx/Fnu1IE8bJz2dzOA+VSfyTfdNUVdlQnxUFY=
+github.com/cilium/ebpf v0.8.1 h1:bLSSEbBLqGPXxls55pGr5qWZaTqcmfDJHhou7t254ao=
+github.com/cilium/ebpf v0.8.1/go.mod h1:f5zLIM0FSNuAkSyLAN7X+Hy6yznlF1mNiWUMfxMtrgk=
 github.com/circonus-labs/circonus-gometrics v2.3.1+incompatible/go.mod h1:nmEj6Dob7S7YxXgwXpfOuvO54S+tGdZdw9fuRZt25Ag=
 github.com/circonus-labs/circonusllhist v0.1.3/go.mod h1:kMXHVDlOchFAehlya5ePtbp5jckzBHf4XRpQvBOLI+I=
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
@@ -517,8 +517,6 @@ github.com/mitchellh/mapstructure v0.0.0-20160808181253-ca63d7c062ee/go.mod h1:F
 github.com/mitchellh/mapstructure v1.1.2/go.mod h1:FVVH3fgwuzCH5S8UJGiWEs2h04kUh9fWfEaFds41c1Y=
 github.com/mitchellh/mapstructure v1.4.1/go.mod h1:bFUtVrKA4DC2yAKiSyO/QUcy7e+RRV2QTWOzhPopBRo=
 github.com/mitchellh/mapstructure v1.4.3/go.mod h1:bFUtVrKA4DC2yAKiSyO/QUcy7e+RRV2QTWOzhPopBRo=
-github.com/moby/moby v20.10.17+incompatible h1:TJJfyk2fLEgK+RzqVpFNkDkm0oEi+MLUfwt9lEYnp5g=
-github.com/moby/moby v20.10.17+incompatible/go.mod h1:fDXVQ6+S340veQPv35CzDahGBmHsiclFwfEygB/TWMc=
 github.com/moby/spdystream v0.2.0 h1:cjW1zVyyoiM0T7b6UoySUFqzXMoqRckQtXwGPiBhOM8=
 github.com/moby/spdystream v0.2.0/go.mod h1:f7i0iNDQJ059oMTcWxx8MA/zKFIuD/lY+0GqbN2Wy8c=
 github.com/moby/term v0.0.0-20210610120745-9d4ed1856297/go.mod h1:vgPCkQMyxTZ7IDy8SXRufE172gr8+K/JE/7hHFxHW3A=
@@ -631,8 +629,6 @@ github.com/shurcooL/sanitized_anchor_name v1.0.0/go.mod h1:1NzhyTcUVG4SuEtjjoZeV
 github.com/sirupsen/logrus v1.2.0/go.mod h1:LxeOpSwHxABJmUn/MG1IvRgCAasNZTLOkJPxbbu5VWo=
 github.com/sirupsen/logrus v1.4.2/go.mod h1:tLMulIdttU9McNUspp0xgXVQah82FyeX6MwdIuYE2rE=
 github.com/sirupsen/logrus v1.6.0/go.mod h1:7uNnSEd1DgxDLC74fIahvMZmmYsHGZGEOFrfsX/uA88=
-github.com/sirupsen/logrus v1.8.1 h1:dJKuHgqk1NNQlqoA6BTlM1Wf9DOH3NBjQyu0h9+AZZE=
-github.com/sirupsen/logrus v1.8.1/go.mod h1:yWOB1SBYBC5VeMP7gHvWumXLIWorT60ONWic61uBYv0=
 github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d/go.mod h1:OnSkiWE9lh6wB0YB77sQom3nweQdgAjqCqsofrRNTgc=
 github.com/smartystreets/goconvey v1.6.4/go.mod h1:syvi0/a8iFYH4r/RixwvyeAJjdLS9QV7WQ/tjFTllLA=
 github.com/soheilhy/cmux v0.1.4/go.mod h1:IM3LyeVVIOuxMH7sFAkER9+bJ4dT7Ms6E4xg4kGIyLM=
@@ -1253,9 +1249,8 @@ gopkg.in/yaml.v3 v3.0.0-20200615113413-eeeca48fe776/go.mod h1:K4uyk7z7BCEPqu6E+C
 gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b h1:h8qDotaEPuJATrMmW04NCwg7v22aHH28wwpauUhK9Oo=
 gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 gotest.tools/v3 v3.0.2/go.mod h1:3SzNCllyD9/Y+b5r9JIKQ474KzkZyqLqEfYqMsX94Bk=
+gotest.tools/v3 v3.0.3 h1:4AuOwCGf4lLR9u3YOe2awrHygurzhO/HeQ6laiA6Sx0=
 gotest.tools/v3 v3.0.3/go.mod h1:Z7Lb0S5l+klDB31fvDQX8ss/FlKDxtlFlw3Oa8Ymbl8=
-gotest.tools/v3 v3.3.0 h1:MfDY1b1/0xN1CyMlQDac0ziEy9zJQd9CXBRRDHw2jJo=
-gotest.tools/v3 v3.3.0/go.mod h1:Mcr9QNxkg0uMvy/YElmo4SpXgJKWgQvYrT7Kw5RzJ1A=
 honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
 honnef.co/go/tools v0.0.0-20190106161140-3f1c8253044a/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
 honnef.co/go/tools v0.0.0-20190418001031-e561f6794a2a/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=

agent/pkg/api/entry_streamer_socket_connector.go

@@ -22,7 +22,7 @@ func (e *DefaultEntryStreamerSocketConnector) SendEntry(socketId int, entry *tap
 	if params.EnableFullEntries {
 		message, _ = models.CreateFullEntryWebSocketMessage(entry)
 	} else {
-		protocol, ok := protocolsMap[entry.Protocol.ToString()]
+		protocol, ok := protocolsMap[entry.ProtocolId]
 		if !ok {
 			return fmt.Errorf("protocol not found, protocol: %v", protocol)
 		}

agent/pkg/api/main.go

@@ -126,7 +126,7 @@ func startReadingChannel(outputItems <-chan *tapApi.OutputChannelItem, extension
 		serviceMapGenerator.NewTCPEntry(mizuEntry.Source, mizuEntry.Destination, &item.Protocol)
 
 		oasGenerator := dependency.GetInstance(dependency.OasGeneratorDependency).(oas.OasGeneratorSink)
-		oasGenerator.HandleEntry(mizuEntry)
+		oasGenerator.HandleEntry(mizuEntry, &item.Protocol)
 	}
 }
 

agent/pkg/controllers/service_map_controller_test.go

@@ -36,13 +36,11 @@ var (
 )
 
 var ProtocolHttp = &tapApi.Protocol{
-	ProtocolSummary: tapApi.ProtocolSummary{
-		Name:         "http",
-		Version:      "1.1",
-		Abbreviation: "HTTP",
-	},
+	Name:            "http",
 	LongName:        "Hypertext Transfer Protocol -- HTTP/1.1",
+	Abbreviation:    "HTTP",
 	Macro:           "http",
+	Version:         "1.1",
 	BackgroundColor: "#205cf5",
 	ForegroundColor: "#ffffff",
 	FontSize:        12,

agent/pkg/entries/entries_provider.go

@@ -38,7 +38,7 @@ func (e *BasenineEntriesProvider) GetEntries(entriesRequest *models.EntriesReque
 			return nil, nil, err
 		}
 
-		protocol, ok := app.ProtocolsMap[entry.Protocol.ToString()]
+		protocol, ok := app.ProtocolsMap[entry.ProtocolId]
 		if !ok {
 			return nil, nil, fmt.Errorf("protocol not found, protocol: %v", protocol)
 		}
@@ -77,7 +77,7 @@ func (e *BasenineEntriesProvider) GetEntry(singleEntryRequest *models.SingleEntr
 		return nil, errors.New(string(bytes))
 	}
 
-	protocol, ok := app.ProtocolsMap[entry.Protocol.ToString()]
+	protocol, ok := app.ProtocolsMap[entry.ProtocolId]
 	if !ok {
 		return nil, fmt.Errorf("protocol not found, protocol: %v", protocol)
 	}

agent/pkg/oas/oas_generator.go

@@ -16,7 +16,7 @@ var (
 )
 
 type OasGeneratorSink interface {
-	HandleEntry(mizuEntry *api.Entry)
+	HandleEntry(mizuEntry *api.Entry, protocol *api.Protocol)
 }
 
 type OasGenerator interface {
@@ -58,12 +58,12 @@ func (g *defaultOasGenerator) IsStarted() bool {
 	return g.started
 }
 
-func (g *defaultOasGenerator) HandleEntry(mizuEntry *api.Entry) {
+func (g *defaultOasGenerator) HandleEntry(mizuEntry *api.Entry, protocol *api.Protocol) {
 	if !g.started {
 		return
 	}
 
-	if mizuEntry.Protocol.Name == "http" {
+	if protocol.Name == "http" {
 		dest := mizuEntry.Destination.Name
 		if dest == "" {
 			logger.Log.Debugf("OAS: Unresolved entry %d", mizuEntry.Id)
@@ -85,7 +85,7 @@ func (g *defaultOasGenerator) HandleEntry(mizuEntry *api.Entry) {
 
 		g.handleHARWithSource(entryWSource)
 	} else {
-		logger.Log.Debugf("OAS: Unsupported protocol in entry %d: %s", mizuEntry.Id, mizuEntry.Protocol.Name)
+		logger.Log.Debugf("OAS: Unsupported protocol in entry %d: %s", mizuEntry.Id, protocol.Name)
 	}
 }
 

agent/pkg/providers/stats_provider.go

@@ -1,9 +1,6 @@
 package providers
 
 import (
-	"crypto/md5"
-	"encoding/hex"
-	"fmt"
 	"reflect"
 	"strings"
 	"sync"
@@ -39,13 +36,13 @@ type SizeAndEntriesCount struct {
 
 type AccumulativeStatsCounter struct {
 	Name            string `json:"name"`
-	Color           string `json:"color"`
 	EntriesCount    int    `json:"entriesCount"`
 	VolumeSizeBytes int    `json:"volumeSizeBytes"`
 }
 
 type AccumulativeStatsProtocol struct {
 	AccumulativeStatsCounter
+	Color   string                      `json:"color"`
 	Methods []*AccumulativeStatsCounter `json:"methods"`
 }
 
@@ -55,7 +52,6 @@ type AccumulativeStatsProtocolTime struct {
 }
 
 type TrafficStatsResponse struct {
-	Protocols     []string                         `json:"protocols"`
 	PieStats      []*AccumulativeStatsProtocol     `json:"pie"`
 	TimelineStats []*AccumulativeStatsProtocolTime `json:"timeline"`
 }
@@ -82,36 +78,20 @@ func GetGeneralStats() *GeneralStats {
 
 func InitProtocolToColor(protocolMap map[string]*api.Protocol) {
 	for item, value := range protocolMap {
-		splitted := strings.SplitN(item, "/", 3)
-		protocolToColor[splitted[len(splitted)-1]] = value.BackgroundColor
+		protocolToColor[strings.Split(item, "/")[2]] = value.BackgroundColor
 	}
 }
 
 func GetTrafficStats() *TrafficStatsResponse {
 	bucketsStatsCopy := getBucketStatsCopy()
+	interval := calculateInterval(bucketsStatsCopy[0].BucketTime.Unix(), bucketsStatsCopy[len(bucketsStatsCopy)-1].BucketTime.Unix()) // in seconds
 
 	return &TrafficStatsResponse{
-		Protocols:     getAvailableProtocols(bucketsStatsCopy),
 		PieStats:      getAccumulativeStats(bucketsStatsCopy),
-		TimelineStats: getAccumulativeStatsTiming(bucketsStatsCopy),
+		TimelineStats: getAccumulativeStatsTiming(bucketsStatsCopy, interval),
 	}
 }
 
-func EntryAdded(size int, summery *api.BaseEntry) {
-	generalStats.EntriesCount++
-	generalStats.EntriesVolumeInGB += float64(size) / (1 << 30)
-
-	currentTimestamp := int(time.Now().Unix())
-
-	if reflect.Value.IsZero(reflect.ValueOf(generalStats.FirstEntryTimestamp)) {
-		generalStats.FirstEntryTimestamp = currentTimestamp
-	}
-
-	addToBucketStats(size, summery)
-
-	generalStats.LastEntryTimestamp = currentTimestamp
-}
-
 func calculateInterval(firstTimestamp int64, lastTimestamp int64) time.Duration {
 	validDurations := []time.Duration{
 		time.Minute,
@@ -160,17 +140,31 @@ func getAccumulativeStats(stats BucketStats) []*AccumulativeStatsProtocol {
 	return convertAccumulativeStatsDictToArray(methodsPerProtocolAggregated)
 }
 
-func getAccumulativeStatsTiming(stats BucketStats) []*AccumulativeStatsProtocolTime {
+func getAccumulativeStatsTiming(stats BucketStats, interval time.Duration) []*AccumulativeStatsProtocolTime {
 	if len(stats) == 0 {
 		return make([]*AccumulativeStatsProtocolTime, 0)
 	}
 
-	interval := calculateInterval(stats[0].BucketTime.Unix(), stats[len(stats)-1].BucketTime.Unix()) // in seconds
-	methodsPerProtocolPerTimeAggregated := getAggregatedResultTiming(stats, interval)
+	methodsPerProtocolPerTimeAggregated := getAggregatedResultTiming(interval, stats)
 
 	return convertAccumulativeStatsTimelineDictToArray(methodsPerProtocolPerTimeAggregated)
 }
 
+func EntryAdded(size int, summery *api.BaseEntry) {
+	generalStats.EntriesCount++
+	generalStats.EntriesVolumeInGB += float64(size) / (1 << 30)
+
+	currentTimestamp := int(time.Now().Unix())
+
+	if reflect.Value.IsZero(reflect.ValueOf(generalStats.FirstEntryTimestamp)) {
+		generalStats.FirstEntryTimestamp = currentTimestamp
+	}
+
+	addToBucketStats(size, summery)
+
+	generalStats.LastEntryTimestamp = currentTimestamp
+}
+
 func addToBucketStats(size int, summery *api.BaseEntry) {
 	entryTimeBucketRounded := getBucketFromTimeStamp(summery.Timestamp)
 
@@ -213,11 +207,11 @@ func convertAccumulativeStatsTimelineDictToArray(methodsPerProtocolPerTimeAggreg
 	finalResult := make([]*AccumulativeStatsProtocolTime, 0)
 	for timeKey, item := range methodsPerProtocolPerTimeAggregated {
 		protocolsData := make([]*AccumulativeStatsProtocol, 0)
-		for protocolName, value := range item {
+		for protocolName := range item {
 			entriesCount := 0
 			volumeSizeBytes := 0
 			methods := make([]*AccumulativeStatsCounter, 0)
-			for _, methodAccData := range value {
+			for _, methodAccData := range methodsPerProtocolPerTimeAggregated[timeKey][protocolName] {
 				entriesCount += methodAccData.EntriesCount
 				volumeSizeBytes += methodAccData.VolumeSizeBytes
 				methods = append(methods, methodAccData)
@@ -225,10 +219,10 @@ func convertAccumulativeStatsTimelineDictToArray(methodsPerProtocolPerTimeAggreg
 			protocolsData = append(protocolsData, &AccumulativeStatsProtocol{
 				AccumulativeStatsCounter: AccumulativeStatsCounter{
 					Name:            protocolName,
-					Color:           protocolToColor[protocolName],
 					EntriesCount:    entriesCount,
 					VolumeSizeBytes: volumeSizeBytes,
 				},
+				Color:   protocolToColor[protocolName],
 				Methods: methods,
 			})
 		}
@@ -254,10 +248,10 @@ func convertAccumulativeStatsDictToArray(methodsPerProtocolAggregated map[string
 		protocolsData = append(protocolsData, &AccumulativeStatsProtocol{
 			AccumulativeStatsCounter: AccumulativeStatsCounter{
 				Name:            protocolName,
-				Color:           protocolToColor[protocolName],
 				EntriesCount:    entriesCount,
 				VolumeSizeBytes: volumeSizeBytes,
 			},
+			Color:   protocolToColor[protocolName],
 			Methods: methods,
 		})
 	}
@@ -275,7 +269,7 @@ func getBucketStatsCopy() BucketStats {
 	return bucketStatsCopy
 }
 
-func getAggregatedResultTiming(stats BucketStats, interval time.Duration) map[time.Time]map[string]map[string]*AccumulativeStatsCounter {
+func getAggregatedResultTiming(interval time.Duration, stats BucketStats) map[time.Time]map[string]map[string]*AccumulativeStatsCounter {
 	methodsPerProtocolPerTimeAggregated := map[time.Time]map[string]map[string]*AccumulativeStatsCounter{}
 
 	bucketStatsIndex := len(stats) - 1
@@ -295,7 +289,6 @@ func getAggregatedResultTiming(stats BucketStats, interval time.Duration) map[ti
 				if _, ok := methodsPerProtocolPerTimeAggregated[resultBucketRoundedKey][protocolName][methodName]; !ok {
 					methodsPerProtocolPerTimeAggregated[resultBucketRoundedKey][protocolName][methodName] = &AccumulativeStatsCounter{
 						Name:            methodName,
-						Color:           getColorForMethod(protocolName, methodName),
 						EntriesCount:    0,
 						VolumeSizeBytes: 0,
 					}
@@ -310,9 +303,9 @@ func getAggregatedResultTiming(stats BucketStats, interval time.Duration) map[ti
 	return methodsPerProtocolPerTimeAggregated
 }
 
-func getAggregatedStats(stats BucketStats) map[string]map[string]*AccumulativeStatsCounter {
+func getAggregatedStats(bucketStatsCopy BucketStats) map[string]map[string]*AccumulativeStatsCounter {
 	methodsPerProtocolAggregated := make(map[string]map[string]*AccumulativeStatsCounter, 0)
-	for _, countersOfTimeFrame := range stats {
+	for _, countersOfTimeFrame := range bucketStatsCopy {
 		for protocolName, value := range countersOfTimeFrame.ProtocolStats {
 			for method, countersValue := range value.MethodsStats {
 				if _, found := methodsPerProtocolAggregated[protocolName]; !found {
@@ -321,7 +314,6 @@ func getAggregatedStats(stats BucketStats) map[string]map[string]*AccumulativeSt
 				if _, found := methodsPerProtocolAggregated[protocolName][method]; !found {
 					methodsPerProtocolAggregated[protocolName][method] = &AccumulativeStatsCounter{
 						Name:            method,
-						Color:           getColorForMethod(protocolName, method),
 						EntriesCount:    0,
 						VolumeSizeBytes: 0,
 					}
@@ -333,25 +325,3 @@ func getAggregatedStats(stats BucketStats) map[string]map[string]*AccumulativeSt
 	}
 	return methodsPerProtocolAggregated
 }
-
-func getColorForMethod(protocolName string, methodName string) string {
-	hash := md5.Sum([]byte(fmt.Sprintf("%v_%v", protocolName, methodName)))
-	input := hex.EncodeToString(hash[:])
-	return fmt.Sprintf("#%v", input[:6])
-}
-
-func getAvailableProtocols(stats BucketStats) []string {
-	protocols := map[string]bool{}
-	for _, countersOfTimeFrame := range stats {
-		for protocolName := range countersOfTimeFrame.ProtocolStats {
-			protocols[protocolName] = true
-		}
-	}
-
-	result := make([]string, 0)
-	for protocol := range protocols {
-		result = append(result, protocol)
-	}
-	result = append(result, "ALL")
-	return result
-}

agent/pkg/providers/stats_provider_internal_test.go

@@ -2,6 +2,7 @@ package providers
 
 import (
 	"fmt"
+	"reflect"
 	"testing"
 	"time"
 )
@@ -109,8 +110,8 @@ func TestGetAggregatedStatsAllTime(t *testing.T) {
 	}
 	actual := getAggregatedStats(bucketStatsForTest)
 
-	if len(actual) != len(expected) {
-		t.Errorf("unexpected result - expected: %v, actual: %v", len(expected), len(actual))
+	if !reflect.DeepEqual(actual, expected) {
+		t.Errorf("unexpected result - expected: %v, actual: %v", 3, len(actual))
 	}
 }
 
@@ -194,10 +195,10 @@ func TestGetAggregatedStatsFromSpecificTime(t *testing.T) {
 			},
 		},
 	}
-	actual := getAggregatedResultTiming(bucketStatsForTest, time.Minute*5)
+	actual := getAggregatedResultTiming(time.Minute*5, bucketStatsForTest)
 
-	if len(actual) != len(expected) {
-		t.Errorf("unexpected result - expected: %v, actual: %v", len(expected), len(actual))
+	if !reflect.DeepEqual(actual, expected) {
+		t.Errorf("unexpected result - expected: %v, actual: %v", 3, len(actual))
 	}
 }
 
@@ -290,9 +291,9 @@ func TestGetAggregatedStatsFromSpecificTimeMultipleBuckets(t *testing.T) {
 			},
 		},
 	}
-	actual := getAggregatedResultTiming(bucketStatsForTest, time.Minute)
+	actual := getAggregatedResultTiming(time.Minute, bucketStatsForTest)
 
-	if len(actual) != len(expected) {
-		t.Errorf("unexpected result - expected: %v, actual: %v", len(expected), len(actual))
+	if !reflect.DeepEqual(actual, expected) {
+		t.Errorf("unexpected result - expected: %v, actual: %v", 3, len(actual))
 	}
 }

agent/pkg/providers/stats_provider_test.go

@@ -26,7 +26,7 @@ func TestEntryAddedCount(t *testing.T) {
 
 	entryBucketKey := time.Date(2021, 1, 1, 10, 0, 0, 0, time.UTC)
 	valueLessThanBucketThreshold := time.Second * 130
-	mockSummery := &api.BaseEntry{Protocol: api.Protocol{ProtocolSummary: api.ProtocolSummary{Name: "mock"}}, Method: "mock-method", Timestamp: entryBucketKey.Add(valueLessThanBucketThreshold).UnixNano()}
+	mockSummery := &api.BaseEntry{Protocol: api.Protocol{Name: "mock"}, Method: "mock-method", Timestamp: entryBucketKey.Add(valueLessThanBucketThreshold).UnixNano()}
 	for _, entriesCount := range tests {
 		t.Run(fmt.Sprintf("%d", entriesCount), func(t *testing.T) {
 			for i := 0; i < entriesCount; i++ {
@@ -61,7 +61,7 @@ func TestEntryAddedVolume(t *testing.T) {
 	var expectedEntriesCount int
 	var expectedVolumeInGB float64
 
-	mockSummery := &api.BaseEntry{Protocol: api.Protocol{ProtocolSummary: api.ProtocolSummary{Name: "mock"}}, Method: "mock-method", Timestamp: time.Date(2021, 1, 1, 10, 0, 0, 0, time.UTC).UnixNano()}
+	mockSummery := &api.BaseEntry{Protocol: api.Protocol{Name: "mock"}, Method: "mock-method", Timestamp: time.Date(2021, 1, 1, 10, 0, 0, 0, time.UTC).UnixNano()}
 
 	for _, data := range tests {
 		t.Run(fmt.Sprintf("%d", len(data)), func(t *testing.T) {

agent/pkg/servicemap/servicemap_test.go

@@ -50,13 +50,11 @@ var (
 		IP:   fmt.Sprintf("%s.%s", Ip, UnresolvedNodeName),
 	}
 	ProtocolHttp = &tapApi.Protocol{
-		ProtocolSummary: tapApi.ProtocolSummary{
-			Name:         "http",
-			Version:      "1.1",
-			Abbreviation: "HTTP",
-		},
+		Name:            "http",
 		LongName:        "Hypertext Transfer Protocol -- HTTP/1.1",
+		Abbreviation:    "HTTP",
 		Macro:           "http",
+		Version:         "1.1",
 		BackgroundColor: "#205cf5",
 		ForegroundColor: "#ffffff",
 		FontSize:        12,
@@ -65,13 +63,11 @@ var (
 		Priority:        0,
 	}
 	ProtocolRedis = &tapApi.Protocol{
-		ProtocolSummary: tapApi.ProtocolSummary{
-			Name:         "redis",
-			Version:      "3.x",
-			Abbreviation: "REDIS",
-		},
+		Name:            "redis",
 		LongName:        "Redis Serialization Protocol",
+		Abbreviation:    "REDIS",
 		Macro:           "redis",
+		Version:         "3.x",
 		BackgroundColor: "#a41e11",
 		ForegroundColor: "#ffffff",
 		FontSize:        11,

tap/api/api.go

@@ -2,7 +2,6 @@ package api
 
 import (
 	"bufio"
-	"fmt"
 	"net"
 	"sync"
 	"time"
@@ -15,20 +14,12 @@ const UnknownNamespace = ""
 var UnknownIp = net.IP{0, 0, 0, 0}
 var UnknownPort uint16 = 0
 
-type ProtocolSummary struct {
-	Name         string `json:"name"`
-	Version      string `json:"version"`
-	Abbreviation string `json:"abbr"`
-}
-
-func (protocol *ProtocolSummary) ToString() string {
-	return fmt.Sprintf("%s?%s?%s", protocol.Name, protocol.Version, protocol.Abbreviation)
-}
-
 type Protocol struct {
-	ProtocolSummary
+	Name            string   `json:"name"`
 	LongName        string   `json:"longName"`
+	Abbreviation    string   `json:"abbr"`
 	Macro           string   `json:"macro"`
+	Version         string   `json:"version"`
 	BackgroundColor string   `json:"backgroundColor"`
 	ForegroundColor string   `json:"foregroundColor"`
 	FontSize        int8     `json:"fontSize"`
@@ -160,7 +151,7 @@ func (e *Emitting) Emit(item *OutputChannelItem) {
 
 type Entry struct {
 	Id           string                 `json:"id"`
-	Protocol     ProtocolSummary        `json:"protocol"`
+	ProtocolId   string                 `json:"protocol"`
 	Capture      Capture                `json:"capture"`
 	Source       *TCP                   `json:"src"`
 	Destination  *TCP                   `json:"dst"`

tap/extensions/amqp/Makefile

@@ -13,4 +13,4 @@ test-pull-bin:
 
 test-pull-expect:
 	@mkdir -p expect
-	@[ "${skipexpect}" ] && echo "Skipping downloading expected JSONs" || gsutil  -o 'GSUtil:parallel_process_count=5' -o 'GSUtil:parallel_thread_count=5'  -m cp -r gs://static.up9.io/mizu/test-pcap/expect15/amqp/\* expect
+	@[ "${skipexpect}" ] && echo "Skipping downloading expected JSONs" || gsutil  -o 'GSUtil:parallel_process_count=5' -o 'GSUtil:parallel_thread_count=5'  -m cp -r gs://static.up9.io/mizu/test-pcap/expect14/amqp/\* expect

tap/extensions/amqp/main.go

@@ -13,13 +13,11 @@ import (
 )
 
 var protocol = api.Protocol{
-	ProtocolSummary: api.ProtocolSummary{
-		Name:         "amqp",
-		Version:      "0-9-1",
-		Abbreviation: "AMQP",
-	},
+	Name:            "amqp",
 	LongName:        "Advanced Message Queuing Protocol 0-9-1",
+	Abbreviation:    "AMQP",
 	Macro:           "amqp",
+	Version:         "0-9-1",
 	BackgroundColor: "#ff6600",
 	ForegroundColor: "#ffffff",
 	FontSize:        12,
@@ -29,7 +27,7 @@ var protocol = api.Protocol{
 }
 
 var protocolsMap = map[string]*api.Protocol{
-	protocol.ToString(): &protocol,
+	fmt.Sprintf("%s/%s/%s", protocol.Name, protocol.Version, protocol.Abbreviation): &protocol,
 }
 
 type dissecting string
@@ -224,8 +222,8 @@ func (d dissecting) Analyze(item *api.OutputChannelItem, resolvedSource string,
 
 	reqDetails["method"] = request["method"]
 	return &api.Entry{
-		Protocol: protocol.ProtocolSummary,
-		Capture:  item.Capture,
+		ProtocolId: fmt.Sprintf("%s/%s/%s", protocol.Name, protocol.Version, protocol.Abbreviation),
+		Capture:    item.Capture,
 		Source: &api.TCP{
 			Name: resolvedSource,
 			IP:   item.ConnectionInfo.ClientIP,
@@ -287,7 +285,7 @@ func (d dissecting) Summarize(entry *api.Entry) *api.BaseEntry {
 
 	return &api.BaseEntry{
 		Id:           entry.Id,
-		Protocol:     *protocolsMap[entry.Protocol.ToString()],
+		Protocol:     *protocolsMap[entry.ProtocolId],
 		Capture:      entry.Capture,
 		Summary:      summary,
 		SummaryQuery: summaryQuery,
@@ -331,7 +329,7 @@ func (d dissecting) Represent(request map[string]interface{}, response map[strin
 
 func (d dissecting) Macros() map[string]string {
 	return map[string]string{
-		`amqp`: fmt.Sprintf(`protocol.name == "%s"`, protocol.Name),
+		`amqp`: fmt.Sprintf(`protocol == "%s/%s/%s"`, protocol.Name, protocol.Version, protocol.Abbreviation),
 	}
 }
 

tap/extensions/amqp/main_test.go

@@ -44,7 +44,7 @@ func TestRegister(t *testing.T) {
 
 func TestMacros(t *testing.T) {
 	expectedMacros := map[string]string{
-		"amqp": `protocol.name == "amqp"`,
+		"amqp": `protocol == "amqp/0-9-1/AMQP"`,
 	}
 	dissector := NewDissector()
 	macros := dissector.Macros()

tap/extensions/http/Makefile

@@ -13,4 +13,4 @@ test-pull-bin:
 
 test-pull-expect:
 	@mkdir -p expect
-	@[ "${skipexpect}" ] && echo "Skipping downloading expected JSONs" || gsutil  -o 'GSUtil:parallel_process_count=5' -o 'GSUtil:parallel_thread_count=5'  -m cp -r gs://static.up9.io/mizu/test-pcap/expect15/http/\* expect
+	@[ "${skipexpect}" ] && echo "Skipping downloading expected JSONs" || gsutil  -o 'GSUtil:parallel_process_count=5' -o 'GSUtil:parallel_thread_count=5'  -m cp -r gs://static.up9.io/mizu/test-pcap/expect14/http/\* expect

tap/extensions/http/main.go

@@ -15,13 +15,11 @@ import (
 )
 
 var http10protocol = api.Protocol{
-	ProtocolSummary: api.ProtocolSummary{
-		Name:         "http",
-		Version:      "1.0",
-		Abbreviation: "HTTP",
-	},
+	Name:            "http",
 	LongName:        "Hypertext Transfer Protocol -- HTTP/1.0",
+	Abbreviation:    "HTTP",
 	Macro:           "http",
+	Version:         "1.0",
 	BackgroundColor: "#205cf5",
 	ForegroundColor: "#ffffff",
 	FontSize:        12,
@@ -31,13 +29,11 @@ var http10protocol = api.Protocol{
 }
 
 var http11protocol = api.Protocol{
-	ProtocolSummary: api.ProtocolSummary{
-		Name:         "http",
-		Version:      "1.1",
-		Abbreviation: "HTTP",
-	},
+	Name:            "http",
 	LongName:        "Hypertext Transfer Protocol -- HTTP/1.1",
+	Abbreviation:    "HTTP",
 	Macro:           "http",
+	Version:         "1.1",
 	BackgroundColor: "#205cf5",
 	ForegroundColor: "#ffffff",
 	FontSize:        12,
@@ -47,13 +43,11 @@ var http11protocol = api.Protocol{
 }
 
 var http2Protocol = api.Protocol{
-	ProtocolSummary: api.ProtocolSummary{
-		Name:         "http",
-		Version:      "2.0",
-		Abbreviation: "HTTP/2",
-	},
+	Name:            "http",
 	LongName:        "Hypertext Transfer Protocol Version 2 (HTTP/2)",
+	Abbreviation:    "HTTP/2",
 	Macro:           "http2",
+	Version:         "2.0",
 	BackgroundColor: "#244c5a",
 	ForegroundColor: "#ffffff",
 	FontSize:        11,
@@ -63,13 +57,11 @@ var http2Protocol = api.Protocol{
 }
 
 var grpcProtocol = api.Protocol{
-	ProtocolSummary: api.ProtocolSummary{
-		Name:         "http",
-		Version:      "2.0",
-		Abbreviation: "gRPC",
-	},
+	Name:            "http",
 	LongName:        "Hypertext Transfer Protocol Version 2 (HTTP/2) [ gRPC over HTTP/2 ]",
+	Abbreviation:    "gRPC",
 	Macro:           "grpc",
+	Version:         "2.0",
 	BackgroundColor: "#244c5a",
 	ForegroundColor: "#ffffff",
 	FontSize:        11,
@@ -79,13 +71,11 @@ var grpcProtocol = api.Protocol{
 }
 
 var graphQL1Protocol = api.Protocol{
-	ProtocolSummary: api.ProtocolSummary{
-		Name:         "http",
-		Version:      "1.1",
-		Abbreviation: "GQL",
-	},
+	Name:            "http",
 	LongName:        "Hypertext Transfer Protocol -- HTTP/1.1 [ GraphQL over HTTP/1.1 ]",
+	Abbreviation:    "GQL",
 	Macro:           "gql",
+	Version:         "1.1",
 	BackgroundColor: "#e10098",
 	ForegroundColor: "#ffffff",
 	FontSize:        12,
@@ -95,13 +85,11 @@ var graphQL1Protocol = api.Protocol{
 }
 
 var graphQL2Protocol = api.Protocol{
-	ProtocolSummary: api.ProtocolSummary{
-		Name:         "http",
-		Version:      "2.0",
-		Abbreviation: "GQL",
-	},
+	Name:            "http",
 	LongName:        "Hypertext Transfer Protocol Version 2 (HTTP/2) [ GraphQL over HTTP/2 ]",
+	Abbreviation:    "GQL",
 	Macro:           "gql",
+	Version:         "2.0",
 	BackgroundColor: "#e10098",
 	ForegroundColor: "#ffffff",
 	FontSize:        12,
@@ -111,12 +99,12 @@ var graphQL2Protocol = api.Protocol{
 }
 
 var protocolsMap = map[string]*api.Protocol{
-	http10protocol.ToString():   &http10protocol,
-	http11protocol.ToString():   &http11protocol,
-	http2Protocol.ToString():    &http2Protocol,
-	grpcProtocol.ToString():     &grpcProtocol,
-	graphQL1Protocol.ToString(): &graphQL1Protocol,
-	graphQL2Protocol.ToString(): &graphQL2Protocol,
+	fmt.Sprintf("%s/%s/%s", http10protocol.Name, http10protocol.Version, http10protocol.Abbreviation):       &http10protocol,
+	fmt.Sprintf("%s/%s/%s", http11protocol.Name, http11protocol.Version, http11protocol.Abbreviation):       &http11protocol,
+	fmt.Sprintf("%s/%s/%s", http2Protocol.Name, http2Protocol.Version, http2Protocol.Abbreviation):          &http2Protocol,
+	fmt.Sprintf("%s/%s/%s", grpcProtocol.Name, grpcProtocol.Version, grpcProtocol.Abbreviation):             &grpcProtocol,
+	fmt.Sprintf("%s/%s/%s", graphQL1Protocol.Name, graphQL1Protocol.Version, graphQL1Protocol.Abbreviation): &graphQL1Protocol,
+	fmt.Sprintf("%s/%s/%s", graphQL2Protocol.Name, graphQL2Protocol.Version, graphQL2Protocol.Abbreviation): &graphQL2Protocol,
 }
 
 const (
@@ -306,8 +294,8 @@ func (d dissecting) Analyze(item *api.OutputChannelItem, resolvedSource string,
 	}
 
 	return &api.Entry{
-		Protocol: item.Protocol.ProtocolSummary,
-		Capture:  item.Capture,
+		ProtocolId: fmt.Sprintf("%s/%s/%s", item.Protocol.Name, item.Protocol.Version, item.Protocol.Abbreviation),
+		Capture:    item.Capture,
 		Source: &api.TCP{
 			Name: resolvedSource,
 			IP:   item.ConnectionInfo.ClientIP,
@@ -340,7 +328,7 @@ func (d dissecting) Summarize(entry *api.Entry) *api.BaseEntry {
 
 	return &api.BaseEntry{
 		Id:           entry.Id,
-		Protocol:     *protocolsMap[entry.Protocol.ToString()],
+		Protocol:     *protocolsMap[entry.ProtocolId],
 		Capture:      entry.Capture,
 		Summary:      summary,
 		SummaryQuery: summaryQuery,
@@ -527,10 +515,10 @@ func (d dissecting) Represent(request map[string]interface{}, response map[strin
 
 func (d dissecting) Macros() map[string]string {
 	return map[string]string{
-		`http`:  fmt.Sprintf(`protocol.abbr == "%s"`, http11protocol.Abbreviation),
-		`http2`: fmt.Sprintf(`protocol.abbr == "%s"`, http2Protocol.Abbreviation),
-		`grpc`:  fmt.Sprintf(`protocol.abbr == "%s"`, grpcProtocol.Abbreviation),
-		`gql`:   fmt.Sprintf(`protocol.abbr == "%s"`, graphQL1Protocol.Abbreviation),
+		`http`:  fmt.Sprintf(`protocol == "%s/%s/%s" or protocol == "%s/%s/%s"`, http10protocol.Name, http10protocol.Version, http10protocol.Abbreviation, http11protocol.Name, http11protocol.Version, http11protocol.Abbreviation),
+		`http2`: fmt.Sprintf(`protocol == "%s/%s/%s"`, http2Protocol.Name, http2Protocol.Version, http2Protocol.Abbreviation),
+		`grpc`:  fmt.Sprintf(`protocol == "%s/%s/%s"`, grpcProtocol.Name, grpcProtocol.Version, grpcProtocol.Abbreviation),
+		`gql`:   fmt.Sprintf(`protocol == "%s/%s/%s" or protocol == "%s/%s/%s"`, graphQL1Protocol.Name, graphQL1Protocol.Version, graphQL1Protocol.Abbreviation, graphQL2Protocol.Name, graphQL2Protocol.Version, graphQL2Protocol.Abbreviation),
 	}
 }
 

tap/extensions/http/main_test.go

@@ -44,10 +44,10 @@ func TestRegister(t *testing.T) {
 
 func TestMacros(t *testing.T) {
 	expectedMacros := map[string]string{
-		"http":  `protocol.abbr == "HTTP"`,
-		"http2": `protocol.abbr == "HTTP/2"`,
-		"grpc":  `protocol.abbr == "gRPC"`,
-		"gql":   `protocol.abbr == "GQL"`,
+		"http":  `protocol == "http/1.0/HTTP" or protocol == "http/1.1/HTTP"`,
+		"http2": `protocol == "http/2.0/HTTP/2"`,
+		"grpc":  `protocol == "http/2.0/gRPC"`,
+		"gql":   `protocol == "http/1.1/GQL" or protocol == "http/2.0/GQL"`,
 	}
 	dissector := NewDissector()
 	macros := dissector.Macros()

tap/extensions/kafka/Makefile

@@ -13,4 +13,4 @@ test-pull-bin:
 
 test-pull-expect:
 	@mkdir -p expect
-	@[ "${skipexpect}" ] && echo "Skipping downloading expected JSONs" || gsutil  -o 'GSUtil:parallel_process_count=5' -o 'GSUtil:parallel_thread_count=5'  -m cp -r gs://static.up9.io/mizu/test-pcap/expect15/kafka/\* expect
+	@[ "${skipexpect}" ] && echo "Skipping downloading expected JSONs" || gsutil  -o 'GSUtil:parallel_process_count=5' -o 'GSUtil:parallel_thread_count=5'  -m cp -r gs://static.up9.io/mizu/test-pcap/expect14/kafka/\* expect

tap/extensions/kafka/main.go

@@ -11,13 +11,11 @@ import (
 )
 
 var _protocol = api.Protocol{
-	ProtocolSummary: api.ProtocolSummary{
-		Name:         "kafka",
-		Version:      "12",
-		Abbreviation: "KAFKA",
-	},
+	Name:            "kafka",
 	LongName:        "Apache Kafka Protocol",
+	Abbreviation:    "KAFKA",
 	Macro:           "kafka",
+	Version:         "12",
 	BackgroundColor: "#000000",
 	ForegroundColor: "#ffffff",
 	FontSize:        11,
@@ -27,7 +25,7 @@ var _protocol = api.Protocol{
 }
 
 var protocolsMap = map[string]*api.Protocol{
-	_protocol.ToString(): &_protocol,
+	fmt.Sprintf("%s/%s/%s", _protocol.Name, _protocol.Version, _protocol.Abbreviation): &_protocol,
 }
 
 type dissecting string
@@ -72,8 +70,8 @@ func (d dissecting) Analyze(item *api.OutputChannelItem, resolvedSource string,
 		elapsedTime = 0
 	}
 	return &api.Entry{
-		Protocol: _protocol.ProtocolSummary,
-		Capture:  item.Capture,
+		ProtocolId: fmt.Sprintf("%s/%s/%s", _protocol.Name, _protocol.Version, _protocol.Abbreviation),
+		Capture:    item.Capture,
 		Source: &api.TCP{
 			Name: resolvedSource,
 			IP:   item.ConnectionInfo.ClientIP,
@@ -197,7 +195,7 @@ func (d dissecting) Summarize(entry *api.Entry) *api.BaseEntry {
 
 	return &api.BaseEntry{
 		Id:           entry.Id,
-		Protocol:     *protocolsMap[entry.Protocol.ToString()],
+		Protocol:     *protocolsMap[entry.ProtocolId],
 		Capture:      entry.Capture,
 		Summary:      summary,
 		SummaryQuery: summaryQuery,
@@ -252,7 +250,7 @@ func (d dissecting) Represent(request map[string]interface{}, response map[strin
 
 func (d dissecting) Macros() map[string]string {
 	return map[string]string{
-		`kafka`: fmt.Sprintf(`protocol.name == "%s"`, _protocol.Name),
+		`kafka`: fmt.Sprintf(`protocol == "%s/%s/%s"`, _protocol.Name, _protocol.Version, _protocol.Abbreviation),
 	}
 }
 

tap/extensions/kafka/main_test.go

@@ -44,7 +44,7 @@ func TestRegister(t *testing.T) {
 
 func TestMacros(t *testing.T) {
 	expectedMacros := map[string]string{
-		"kafka": `protocol.name == "kafka"`,
+		"kafka": `protocol == "kafka/12/KAFKA"`,
 	}
 	dissector := NewDissector()
 	macros := dissector.Macros()

tap/extensions/redis/Makefile

@@ -13,4 +13,4 @@ test-pull-bin:
 
 test-pull-expect:
 	@mkdir -p expect
-	@[ "${skipexpect}" ] && echo "Skipping downloading expected JSONs" || gsutil  -o 'GSUtil:parallel_process_count=5' -o 'GSUtil:parallel_thread_count=5'  -m cp -r gs://static.up9.io/mizu/test-pcap/expect15/redis/\* expect
+	@[ "${skipexpect}" ] && echo "Skipping downloading expected JSONs" || gsutil  -o 'GSUtil:parallel_process_count=5' -o 'GSUtil:parallel_thread_count=5'  -m cp -r gs://static.up9.io/mizu/test-pcap/expect14/redis/\* expect

tap/extensions/redis/main.go

@@ -11,13 +11,11 @@ import (
 )
 
 var protocol = api.Protocol{
-	ProtocolSummary: api.ProtocolSummary{
-		Name:         "redis",
-		Version:      "3.x",
-		Abbreviation: "REDIS",
-	},
+	Name:            "redis",
 	LongName:        "Redis Serialization Protocol",
+	Abbreviation:    "REDIS",
 	Macro:           "redis",
+	Version:         "3.x",
 	BackgroundColor: "#a41e11",
 	ForegroundColor: "#ffffff",
 	FontSize:        11,
@@ -27,7 +25,7 @@ var protocol = api.Protocol{
 }
 
 var protocolsMap = map[string]*api.Protocol{
-	protocol.ToString(): &protocol,
+	fmt.Sprintf("%s/%s/%s", protocol.Name, protocol.Version, protocol.Abbreviation): &protocol,
 }
 
 type dissecting string
@@ -80,8 +78,8 @@ func (d dissecting) Analyze(item *api.OutputChannelItem, resolvedSource string,
 		elapsedTime = 0
 	}
 	return &api.Entry{
-		Protocol: protocol.ProtocolSummary,
-		Capture:  item.Capture,
+		ProtocolId: fmt.Sprintf("%s/%s/%s", protocol.Name, protocol.Version, protocol.Abbreviation),
+		Capture:    item.Capture,
 		Source: &api.TCP{
 			Name: resolvedSource,
 			IP:   item.ConnectionInfo.ClientIP,
@@ -125,7 +123,7 @@ func (d dissecting) Summarize(entry *api.Entry) *api.BaseEntry {
 
 	return &api.BaseEntry{
 		Id:           entry.Id,
-		Protocol:     *protocolsMap[entry.Protocol.ToString()],
+		Protocol:     *protocolsMap[entry.ProtocolId],
 		Capture:      entry.Capture,
 		Summary:      summary,
 		SummaryQuery: summaryQuery,
@@ -153,7 +151,7 @@ func (d dissecting) Represent(request map[string]interface{}, response map[strin
 
 func (d dissecting) Macros() map[string]string {
 	return map[string]string{
-		`redis`: fmt.Sprintf(`protocol.name == "%s"`, protocol.Name),
+		`redis`: fmt.Sprintf(`protocol == "%s/%s/%s"`, protocol.Name, protocol.Version, protocol.Abbreviation),
 	}
 }
 

tap/extensions/redis/main_test.go

@@ -45,7 +45,7 @@ func TestRegister(t *testing.T) {
 
 func TestMacros(t *testing.T) {
 	expectedMacros := map[string]string{
-		"redis": `protocol.name == "redis"`,
+		"redis": `protocol == "redis/3.x/REDIS"`,
 	}
 	dissector := NewDissector()
 	macros := dissector.Macros()

tap/go.mod

@@ -4,12 +4,11 @@ go 1.17
 
 require (
 	github.com/Masterminds/semver v1.5.0
-	github.com/cilium/ebpf v0.9.0
+	github.com/cilium/ebpf v0.8.1
 	github.com/go-errors/errors v1.4.2
 	github.com/google/gopacket v1.1.19
 	github.com/hashicorp/golang-lru v0.5.4
 	github.com/knightsc/gapstone v0.0.0-20191231144527-6fa5afaf11a9
-	github.com/moby/moby v20.10.17+incompatible
 	github.com/shirou/gopsutil v3.21.11+incompatible
 	github.com/struCoder/pidusage v0.2.1
 	github.com/up9inc/mizu/logger v0.0.0
@@ -29,7 +28,6 @@ require (
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
 	github.com/op/go-logging v0.0.0-20160315200505-970db520ece7 // indirect
-	github.com/sirupsen/logrus v1.8.1 // indirect
 	github.com/tklauser/go-sysconf v0.3.10 // indirect
 	github.com/tklauser/numcpus v0.4.0 // indirect
 	github.com/yusufpapurcu/wmi v1.2.2 // indirect
@@ -38,7 +36,6 @@ require (
 	golang.org/x/text v0.3.7 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
-	gotest.tools/v3 v3.3.0 // indirect
 	k8s.io/apimachinery v0.23.3 // indirect
 	k8s.io/klog/v2 v2.40.1 // indirect
 	k8s.io/utils v0.0.0-20220127004650-9b3446523e65 // indirect

tap/go.sum

@@ -7,8 +7,8 @@ github.com/PuerkitoBio/purell v1.1.1/go.mod h1:c11w/QuzBsJSee3cPx9rAFu61PvFxuPbt
 github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578/go.mod h1:uGdkoq3SwY9Y+13GIhn11/XLaGBb4BfwItxLd5jeuXE=
 github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
 github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
-github.com/cilium/ebpf v0.9.0 h1:ldiV+FscPCQ/p3mNEV4O02EPbUZJFsoEtHvIr9xLTvk=
-github.com/cilium/ebpf v0.9.0/go.mod h1:+OhNOIXx/Fnu1IE8bJz2dzOA+VSfyTfdNUVdlQnxUFY=
+github.com/cilium/ebpf v0.8.1 h1:bLSSEbBLqGPXxls55pGr5qWZaTqcmfDJHhou7t254ao=
+github.com/cilium/ebpf v0.8.1/go.mod h1:f5zLIM0FSNuAkSyLAN7X+Hy6yznlF1mNiWUMfxMtrgk=
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
@@ -94,8 +94,6 @@ github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
 github.com/mailru/easyjson v0.0.0-20190614124828-94de47d64c63/go.mod h1:C1wdFJiN94OJF2b5HbByQZoLdCWB1Yqtg26g4irojpc=
 github.com/mailru/easyjson v0.0.0-20190626092158-b2ccc519800e/go.mod h1:C1wdFJiN94OJF2b5HbByQZoLdCWB1Yqtg26g4irojpc=
 github.com/mitchellh/mapstructure v1.1.2/go.mod h1:FVVH3fgwuzCH5S8UJGiWEs2h04kUh9fWfEaFds41c1Y=
-github.com/moby/moby v20.10.17+incompatible h1:TJJfyk2fLEgK+RzqVpFNkDkm0oEi+MLUfwt9lEYnp5g=
-github.com/moby/moby v20.10.17+incompatible/go.mod h1:fDXVQ6+S340veQPv35CzDahGBmHsiclFwfEygB/TWMc=
 github.com/moby/spdystream v0.2.0/go.mod h1:f7i0iNDQJ059oMTcWxx8MA/zKFIuD/lY+0GqbN2Wy8c=
 github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=
 github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd h1:TRLaZ9cD/w8PVh93nsPXa1VrQ6jlwL5oN8l14QlcNfg=
@@ -125,15 +123,11 @@ github.com/rogpeppe/go-internal v1.6.1 h1:/FiVV8dS/e+YqF2JvO3yXRFbBLTIuSDkuC7aBO
 github.com/rogpeppe/go-internal v1.6.1/go.mod h1:xXDCJY+GAPziupqXw64V24skbSoqbTEfhy4qGm1nDQc=
 github.com/shirou/gopsutil v3.21.11+incompatible h1:+1+c1VGhc88SSonWP6foOcLhvnKlUeu/erjjvaPEYiI=
 github.com/shirou/gopsutil v3.21.11+incompatible/go.mod h1:5b4v6he4MtMOwMlS0TUMTu2PcXUg8+E1lC7eC3UO/RA=
-github.com/sirupsen/logrus v1.8.1 h1:dJKuHgqk1NNQlqoA6BTlM1Wf9DOH3NBjQyu0h9+AZZE=
-github.com/sirupsen/logrus v1.8.1/go.mod h1:yWOB1SBYBC5VeMP7gHvWumXLIWorT60ONWic61uBYv0=
 github.com/spf13/afero v1.2.2/go.mod h1:9ZxEEn6pIJ8Rxe320qSDBk6AsU0r9pR7Q4OcevTdifk=
-github.com/spf13/pflag v1.0.3/go.mod h1:DYY7MBk1bdzusC3SYhjObp+wFpr4gzcvqqNjLnInEg4=
 github.com/spf13/pflag v1.0.5 h1:iy+VFUOCP1a+8yFto/drg2CJ5u0yRoB7fZw3DKv/JXA=
 github.com/spf13/pflag v1.0.5/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
 github.com/stoewer/go-strcase v1.2.0/go.mod h1:IBiWB2sKIp3wVVQ3Y035++gc+knqhUQag1KpM8ahLw8=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
-github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
 github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5cxcmMvtA=
 github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
@@ -192,14 +186,12 @@ golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7w
 golang.org/x/sys v0.0.0-20190904154756-749cb33beabd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20190916202348-b4ddaad3f8a3/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20191005200804-aed5e4c7ecf9/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.0.0-20191026070338-33540a1f6037/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20191120155948-bd437916bb0e/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20200217220822-9197077df867/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20200323222414-85ca7c5b95cd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20200519105757-fe76b779f299/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.0.0-20210119212857-b64e53b001e4/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20210330210617-4fbd30eecc44/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
@@ -229,7 +221,6 @@ golang.org/x/tools v0.0.0-20200130002326-2f3ba24bd6e7/go.mod h1:TB2adYChydJhpapK
 golang.org/x/tools v0.0.0-20200505023115-26f46d2f7ef8/go.mod h1:EkVYQZoAsY45+roYkvgYkIh4xh/qjgUK9TdY2XT94GE=
 golang.org/x/tools v0.0.0-20200619180055-7c47624df98f/go.mod h1:EkVYQZoAsY45+roYkvgYkIh4xh/qjgUK9TdY2XT94GE=
 golang.org/x/tools v0.0.0-20210106214847-113979e3529a/go.mod h1:emZCQorbCU4vsT4fOWvOPXz4eW1wZW4PmDk9uLelYpA=
-golang.org/x/tools v0.1.0/go.mod h1:xkSsbof2nBLbhDlRMhhhyNLN/zl3eTqcnHD5viDpcZ0=
 golang.org/x/tools v0.1.5/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk=
 golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
@@ -278,8 +269,6 @@ gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C
 gopkg.in/yaml.v3 v3.0.0-20200615113413-eeeca48fe776/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b h1:h8qDotaEPuJATrMmW04NCwg7v22aHH28wwpauUhK9Oo=
 gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
-gotest.tools/v3 v3.3.0 h1:MfDY1b1/0xN1CyMlQDac0ziEy9zJQd9CXBRRDHw2jJo=
-gotest.tools/v3 v3.3.0/go.mod h1:Mcr9QNxkg0uMvy/YElmo4SpXgJKWgQvYrT7Kw5RzJ1A=
 honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
 honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
 k8s.io/api v0.23.3 h1:KNrME8KHGr12Ozjf8ytOewKzZh6hl/hHUZeHddT3a38=

tap/tlstapper/bpf-builder/build.sh

@@ -21,7 +21,7 @@ docker run --rm \
 	-it mizu-ebpf-builder \
 	sh -c "
 		BPF_TARGET=\"$BPF_TARGET\" BPF_CFLAGS=\"$BPF_CFLAGS\" go generate tap/tlstapper/tls_tapper.go
-        chown $(id -u):$(id -g) tap/tlstapper/tlstapper*_bpf*
+		chown $(id -u):$(id -g) tap/tlstapper/tlstapper_bpf*
 	" || exit 1
 
 popd

tap/tlstapper/bpf/common.c

@@ -12,7 +12,7 @@ Copyright (C) UP9 Inc.
 #include "include/common.h"
 
 
-static __always_inline int add_address_to_chunk(struct pt_regs *ctx, struct tls_chunk* chunk, __u64 id, __u32 fd, struct ssl_info* info) {
+static __always_inline int add_address_to_chunk(struct pt_regs *ctx, struct tls_chunk* chunk, __u64 id, __u32 fd) {
     __u32 pid = id >> 32;
     __u64 key = (__u64) pid << 32 | fd;
 
@@ -22,29 +22,14 @@ static __always_inline int add_address_to_chunk(struct pt_regs *ctx, struct tls_
         return 0;
     }
 
-    int err;
-
-    switch (info->address_info.mode) {
-        case ADDRESS_INFO_MODE_UNDEFINED:
-            chunk->address_info.mode = ADDRESS_INFO_MODE_SINGLE;
-            err = bpf_probe_read(&chunk->address_info.sport, sizeof(chunk->address_info.sport), &fdinfo->ipv4_addr[2]);
-            if (err != 0) {
-                log_error(ctx, LOG_ERROR_READING_FD_ADDRESS, id, err, 0l);
-                return 0;
-            }
-
-            err = bpf_probe_read(&chunk->address_info.saddr, sizeof(chunk->address_info.saddr), &fdinfo->ipv4_addr[4]);
-            if (err != 0) {
-                log_error(ctx, LOG_ERROR_READING_FD_ADDRESS, id, err, 0l);
-                return 0;
-            }
-            break;
-        default:
-            bpf_probe_read(&chunk->address_info, sizeof(chunk->address_info), &info->address_info);
-    }
-
+    int err = bpf_probe_read(chunk->address, sizeof(chunk->address), fdinfo->ipv4_addr);
     chunk->flags |= (fdinfo->flags & FLAGS_IS_CLIENT_BIT);
 
+    if (err != 0) {
+        log_error(ctx, LOG_ERROR_READING_FD_ADDRESS, id, err, 0l);
+        return 0;
+    }
+
     return 1;
 }
 
@@ -119,7 +104,7 @@ static __always_inline void output_ssl_chunk(struct pt_regs *ctx, struct ssl_inf
     chunk->len = count_bytes;
     chunk->fd = info->fd;
 
-    if (!add_address_to_chunk(ctx, chunk, id, chunk->fd, info)) {
+    if (!add_address_to_chunk(ctx, chunk, id, chunk->fd)) {
         // Without an address, we drop the chunk because there is not much to do with it in Go
         //
         return;

tap/tlstapper/bpf/go_uprobes.c

@@ -35,12 +35,11 @@ using `bpf_probe_read` calls in `go_crypto_tls_get_fd_from_tcp_conn` function.
 
 SOURCES:
 
-Tracing Go Functions with eBPF (<=1.16): https://www.grant.pizza/blog/tracing-go-functions-with-ebpf-part-2/
+Tracing Go Functions with eBPF (before 1.17): https://www.grant.pizza/blog/tracing-go-functions-with-ebpf-part-2/
 Challenges of BPF Tracing Go: https://blog.0x74696d.com/posts/challenges-of-bpf-tracing-go/
 x86 calling conventions: https://en.wikipedia.org/wiki/X86_calling_conventions
 Plan 9 from Bell Labs: https://en.wikipedia.org/wiki/Plan_9_from_Bell_Labs
 The issue for calling convention change in Go: https://github.com/golang/go/issues/40724
-Go ABI0 (<=1.16) specification: https://go.dev/doc/asm
 Proposal of Register-based Go calling convention: https://go.googlesource.com/proposal/+/master/design/40724-register-calling.md
 Go internal ABI (1.17) specification: https://go.googlesource.com/go/+/refs/heads/dev.regabi/src/cmd/compile/internal-abi.md
 Go internal ABI (current) specification: https://go.googlesource.com/go/+/refs/heads/master/src/cmd/compile/abi-internal.md
@@ -56,60 +55,10 @@ Capstone Engine: https://www.capstone-engine.org/
 #include "include/logger_messages.h"
 #include "include/pids.h"
 #include "include/common.h"
-#include "include/go_abi_0.h"
 #include "include/go_abi_internal.h"
 #include "include/go_types.h"
 
-
-// TODO: cilium/ebpf does not support .kconfig Therefore; for now, we build object files per kernel version.
-// Error: reference to .kconfig: not supported
-// See: https://github.com/cilium/ebpf/issues/698
-// extern int LINUX_KERNEL_VERSION __kconfig;
-
-enum ABI {
-    ABI0=0,
-    ABIInternal=1,
-};
-
-#if defined(bpf_target_x86)
-// get_goid_from_thread_local_storage function is x86 specific
-static __always_inline __u32 get_goid_from_thread_local_storage(__u64 *goroutine_id) {
-    int zero = 0;
-    int one = 1;
-    struct goid_offsets* offsets = bpf_map_lookup_elem(&goid_offsets_map, &zero);
-    if (offsets == NULL) {
-        return 0;
-    }
-
-    // Get the task that currently assigned to this thread.
-    struct task_struct *task = (struct task_struct*) bpf_get_current_task();
-    if (task == NULL) {
-        return 0;
-    }
-
-    // Read task->thread
-    struct thread_struct *thr;
-    bpf_probe_read(&thr, sizeof(thr), &task->thread);
-
-    // Read task->thread.fsbase
-    u64 fsbase;
-#ifdef KERNEL_BEFORE_4_6
-    // TODO: if (LINUX_KERNEL_VERSION <= KERNEL_VERSION(4, 6, 0)) {
-    fsbase = BPF_CORE_READ((struct thread_struct___v46 *)thr, fs);
-#else
-    fsbase = BPF_CORE_READ(thr, fsbase);
-#endif
-
-    // Get the Goroutine ID (goid) which is stored in thread-local storage.
-    size_t g_addr;
-    bpf_probe_read_user(&g_addr, sizeof(void *), (void*)(fsbase + offsets->g_addr_offset));
-    bpf_probe_read_user(goroutine_id, sizeof(void *), (void*)(g_addr + offsets->goid_offset));
-
-    return 1;
-}
-#endif
-
-static __always_inline __u32 go_crypto_tls_get_fd_from_tcp_conn(struct pt_regs *ctx, enum ABI abi) {
+static __always_inline __u32 go_crypto_tls_get_fd_from_tcp_conn(struct pt_regs *ctx) {
     struct go_interface conn;
     long err;
     __u64 addr;
@@ -118,15 +67,8 @@ static __always_inline __u32 go_crypto_tls_get_fd_from_tcp_conn(struct pt_regs *
     if (err != 0) {
         return invalid_fd;
     }
-#elif defined(bpf_target_x86)
-    if (abi == ABI0) {
-        err = bpf_probe_read(&addr, sizeof(addr), (void*)GO_ABI_INTERNAL_PT_REGS_SP(ctx)+0x8);
-        if (err != 0) {
-            return invalid_fd;
-        }
-    } else {
-        addr = GO_ABI_INTERNAL_PT_REGS_R1(ctx);
-    }
+#else
+    addr = GO_ABI_INTERNAL_PT_REGS_R1(ctx);
 #endif
 
     err = bpf_probe_read(&conn, sizeof(conn), (void*)addr);
@@ -149,7 +91,7 @@ static __always_inline __u32 go_crypto_tls_get_fd_from_tcp_conn(struct pt_regs *
     return fd;
 }
 
-static __always_inline void go_crypto_tls_uprobe(struct pt_regs *ctx, struct bpf_map_def* go_context, enum ABI abi) {
+static __always_inline void go_crypto_tls_uprobe(struct pt_regs *ctx, struct bpf_map_def* go_context) {
     __u64 pid_tgid = bpf_get_current_pid_tgid();
     __u64 pid = pid_tgid >> 32;
     if (!should_tap(pid)) {
@@ -165,52 +107,14 @@ static __always_inline void go_crypto_tls_uprobe(struct pt_regs *ctx, struct bpf
         log_error(ctx, LOG_ERROR_READING_BYTES_COUNT, pid_tgid, err, ORIGIN_SSL_UPROBE_CODE);
         return;
     }
-#elif defined(bpf_target_x86)
-    if (abi == ABI0) {
-        err = bpf_probe_read(&info.buffer_len, sizeof(__u32), (void*)GO_ABI_0_PT_REGS_SP(ctx)+0x18);
-        if (err != 0) {
-            log_error(ctx, LOG_ERROR_READING_BYTES_COUNT, pid_tgid, err, ORIGIN_SSL_UPROBE_CODE);
-            return;
-        }
-    } else {
-        info.buffer_len = GO_ABI_INTERNAL_PT_REGS_R2(ctx);
-    }
+#else
+    info.buffer_len = GO_ABI_INTERNAL_PT_REGS_R2(ctx);
 #endif
+    info.buffer = (void*)GO_ABI_INTERNAL_PT_REGS_R4(ctx);
+    info.fd = go_crypto_tls_get_fd_from_tcp_conn(ctx);
 
-#if defined(bpf_target_x86)
-    if (abi == ABI0) {
-        err = bpf_probe_read(&info.buffer, sizeof(__u32), (void*)GO_ABI_0_PT_REGS_SP(ctx)+0x11);
-        if (err != 0) {
-            log_error(ctx, LOG_ERROR_READING_FROM_SSL_BUFFER, pid_tgid, err, ORIGIN_SSL_UPROBE_CODE);
-            return;
-        }
-        // We basically add 00 suffix to the hex address.
-        info.buffer = (void*)((long)info.buffer << 8);
-    } else {
-#endif
-        info.buffer = (void*)GO_ABI_INTERNAL_PT_REGS_R4(ctx);
-#if defined(bpf_target_x86)
-    }
-#endif
-    info.fd = go_crypto_tls_get_fd_from_tcp_conn(ctx, abi);
-
-    __u64 goroutine_id;
-    if (abi == ABI0) {
-#if defined(bpf_target_arm64)
-        // In case of ABI0 and arm64, it's stored in the Goroutine register
-        goroutine_id = GO_ABI_0_PT_REGS_GP(ctx);
-#elif defined(bpf_target_x86)
-        // In case of ABI0 and amd64, it's stored in the thread-local storage
-        int status = get_goid_from_thread_local_storage(&goroutine_id);
-        if (!status) {
-            return;
-        }
-#endif
-    } else {
-        // GO_ABI_INTERNAL_PT_REGS_GP is the Goroutine address in ABIInternal
-        goroutine_id = GO_ABI_INTERNAL_PT_REGS_GP(ctx);
-    }
-    __u64 pid_fp = pid << 32 | goroutine_id;
+    // GO_ABI_INTERNAL_PT_REGS_GP is Goroutine address
+    __u64 pid_fp = pid << 32 | GO_ABI_INTERNAL_PT_REGS_GP(ctx);
     err = bpf_map_update_elem(go_context, &pid_fp, &info, BPF_ANY);
 
     if (err != 0) {
@@ -220,30 +124,15 @@ static __always_inline void go_crypto_tls_uprobe(struct pt_regs *ctx, struct bpf
     return;
 }
 
-static __always_inline void go_crypto_tls_ex_uprobe(struct pt_regs *ctx, struct bpf_map_def* go_context, __u32 flags, enum ABI abi) {
+static __always_inline void go_crypto_tls_ex_uprobe(struct pt_regs *ctx, struct bpf_map_def* go_context, __u32 flags) {
     __u64 pid_tgid = bpf_get_current_pid_tgid();
     __u64 pid = pid_tgid >> 32;
     if (!should_tap(pid)) {
         return;
     }
 
-    __u64 goroutine_id;
-    if (abi == ABI0) {
-#if defined(bpf_target_arm64)
-        // In case of ABI0 and arm64, it's stored in the Goroutine register
-        goroutine_id = GO_ABI_0_PT_REGS_GP(ctx);
-#elif defined(bpf_target_x86)
-        // In case of ABI0 and amd64, it's stored in the thread-local storage
-        int status = get_goid_from_thread_local_storage(&goroutine_id);
-        if (!status) {
-            return;
-        }
-#endif
-    } else {
-        // GO_ABI_INTERNAL_PT_REGS_GP is the Goroutine address in ABIInternal
-        goroutine_id = GO_ABI_INTERNAL_PT_REGS_GP(ctx);
-    }
-    __u64 pid_fp = pid << 32 | goroutine_id;
+    // GO_ABI_INTERNAL_PT_REGS_GP is Goroutine address
+    __u64 pid_fp = pid << 32 | GO_ABI_INTERNAL_PT_REGS_GP(ctx);
     struct ssl_info *info_ptr = bpf_map_lookup_elem(go_context, &pid_fp);
 
     if (info_ptr == NULL) {
@@ -267,17 +156,8 @@ static __always_inline void go_crypto_tls_ex_uprobe(struct pt_regs *ctx, struct
             return;
         }
         info.buffer_len = GO_ABI_INTERNAL_PT_REGS_R7(ctx); // n in return n, nil
-#elif defined(bpf_target_x86)
-        if (abi == ABI0) {
-            // n in return n, nil
-            err = bpf_probe_read(&info.buffer_len, sizeof(__u32), (void*)GO_ABI_0_PT_REGS_SP(ctx)+0x28);
-            if (err != 0) {
-                log_error(ctx, LOG_ERROR_READING_BYTES_COUNT, pid_tgid, err, ORIGIN_SSL_UPROBE_CODE);
-                return;
-            }
-        } else {
-            info.buffer_len = GO_ABI_INTERNAL_PT_REGS_R1(ctx); // n in return n, nil
-        }
+#else
+        info.buffer_len = GO_ABI_INTERNAL_PT_REGS_R1(ctx); // n in return n, nil
 #endif
         // This check achieves ignoring 0 length reads (the reads result with an error)
         if (info.buffer_len <= 0) {
@@ -290,50 +170,22 @@ static __always_inline void go_crypto_tls_ex_uprobe(struct pt_regs *ctx, struct
     return;
 }
 
-SEC("uprobe/go_crypto_tls_abi0_write")
-int BPF_KPROBE(go_crypto_tls_abi0_write) {
-    go_crypto_tls_uprobe(ctx, &go_write_context, ABI0);
-    return 1;
+SEC("uprobe/go_crypto_tls_write")
+void BPF_KPROBE(go_crypto_tls_write) {
+    go_crypto_tls_uprobe(ctx, &go_write_context);
 }
 
-SEC("uprobe/go_crypto_tls_abi0_write_ex")
-int BPF_KPROBE(go_crypto_tls_abi0_write_ex) {
-    go_crypto_tls_ex_uprobe(ctx, &go_write_context, 0, ABI0);
-    return 1;
+SEC("uprobe/go_crypto_tls_write_ex")
+void BPF_KPROBE(go_crypto_tls_write_ex) {
+    go_crypto_tls_ex_uprobe(ctx, &go_write_context, 0);
 }
 
-SEC("uprobe/go_crypto_tls_abi0_read")
-int BPF_KPROBE(go_crypto_tls_abi0_read) {
-    go_crypto_tls_uprobe(ctx, &go_read_context, ABI0);
-    return 1;
+SEC("uprobe/go_crypto_tls_read")
+void BPF_KPROBE(go_crypto_tls_read) {
+    go_crypto_tls_uprobe(ctx, &go_read_context);
 }
 
-SEC("uprobe/go_crypto_tls_abi0_read_ex")
-int BPF_KPROBE(go_crypto_tls_abi0_read_ex) {
-    go_crypto_tls_ex_uprobe(ctx, &go_read_context, FLAGS_IS_READ_BIT, ABI0);
-    return 1;
-}
-
-SEC("uprobe/go_crypto_tls_abi_internal_write")
-int BPF_KPROBE(go_crypto_tls_abi_internal_write) {
-    go_crypto_tls_uprobe(ctx, &go_write_context, ABIInternal);
-    return 1;
-}
-
-SEC("uprobe/go_crypto_tls_abi_internal_write_ex")
-int BPF_KPROBE(go_crypto_tls_abi_internal_write_ex) {
-    go_crypto_tls_ex_uprobe(ctx, &go_write_context, 0, ABIInternal);
-    return 1;
-}
-
-SEC("uprobe/go_crypto_tls_abi_internal_read")
-int BPF_KPROBE(go_crypto_tls_abi_internal_read) {
-    go_crypto_tls_uprobe(ctx, &go_read_context, ABIInternal);
-    return 1;
-}
-
-SEC("uprobe/go_crypto_tls_abi_internal_read_ex")
-int BPF_KPROBE(go_crypto_tls_abi_internal_read_ex) {
-    go_crypto_tls_ex_uprobe(ctx, &go_read_context, FLAGS_IS_READ_BIT, ABIInternal);
-    return 1;
+SEC("uprobe/go_crypto_tls_read_ex")
+void BPF_KPROBE(go_crypto_tls_read_ex) {
+    go_crypto_tls_ex_uprobe(ctx, &go_read_context, FLAGS_IS_READ_BIT);
 }

tap/tlstapper/bpf/include/common.h

@@ -7,11 +7,9 @@ Copyright (C) UP9 Inc.
 #ifndef __COMMON__
 #define __COMMON__
 
-#define AF_INET	2	/* Internet IP Protocol */
-
 const __s32 invalid_fd = -1;
 
-static int add_address_to_chunk(struct pt_regs *ctx, struct tls_chunk* chunk, __u64 id, __u32 fd, struct ssl_info* info);
+static int add_address_to_chunk(struct pt_regs *ctx, struct tls_chunk* chunk, __u64 id, __u32 fd);
 static void send_chunk_part(struct pt_regs *ctx, __u8* buffer, __u64 id, struct tls_chunk* chunk, int start, int end);
 static void send_chunk(struct pt_regs *ctx, __u8* buffer, __u64 id, struct tls_chunk* chunk);
 static void output_ssl_chunk(struct pt_regs *ctx, struct ssl_info* info, int count_bytes, __u64 id, __u32 flags);

tap/tlstapper/bpf/include/go_abi_0.h

@@ -1,52 +0,0 @@
-/*
-Note: This file is licenced differently from the rest of the project
-SPDX-License-Identifier: GPL-2.0
-Copyright (C) UP9 Inc.
-*/
-
-#ifndef __GO_ABI_0__
-#define __GO_ABI_0__
-
-/*
-Go ABI0 (<=1.16) specification
-https://go.dev/doc/asm
-
-Since ABI0 is a stack-based calling convention we only need the stack pointer and
-if it's applicable the Goroutine pointer
-*/
-
-#include "target_arch.h"
-
-#if defined(bpf_target_x86)
-
-#ifdef __i386__
-
-#define GO_ABI_0_PT_REGS_SP(x) ((x)->esp)
-
-#else
-
-#define GO_ABI_0_PT_REGS_SP(x) ((x)->sp)
-
-#endif
-
-#elif defined(bpf_target_arm)
-
-#define GO_ABI_0_PT_REGS_SP(x) ((x)->uregs[13])
-#define GO_ABI_0_PT_REGS_GP(x) ((x)->uregs[10])
-
-#elif defined(bpf_target_arm64)
-
-/* arm64 provides struct user_pt_regs instead of struct pt_regs to userspace */
-struct pt_regs;
-#define PT_REGS_ARM64 const volatile struct user_pt_regs
-#define GO_ABI_0_PT_REGS_SP(x) (((PT_REGS_ARM64 *)(x))->sp)
-#define GO_ABI_0_PT_REGS_GP(x) (((PT_REGS_ARM64 *)(x))->regs[18])
-
-#elif defined(bpf_target_powerpc)
-
-#define GO_ABI_0_PT_REGS_SP(x) ((x)->sp)
-#define GO_ABI_0_PT_REGS_GP(x) ((x)->gpr[30])
-
-#endif
-
-#endif /* __GO_ABI_0__ */

tap/tlstapper/bpf/include/go_abi_internal.h

@@ -8,11 +8,54 @@ Copyright (C) UP9 Inc.
 #define __GO_ABI_INTERNAL__
 
 /*
-Go internal ABI (1.17/current) specification
+Go internal ABI specification
 https://go.googlesource.com/go/+/refs/heads/master/src/cmd/compile/abi-internal.md
 */
 
-#include "target_arch.h"
+/* Scan the ARCH passed in from ARCH env variable */
+#if defined(__TARGET_ARCH_x86)
+    #define bpf_target_x86
+    #define bpf_target_defined
+#elif defined(__TARGET_ARCH_s390)
+    #define bpf_target_s390
+    #define bpf_target_defined
+#elif defined(__TARGET_ARCH_arm)
+    #define bpf_target_arm
+    #define bpf_target_defined
+#elif defined(__TARGET_ARCH_arm64)
+    #define bpf_target_arm64
+    #define bpf_target_defined
+#elif defined(__TARGET_ARCH_mips)
+    #define bpf_target_mips
+    #define bpf_target_defined
+#elif defined(__TARGET_ARCH_powerpc)
+    #define bpf_target_powerpc
+    #define bpf_target_defined
+#elif defined(__TARGET_ARCH_sparc)
+    #define bpf_target_sparc
+    #define bpf_target_defined
+#else
+    #undef bpf_target_defined
+#endif
+
+/* Fall back to what the compiler says */
+#ifndef bpf_target_defined
+#if defined(__x86_64__)
+    #define bpf_target_x86
+#elif defined(__s390__)
+    #define bpf_target_s390
+#elif defined(__arm__)
+    #define bpf_target_arm
+#elif defined(__aarch64__)
+    #define bpf_target_arm64
+#elif defined(__mips__)
+    #define bpf_target_mips
+#elif defined(__powerpc__)
+    #define bpf_target_powerpc
+#elif defined(__sparc__)
+    #define bpf_target_sparc
+#endif
+#endif
 
 #if defined(bpf_target_x86)
 
@@ -35,15 +78,15 @@ https://github.com/golang/go/blob/go1.17.6/src/cmd/compile/internal/ssa/gen/AMD6
 
 #else
 
-#define GO_ABI_INTERNAL_PT_REGS_R1(x) ((x)->ax)
-#define GO_ABI_INTERNAL_PT_REGS_R2(x) ((x)->cx)
-#define GO_ABI_INTERNAL_PT_REGS_R3(x) ((x)->dx)
-#define GO_ABI_INTERNAL_PT_REGS_R4(x) ((x)->bx)
-#define GO_ABI_INTERNAL_PT_REGS_R5(x) ((x)->bp)
-#define GO_ABI_INTERNAL_PT_REGS_R6(x) ((x)->si)
-#define GO_ABI_INTERNAL_PT_REGS_R7(x) ((x)->di)
-#define GO_ABI_INTERNAL_PT_REGS_SP(x) ((x)->sp)
-#define GO_ABI_INTERNAL_PT_REGS_FP(x) ((x)->bp)
+#define GO_ABI_INTERNAL_PT_REGS_R1(x) ((x)->rax)
+#define GO_ABI_INTERNAL_PT_REGS_R2(x) ((x)->rcx)
+#define GO_ABI_INTERNAL_PT_REGS_R3(x) ((x)->rdx)
+#define GO_ABI_INTERNAL_PT_REGS_R4(x) ((x)->rbx)
+#define GO_ABI_INTERNAL_PT_REGS_R5(x) ((x)->rbp)
+#define GO_ABI_INTERNAL_PT_REGS_R6(x) ((x)->rsi)
+#define GO_ABI_INTERNAL_PT_REGS_R7(x) ((x)->rdi)
+#define GO_ABI_INTERNAL_PT_REGS_SP(x) ((x)->rsp)
+#define GO_ABI_INTERNAL_PT_REGS_FP(x) ((x)->rbp)
 #define GO_ABI_INTERNAL_PT_REGS_GP(x) ((x)->r14)
 
 #endif

tap/tlstapper/bpf/include/headers.h

@@ -8,16 +8,9 @@ Copyright (C) UP9 Inc.
 #define __HEADERS__
 
 #include <stddef.h>
-
-#include "target_arch.h"
-#include "vmlinux_x86.h"
-#include "vmlinux_arm64.h"
-
-#include "legacy_kernel.h"
-
-#include <bpf/bpf_endian.h>
+#include <linux/bpf.h>
+#include <linux/ptrace.h>
 #include <bpf/bpf_helpers.h>
-#include <bpf/bpf_tracing.h>
-#include <bpf/bpf_core_read.h>
+#include "bpf/bpf_tracing.h"
 
 #endif /* __HEADERS__ */

tap/tlstapper/bpf/include/legacy_kernel.h

@@ -1,50 +0,0 @@
-#ifndef __LEGACY_KERNEL_H__
-#define __LEGACY_KERNEL_H__
-
-#if defined(bpf_target_x86)
-
-struct thread_struct___v46 {
-	struct desc_struct tls_array[3];
-	unsigned long sp0;
-	unsigned long sp;
-	unsigned short es;
-	unsigned short ds;
-	unsigned short fsindex;
-	unsigned short gsindex;
-	unsigned long fs;
-	unsigned long gs;
-	struct perf_event ptrace_bps[4];
-	unsigned long debugreg6;
-	unsigned long ptrace_dr7;
-	unsigned long cr2;
-	unsigned long trap_nr;
-	unsigned long error_code;
-	unsigned long io_bitmap_ptr;
-	unsigned long iopl;
-	unsigned io_bitmap_max;
-    long: 63;
-	long: 64;
-	long: 64;
-	long: 64;
-	long: 64;
-	long: 64;
-	struct fpu fpu;
-};
-
-#elif defined(bpf_target_arm)
-
-// Commented out since thread_struct is not used in ARM64 yet.
-
-// struct thread_struct___v46 {
-//     struct cpu_context cpu_context;
-//     long: 64;
-// 	unsigned long tp_value;
-// 	struct fpsimd_state fpsimd_state;
-// 	unsigned long fault_address;
-// 	unsigned long fault_code;
-// 	struct debug_info debug;
-// };
-
-#endif
-
-#endif /* __LEGACY_KERNEL_H__ */

tap/tlstapper/bpf/include/logger_messages.h

@@ -26,11 +26,6 @@ Copyright (C) UP9 Inc.
 #define LOG_ERROR_PUTTING_CONNECT_INFO (14)
 #define LOG_ERROR_GETTING_CONNECT_INFO (15)
 #define LOG_ERROR_READING_CONNECT_INFO (16)
-#define LOG_ERROR_READING_SOCKET_FAMILY (17)
-#define LOG_ERROR_READING_SOCKET_DADDR (18)
-#define LOG_ERROR_READING_SOCKET_SADDR (19)
-#define LOG_ERROR_READING_SOCKET_DPORT (20)
-#define LOG_ERROR_READING_SOCKET_SPORT (21)
 
 // Sometimes we have the same error, happening from different locations.
 // 	in order to be able to distinct between them in the log, we add an 

tap/tlstapper/bpf/include/maps.h

@@ -24,21 +24,6 @@ Copyright (C) UP9 Inc.
 //  
 //  Be careful when editing, alignment and padding should be exactly the same in go/c.
 //
-
-typedef enum {
-    ADDRESS_INFO_MODE_UNDEFINED,
-    ADDRESS_INFO_MODE_SINGLE,
-    ADDRESS_INFO_MODE_PAIR,
-} address_info_mode;
-
-struct address_info {
-    address_info_mode mode;
-    __be32 saddr;
-    __be32 daddr;
-    __be16 sport;
-    __be16 dport;
-};
-
 struct tls_chunk {
     __u32 pid;
     __u32 tgid;
@@ -47,7 +32,7 @@ struct tls_chunk {
     __u32 recorded;
     __u32 fd;
     __u32 flags;
-    struct address_info address_info;
+    __u8 address[16];
     __u8 data[CHUNK_SIZE]; // Must be N^2
 };
 
@@ -56,7 +41,6 @@ struct ssl_info {
     __u32 buffer_len;
     __u32 fd;
     __u64 created_at_nano;
-    struct address_info address_info;
     
     // for ssl_write and ssl_read must be zero
     // for ssl_write_ex and ssl_read_ex save the *written/*readbytes pointer. 
@@ -69,13 +53,6 @@ struct fd_info {
     __u8 flags;
 };
 
-struct goid_offsets {
-    __u64 g_addr_offset;
-    __u64 goid_offset;
-};
-
-const struct goid_offsets *unused __attribute__((unused));
-
 // Heap-like area for eBPF programs - stack size limited to 512 bytes, we must use maps for bigger (chunk) objects.
 //
 struct {
@@ -114,7 +91,6 @@ BPF_LRU_HASH(openssl_write_context, __u64, struct ssl_info);
 BPF_LRU_HASH(openssl_read_context, __u64, struct ssl_info);
 
 // Go specific
-BPF_HASH(goid_offsets_map, __u32, struct goid_offsets);
 BPF_LRU_HASH(go_write_context, __u64, struct ssl_info);
 BPF_LRU_HASH(go_read_context, __u64, struct ssl_info);
 

tap/tlstapper/bpf/include/target_arch.h

@@ -1,55 +0,0 @@
-/*
-Note: This file is licenced differently from the rest of the project
-SPDX-License-Identifier: GPL-2.0
-Copyright (C) UP9 Inc.
-*/
-
-#ifndef __TARGET_ARCH__
-#define __TARGET_ARCH__
-
-/* Scan the ARCH passed in from ARCH env variable */
-#if defined(__TARGET_ARCH_x86)
-    #define bpf_target_x86
-    #define bpf_target_defined
-#elif defined(__TARGET_ARCH_s390)
-    #define bpf_target_s390
-    #define bpf_target_defined
-#elif defined(__TARGET_ARCH_arm)
-    #define bpf_target_arm
-    #define bpf_target_defined
-#elif defined(__TARGET_ARCH_arm64)
-    #define bpf_target_arm64
-    #define bpf_target_defined
-#elif defined(__TARGET_ARCH_mips)
-    #define bpf_target_mips
-    #define bpf_target_defined
-#elif defined(__TARGET_ARCH_powerpc)
-    #define bpf_target_powerpc
-    #define bpf_target_defined
-#elif defined(__TARGET_ARCH_sparc)
-    #define bpf_target_sparc
-    #define bpf_target_defined
-#else
-    #undef bpf_target_defined
-#endif
-
-/* Fall back to what the compiler says */
-#ifndef bpf_target_defined
-#if defined(__x86_64__)
-    #define bpf_target_x86
-#elif defined(__s390__)
-    #define bpf_target_s390
-#elif defined(__arm__)
-    #define bpf_target_arm
-#elif defined(__aarch64__)
-    #define bpf_target_arm64
-#elif defined(__mips__)
-    #define bpf_target_mips
-#elif defined(__powerpc__)
-    #define bpf_target_powerpc
-#elif defined(__sparc__)
-    #define bpf_target_sparc
-#endif
-#endif
-
-#endif /* __TARGET_ARCH__ */

tap/tlstapper/bpf/openssl_uprobes.c

@@ -42,8 +42,6 @@ static __always_inline int get_count_bytes(struct pt_regs *ctx, struct ssl_info*
 }
 
 static __always_inline void ssl_uprobe(struct pt_regs *ctx, void* ssl, void* buffer, int num, struct bpf_map_def* map_fd, size_t *count_ptr) {
-	long err;
-
 	__u64 id = bpf_get_current_pid_tgid();
 	
 	if (!should_tap(id >> 32)) {
@@ -55,7 +53,7 @@ static __always_inline void ssl_uprobe(struct pt_regs *ctx, void* ssl, void* buf
 	info.count_ptr = count_ptr;
 	info.buffer = buffer;
 	
-	err = bpf_map_update_elem(map_fd, &id, &info, BPF_ANY);
+	long err = bpf_map_update_elem(map_fd, &id, &info, BPF_ANY);
 	
 	if (err != 0) {
 		log_error(ctx, LOG_ERROR_PUTTING_SSL_CONTEXT, id, err, 0l);
@@ -68,7 +66,7 @@ static __always_inline void ssl_uretprobe(struct pt_regs *ctx, struct bpf_map_de
 	if (!should_tap(id >> 32)) {
 		return;
 	}
-
+	
 	struct ssl_info *infoPtr = bpf_map_lookup_elem(map_fd, &id);
 	
 	if (infoPtr == NULL) {
@@ -101,10 +99,10 @@ static __always_inline void ssl_uretprobe(struct pt_regs *ctx, struct bpf_map_de
 		return;
 	}
 
-	int count_bytes = get_count_bytes(ctx, &info, id);
-	if (count_bytes <= 0) {
-		return;
-	}
+    int count_bytes = get_count_bytes(ctx, &info, id);
+    if (count_bytes <= 0) {
+        return;
+    }
 
 	output_ssl_chunk(ctx, &info, count_bytes, id, flags);
 }

tap/tlstapper/bpf/tcp_kprobes.c

@@ -1,79 +0,0 @@
-#include "include/headers.h"
-#include "include/maps.h"
-#include "include/log.h"
-#include "include/logger_messages.h"
-#include "include/pids.h"
-#include "include/common.h"
-
-static __always_inline void tcp_kprobe(struct pt_regs *ctx, struct bpf_map_def *map_fd, _Bool is_send) {
-	long err;
-
-	__u64 id = bpf_get_current_pid_tgid();
-	__u32 pid = id >> 32;
-
-	if (!should_tap(id >> 32)) {
-		return;
-	}
-
-	struct ssl_info *info_ptr = bpf_map_lookup_elem(map_fd, &id);
-	// Happens when the connection is not tls
-	if (info_ptr == NULL) {
-		return;
-	}
-
-	struct sock *sk = (struct sock *) PT_REGS_PARM1(ctx);
-
-	short unsigned int family;
-	err = bpf_probe_read(&family, sizeof(family), (void *)&sk->__sk_common.skc_family);
-	if (err != 0) {
-		log_error(ctx, LOG_ERROR_READING_SOCKET_FAMILY, id, err, 0l);
-		return;
-	}
-	if (family != AF_INET) {
-		return;
-	}
-
-	// daddr, saddr and dport are in network byte order (big endian)
-	// sport is in host byte order
-	__be32 saddr;
-	__be32 daddr;
-	__be16 dport;
-	__u16 sport;
-
-	err = bpf_probe_read(&saddr, sizeof(saddr), (void *)&sk->__sk_common.skc_rcv_saddr);
-	if (err != 0) {
-		log_error(ctx, LOG_ERROR_READING_SOCKET_SADDR, id, err, 0l);
-		return;
-	}
-	err = bpf_probe_read(&daddr, sizeof(daddr), (void *)&sk->__sk_common.skc_daddr);
-	if (err != 0) {
-		log_error(ctx, LOG_ERROR_READING_SOCKET_DADDR, id, err, 0l);
-		return;
-	}
-	err = bpf_probe_read(&dport, sizeof(dport), (void *)&sk->__sk_common.skc_dport);
-	if (err != 0) {
-		log_error(ctx, LOG_ERROR_READING_SOCKET_DPORT, id, err, 0l);
-		return;
-	}
-	err = bpf_probe_read(&sport, sizeof(sport), (void *)&sk->__sk_common.skc_num);
-	if (err != 0) {
-		log_error(ctx, LOG_ERROR_READING_SOCKET_SPORT, id, err, 0l);
-		return;
-	}
-
-	info_ptr->address_info.mode = ADDRESS_INFO_MODE_PAIR;
-	info_ptr->address_info.daddr = daddr;
-	info_ptr->address_info.saddr = saddr;
-	info_ptr->address_info.dport = dport;
-	info_ptr->address_info.sport = bpf_htons(sport);
-}
-
-SEC("kprobe/tcp_sendmsg")
-void BPF_KPROBE(tcp_sendmsg) {
-	tcp_kprobe(ctx, &openssl_write_context, true);
-}
-
-SEC("kprobe/tcp_recvmsg")
-void BPF_KPROBE(tcp_recvmsg) {
-	tcp_kprobe(ctx, &openssl_read_context, false);
-}

tap/tlstapper/bpf/tls_tapper.c

@@ -15,7 +15,6 @@ Copyright (C) UP9 Inc.
 //
 #include "common.c"
 #include "openssl_uprobes.c"
-#include "tcp_kprobes.c"
 #include "go_uprobes.c"
 #include "fd_tracepoints.c"
 #include "fd_to_address_tracepoints.c"

tap/tlstapper/bpf_logger_messages.go

@@ -20,9 +20,4 @@ var bpfLogMessages = []string{
 	/*0014*/ "[%d] Unable to put connect info [err: %d]",
 	/*0015*/ "[%d] Unable to get connect info",
 	/*0016*/ "[%d] Unable to read connect info [err: %d]",
-	/*0017*/ "[%d] Unable to read socket family [err: %d]",
-	/*0018*/ "[%d] Unable to read socket daddr [err: %d]",
-	/*0019*/ "[%d] Unable to read socket saddr [err: %d]",
-	/*0019*/ "[%d] Unable to read socket dport [err: %d]",
-	/*0021*/ "[%d] Unable to read socket sport [err: %d]",
 }

tap/tlstapper/chunk.go

@@ -1,33 +1,38 @@
 package tlstapper
 
 import (
+	"bytes"
 	"encoding/binary"
 	"net"
-	"unsafe"
 
+	"github.com/go-errors/errors"
 	"github.com/up9inc/mizu/tap/api"
 )
 
 const FlagsIsClientBit uint32 = 1 << 0
 const FlagsIsReadBit uint32 = 1 << 1
-const (
-	addressInfoModeUndefined = iota
-	addressInfoModeSingle
-	addressInfoModePair
-)
 
-func (c *tlsTapperTlsChunk) getSrcAddress() (net.IP, uint16) {
-	ip := intToIP(c.AddressInfo.Saddr)
-	port := ntohs(c.AddressInfo.Sport)
+func (c *tlsTapperTlsChunk) getAddress() (net.IP, uint16, error) {
+	address := bytes.NewReader(c.Address[:])
+	var family uint16
+	var port uint16
+	var ip32 uint32
 
-	return ip, port
-}
+	if err := binary.Read(address, binary.BigEndian, &family); err != nil {
+		return nil, 0, errors.Wrap(err, 0)
+	}
 
-func (c *tlsTapperTlsChunk) getDstAddress() (net.IP, uint16) {
-	ip := intToIP(c.AddressInfo.Daddr)
-	port := ntohs(c.AddressInfo.Dport)
+	if err := binary.Read(address, binary.BigEndian, &port); err != nil {
+		return nil, 0, errors.Wrap(err, 0)
+	}
 
-	return ip, port
+	if err := binary.Read(address, binary.BigEndian, &ip32); err != nil {
+		return nil, 0, errors.Wrap(err, 0)
+	}
+
+	ip := net.IP{uint8(ip32 >> 24), uint8(ip32 >> 16), uint8(ip32 >> 8), uint8(ip32)}
+
+	return ip, port, nil
 }
 
 func (c *tlsTapperTlsChunk) isClient() bool {
@@ -54,54 +59,26 @@ func (c *tlsTapperTlsChunk) isRequest() bool {
 	return (c.isClient() && c.isWrite()) || (c.isServer() && c.isRead())
 }
 
-func (c *tlsTapperTlsChunk) getAddressPair() (addressPair, bool) {
-	var (
-		srcIp, dstIp     net.IP
-		srcPort, dstPort uint16
-		full             bool
-	)
+func (c *tlsTapperTlsChunk) getAddressPair() (addressPair, error) {
+	ip, port, err := c.getAddress()
 
-	switch c.AddressInfo.Mode {
-	case addressInfoModeSingle:
-		if c.isRequest() {
-			srcIp, srcPort = api.UnknownIp, api.UnknownPort
-			dstIp, dstPort = c.getSrcAddress()
-		} else {
-			srcIp, srcPort = c.getSrcAddress()
-			dstIp, dstPort = api.UnknownIp, api.UnknownPort
-		}
-		full = false
-	case addressInfoModePair:
-		if c.isRequest() {
-			srcIp, srcPort = c.getSrcAddress()
-			dstIp, dstPort = c.getDstAddress()
-		} else {
-			srcIp, srcPort = c.getDstAddress()
-			dstIp, dstPort = c.getSrcAddress()
-		}
-		full = true
-	case addressInfoModeUndefined:
-		srcIp, srcPort = api.UnknownIp, api.UnknownPort
-		dstIp, dstPort = api.UnknownIp, api.UnknownPort
-		full = false
+	if err != nil {
+		return addressPair{}, err
 	}
 
-	return addressPair{
-		srcIp:   srcIp,
-		srcPort: srcPort,
-		dstIp:   dstIp,
-		dstPort: dstPort,
-	}, full
-}
-
-// intToIP converts IPv4 number to net.IP
-func intToIP(ip32be uint32) net.IP {
-	return net.IPv4(uint8(ip32be), uint8(ip32be>>8), uint8(ip32be>>16), uint8(ip32be>>24))
-}
-
-// ntohs converts big endian (network byte order) to little endian (assuming that's the host byte order)
-func ntohs(i16be uint16) uint16 {
-	b := make([]byte, 2)
-	binary.BigEndian.PutUint16(b, i16be)
-	return *(*uint16)(unsafe.Pointer(&b[0]))
+	if c.isRequest() {
+		return addressPair{
+			srcIp:   api.UnknownIp,
+			srcPort: api.UnknownPort,
+			dstIp:   ip,
+			dstPort: port,
+		}, nil
+	} else {
+		return addressPair{
+			srcIp:   ip,
+			srcPort: port,
+			dstIp:   api.UnknownIp,
+			dstPort: api.UnknownPort,
+		}, nil
+	}
 }

tap/tlstapper/go_hooks.go

@@ -31,32 +31,9 @@ func (s *goHooks) installUprobes(bpfObjects *tlsTapperObjects, filePath string)
 func (s *goHooks) installHooks(bpfObjects *tlsTapperObjects, ex *link.Executable, offsets goOffsets) error {
 	var err error
 
-	goCryptoTlsWrite := bpfObjects.GoCryptoTlsAbiInternalWrite
-	goCryptoTlsWriteEx := bpfObjects.GoCryptoTlsAbiInternalWriteEx
-	goCryptoTlsRead := bpfObjects.GoCryptoTlsAbiInternalRead
-	goCryptoTlsReadEx := bpfObjects.GoCryptoTlsAbiInternalReadEx
-
-	if offsets.Abi == ABI0 {
-		goCryptoTlsWrite = bpfObjects.GoCryptoTlsAbi0Write
-		goCryptoTlsWriteEx = bpfObjects.GoCryptoTlsAbi0WriteEx
-		goCryptoTlsRead = bpfObjects.GoCryptoTlsAbi0Read
-		goCryptoTlsReadEx = bpfObjects.GoCryptoTlsAbi0ReadEx
-
-		// Pass goid and g struct offsets to an eBPF map to retrieve it in eBPF context
-		if err := bpfObjects.tlsTapperMaps.GoidOffsetsMap.Put(
-			uint32(0),
-			tlsTapperGoidOffsets{
-				G_addrOffset: offsets.GStructOffset,
-				GoidOffset:   offsets.GoidOffset,
-			},
-		); err != nil {
-			return errors.Wrap(err, 0)
-		}
-	}
-
 	// Symbol points to
 	// [`crypto/tls.(*Conn).Write`](https://github.com/golang/go/blob/go1.17.6/src/crypto/tls/conn.go#L1099)
-	s.goWriteProbe, err = ex.Uprobe(goWriteSymbol, goCryptoTlsWrite, &link.UprobeOptions{
+	s.goWriteProbe, err = ex.Uprobe(goWriteSymbol, bpfObjects.GoCryptoTlsWrite, &link.UprobeOptions{
 		Offset: offsets.GoWriteOffset.enter,
 	})
 
@@ -65,7 +42,7 @@ func (s *goHooks) installHooks(bpfObjects *tlsTapperObjects, ex *link.Executable
 	}
 
 	for _, offset := range offsets.GoWriteOffset.exits {
-		probe, err := ex.Uprobe(goWriteSymbol, goCryptoTlsWriteEx, &link.UprobeOptions{
+		probe, err := ex.Uprobe(goWriteSymbol, bpfObjects.GoCryptoTlsWriteEx, &link.UprobeOptions{
 			Offset: offset,
 		})
 
@@ -78,7 +55,7 @@ func (s *goHooks) installHooks(bpfObjects *tlsTapperObjects, ex *link.Executable
 
 	// Symbol points to
 	// [`crypto/tls.(*Conn).Read`](https://github.com/golang/go/blob/go1.17.6/src/crypto/tls/conn.go#L1263)
-	s.goReadProbe, err = ex.Uprobe(goReadSymbol, goCryptoTlsRead, &link.UprobeOptions{
+	s.goReadProbe, err = ex.Uprobe(goReadSymbol, bpfObjects.GoCryptoTlsRead, &link.UprobeOptions{
 		Offset: offsets.GoReadOffset.enter,
 	})
 
@@ -87,7 +64,7 @@ func (s *goHooks) installHooks(bpfObjects *tlsTapperObjects, ex *link.Executable
 	}
 
 	for _, offset := range offsets.GoReadOffset.exits {
-		probe, err := ex.Uprobe(goReadSymbol, goCryptoTlsReadEx, &link.UprobeOptions{
+		probe, err := ex.Uprobe(goReadSymbol, bpfObjects.GoCryptoTlsReadEx, &link.UprobeOptions{
 			Offset: offset,
 		})
 

tap/tlstapper/go_offsets.go

@@ -2,10 +2,8 @@ package tlstapper
 
 import (
 	"bufio"
-	"debug/dwarf"
 	"debug/elf"
 	"fmt"
-	"io"
 	"os"
 	"runtime"
 
@@ -15,22 +13,9 @@ import (
 	"github.com/up9inc/mizu/logger"
 )
 
-type goAbi int
-
-const (
-	ABI0 goAbi = iota
-	ABIInternal
-)
-
-const PtrSize int = 8
-
 type goOffsets struct {
 	GoWriteOffset *goExtendedOffset
 	GoReadOffset  *goExtendedOffset
-	GoVersion     string
-	Abi           goAbi
-	GoidOffset    uint64
-	GStructOffset uint64
 }
 
 type goExtendedOffset struct {
@@ -39,33 +24,30 @@ type goExtendedOffset struct {
 }
 
 const (
-	minimumABIInternalGoVersion = "1.17.0"
-	goVersionSymbol             = "runtime.buildVersion.str" // symbol does not exist in Go (<=1.16)
-	goWriteSymbol               = "crypto/tls.(*Conn).Write"
-	goReadSymbol                = "crypto/tls.(*Conn).Read"
+	minimumSupportedGoVersion = "1.17.0"
+	goVersionSymbol           = "runtime.buildVersion.str"
+	goWriteSymbol             = "crypto/tls.(*Conn).Write"
+	goReadSymbol              = "crypto/tls.(*Conn).Read"
 )
 
 func findGoOffsets(filePath string) (goOffsets, error) {
-	offsets, goidOffset, gStructOffset, err := getOffsets(filePath)
+	offsets, err := getOffsets(filePath)
 	if err != nil {
 		return goOffsets{}, err
 	}
 
-	abi := ABI0
-	var passed bool
-	var goVersion string
-
 	goVersionOffset, err := getOffset(offsets, goVersionSymbol)
-	if err == nil {
-		// TODO: Replace this logic with https://pkg.go.dev/debug/buildinfo#ReadFile once we upgrade to 1.18
-		passed, goVersion, err = checkGoVersion(filePath, goVersionOffset)
-		if err != nil {
-			return goOffsets{}, fmt.Errorf("Checking Go version: %s", err)
-		}
+	if err != nil {
+		return goOffsets{}, err
 	}
 
-	if passed {
-		abi = ABIInternal
+	passed, goVersion, err := checkGoVersion(filePath, goVersionOffset)
+	if err != nil {
+		return goOffsets{}, fmt.Errorf("Checking Go version: %s", err)
+	}
+
+	if !passed {
+		return goOffsets{}, fmt.Errorf("Unsupported Go version: %s", goVersion)
 	}
 
 	writeOffset, err := getOffset(offsets, goWriteSymbol)
@@ -81,139 +63,10 @@ func findGoOffsets(filePath string) (goOffsets, error) {
 	return goOffsets{
 		GoWriteOffset: writeOffset,
 		GoReadOffset:  readOffset,
-		GoVersion:     goVersion,
-		Abi:           abi,
-		GoidOffset:    goidOffset,
-		GStructOffset: gStructOffset,
 	}, nil
 }
 
-func getSymbol(exe *elf.File, name string) *elf.Symbol {
-	symbols, err := exe.Symbols()
-	if err != nil {
-		return nil
-	}
-
-	for _, symbol := range symbols {
-		if symbol.Name == name {
-			s := symbol
-			return &s
-		}
-	}
-	return nil
-}
-
-func getGStructOffset(exe *elf.File) (gStructOffset uint64, err error) {
-	// This is a bit arcane. Essentially:
-	// - If the program is pure Go, it can do whatever it wants, and puts the G
-	//   pointer at %fs-8 on 64 bit.
-	// - %Gs is the index of private storage in GDT on 32 bit, and puts the G
-	//   pointer at -4(tls).
-	// - Otherwise, Go asks the external linker to place the G pointer by
-	//   emitting runtime.tlsg, a TLS symbol, which is relocated to the chosen
-	//   offset in libc's TLS block.
-	// - On ARM64 (but really, any architecture other than i386 and 86x64) the
-	//   offset is calculate using runtime.tls_g and the formula is different.
-
-	var tls *elf.Prog
-	for _, prog := range exe.Progs {
-		if prog.Type == elf.PT_TLS {
-			tls = prog
-			break
-		}
-	}
-
-	switch exe.Machine {
-	case elf.EM_X86_64, elf.EM_386:
-		tlsg := getSymbol(exe, "runtime.tlsg")
-		if tlsg == nil || tls == nil {
-			gStructOffset = ^uint64(PtrSize) + 1 //-ptrSize
-			return
-		}
-
-		// According to https://reviews.llvm.org/D61824, linkers must pad the actual
-		// size of the TLS segment to ensure that (tlsoffset%align) == (vaddr%align).
-		// This formula, copied from the lld code, matches that.
-		// https://github.com/llvm-mirror/lld/blob/9aef969544981d76bea8e4d1961d3a6980980ef9/ELF/InputSection.cpp#L643
-		memsz := tls.Memsz + (-tls.Vaddr-tls.Memsz)&(tls.Align-1)
-
-		// The TLS register points to the end of the TLS block, which is
-		// tls.Memsz long. runtime.tlsg is an offset from the beginning of that block.
-		gStructOffset = ^(memsz) + 1 + tlsg.Value // -tls.Memsz + tlsg.Value
-
-	case elf.EM_AARCH64:
-		tlsg := getSymbol(exe, "runtime.tls_g")
-		if tlsg == nil || tls == nil {
-			gStructOffset = 2 * uint64(PtrSize)
-			return
-		}
-
-		gStructOffset = tlsg.Value + uint64(PtrSize*2) + ((tls.Vaddr - uint64(PtrSize*2)) & (tls.Align - 1))
-
-	default:
-		// we should never get here
-		err = fmt.Errorf("architecture not supported")
-	}
-
-	return
-}
-
-func getGoidOffset(elfFile *elf.File) (goidOffset uint64, gStructOffset uint64, err error) {
-	var dwarfData *dwarf.Data
-	dwarfData, err = elfFile.DWARF()
-	if err != nil {
-		return
-	}
-
-	entryReader := dwarfData.Reader()
-
-	var runtimeGOffset uint64
-	var seenRuntimeG bool
-
-	for {
-		// Read all entries in sequence
-		var entry *dwarf.Entry
-		entry, err = entryReader.Next()
-		if err == io.EOF || entry == nil {
-			// We've reached the end of DWARF entries
-			break
-		}
-
-		// Check if this entry is a struct
-		if entry.Tag == dwarf.TagStructType {
-			// Go through fields
-			for _, field := range entry.Field {
-				if field.Attr == dwarf.AttrName {
-					val := field.Val.(string)
-					if val == "runtime.g" {
-						runtimeGOffset = uint64(entry.Offset)
-						seenRuntimeG = true
-					}
-				}
-			}
-		}
-
-		// Check if this entry is a struct member
-		if seenRuntimeG && entry.Tag == dwarf.TagMember {
-			// Go through fields
-			for _, field := range entry.Field {
-				if field.Attr == dwarf.AttrName {
-					val := field.Val.(string)
-					if val == "goid" {
-						goidOffset = uint64(entry.Offset) - runtimeGOffset - 0x4b
-						gStructOffset, err = getGStructOffset(elfFile)
-						return
-					}
-				}
-			}
-		}
-	}
-
-	err = fmt.Errorf("goid not found in DWARF")
-	return
-}
-
-func getOffsets(filePath string) (offsets map[string]*goExtendedOffset, goidOffset uint64, gStructOffset uint64, err error) {
+func getOffsets(filePath string) (offsets map[string]*goExtendedOffset, err error) {
 	var engine gapstone.Engine
 	switch runtime.GOARCH {
 	case "amd64":
@@ -251,13 +104,13 @@ func getOffsets(filePath string) (offsets map[string]*goExtendedOffset, goidOffs
 	}
 	defer fd.Close()
 
-	var elfFile *elf.File
-	elfFile, err = elf.NewFile(fd)
+	var se *elf.File
+	se, err = elf.NewFile(fd)
 	if err != nil {
 		return
 	}
 
-	textSection := elfFile.Section(".text")
+	textSection := se.Section(".text")
 	if textSection == nil {
 		err = fmt.Errorf("No text section")
 		return
@@ -271,7 +124,7 @@ func getOffsets(filePath string) (offsets map[string]*goExtendedOffset, goidOffs
 	}
 
 	var syms []elf.Symbol
-	syms, err = elfFile.Symbols()
+	syms, err = se.Symbols()
 	if err != nil {
 		return
 	}
@@ -279,7 +132,7 @@ func getOffsets(filePath string) (offsets map[string]*goExtendedOffset, goidOffs
 		offset := sym.Value
 
 		var lastProg *elf.Prog
-		for _, prog := range elfFile.Progs {
+		for _, prog := range se.Progs {
 			if prog.Vaddr <= sym.Value && sym.Value < (prog.Vaddr+prog.Memsz) {
 				offset = sym.Value - prog.Vaddr + prog.Off
 				lastProg = prog
@@ -336,8 +189,6 @@ func getOffsets(filePath string) (offsets map[string]*goExtendedOffset, goidOffs
 		offsets[sym.Name] = extendedOffset
 	}
 
-	goidOffset, gStructOffset, err = getGoidOffset(elfFile)
-
 	return
 }
 
@@ -378,7 +229,7 @@ func checkGoVersion(filePath string, offset *goExtendedOffset) (bool, string, er
 		return false, goVersionStr, err
 	}
 
-	goVersionConstraint, err := semver.NewConstraint(fmt.Sprintf(">= %s", minimumABIInternalGoVersion))
+	goVersionConstraint, err := semver.NewConstraint(fmt.Sprintf(">= %s", minimumSupportedGoVersion))
 	if err != nil {
 		return false, goVersionStr, err
 	}

tap/tlstapper/ssllib_hooks.go

@@ -14,8 +14,6 @@ type sslHooks struct {
 	sslWriteExRetProbe link.Link
 	sslReadExProbe     link.Link
 	sslReadExRetProbe  link.Link
-	tcpSendmsg         link.Link
-	tcpRecvmsg         link.Link
 }
 
 func (s *sslHooks) installUprobes(bpfObjects *tlsTapperObjects, sslLibraryPath string) error {
@@ -105,16 +103,6 @@ func (s *sslHooks) installSslHooks(bpfObjects *tlsTapperObjects, sslLibrary *lin
 		}
 	}
 
-	s.tcpSendmsg, err = link.Kprobe("tcp_sendmsg", bpfObjects.TcpSendmsg, nil)
-	if err != nil {
-		return errors.Wrap(err, 0)
-	}
-
-	s.tcpRecvmsg, err = link.Kprobe("tcp_recvmsg", bpfObjects.TcpRecvmsg, nil)
-	if err != nil {
-		return errors.Wrap(err, 0)
-	}
-
 	return nil
 }
 
@@ -161,17 +149,5 @@ func (s *sslHooks) close() []error {
 		}
 	}
 
-	if s.tcpSendmsg != nil {
-		if err := s.tcpSendmsg.Close(); err != nil {
-			returnValue = append(returnValue, err)
-		}
-	}
-
-	if s.tcpRecvmsg != nil {
-		if err := s.tcpRecvmsg.Close(); err != nil {
-			returnValue = append(returnValue, err)
-		}
-	}
-
 	return returnValue
 }

tap/tlstapper/syscall_hooks.go

@@ -17,37 +17,37 @@ type syscallHooks struct {
 func (s *syscallHooks) installSyscallHooks(bpfObjects *tlsTapperObjects) error {
 	var err error
 
-	s.sysEnterRead, err = link.Tracepoint("syscalls", "sys_enter_read", bpfObjects.SysEnterRead, nil)
+	s.sysEnterRead, err = link.Tracepoint("syscalls", "sys_enter_read", bpfObjects.SysEnterRead)
 
 	if err != nil {
 		return errors.Wrap(err, 0)
 	}
 
-	s.sysEnterWrite, err = link.Tracepoint("syscalls", "sys_enter_write", bpfObjects.SysEnterWrite, nil)
+	s.sysEnterWrite, err = link.Tracepoint("syscalls", "sys_enter_write", bpfObjects.SysEnterWrite)
 
 	if err != nil {
 		return errors.Wrap(err, 0)
 	}
 
-	s.sysEnterAccept4, err = link.Tracepoint("syscalls", "sys_enter_accept4", bpfObjects.SysEnterAccept4, nil)
+	s.sysEnterAccept4, err = link.Tracepoint("syscalls", "sys_enter_accept4", bpfObjects.SysEnterAccept4)
 
 	if err != nil {
 		return errors.Wrap(err, 0)
 	}
 
-	s.sysExitAccept4, err = link.Tracepoint("syscalls", "sys_exit_accept4", bpfObjects.SysExitAccept4, nil)
+	s.sysExitAccept4, err = link.Tracepoint("syscalls", "sys_exit_accept4", bpfObjects.SysExitAccept4)
 
 	if err != nil {
 		return errors.Wrap(err, 0)
 	}
 
-	s.sysEnterConnect, err = link.Tracepoint("syscalls", "sys_enter_connect", bpfObjects.SysEnterConnect, nil)
+	s.sysEnterConnect, err = link.Tracepoint("syscalls", "sys_enter_connect", bpfObjects.SysEnterConnect)
 
 	if err != nil {
 		return errors.Wrap(err, 0)
 	}
 
-	s.sysExitConnect, err = link.Tracepoint("syscalls", "sys_exit_connect", bpfObjects.SysExitConnect, nil)
+	s.sysExitConnect, err = link.Tracepoint("syscalls", "sys_exit_connect", bpfObjects.SysExitConnect)
 
 	if err != nil {
 		return errors.Wrap(err, 0)

tap/tlstapper/tls_poller.go

@@ -134,9 +134,14 @@ func (p *tlsPoller) pollChunksPerfBuffer(chunks chan<- *tlsTapperTlsChunk) {
 
 func (p *tlsPoller) handleTlsChunk(chunk *tlsTapperTlsChunk, extension *api.Extension, emitter api.Emitter,
 	options *api.TrafficFilteringOptions, streamsMap api.TcpStreamMap) error {
-	address, err := p.getAddressPair(chunk)
+	address, err := p.getSockfdAddressPair(chunk)
+
 	if err != nil {
-		return err
+		address, err = chunk.getAddressPair()
+
+		if err != nil {
+			return err
+		}
 	}
 
 	key := buildTlsKey(address)
@@ -156,22 +161,6 @@ func (p *tlsPoller) handleTlsChunk(chunk *tlsTapperTlsChunk, extension *api.Exte
 	return nil
 }
 
-func (p *tlsPoller) getAddressPair(chunk *tlsTapperTlsChunk) (addressPair, error) {
-	addrPairFromChunk, full := chunk.getAddressPair()
-	if full {
-		return addrPairFromChunk, nil
-	}
-
-	addrPairFromSockfd, err := p.getSockfdAddressPair(chunk)
-	if err == nil {
-		return addrPairFromSockfd, nil
-	} else {
-		logger.Log.Error("failed to get address from sock fd:", err)
-	}
-
-	return addrPairFromChunk, err
-}
-
 func (p *tlsPoller) startNewTlsReader(chunk *tlsTapperTlsChunk, address *addressPair, key string,
 	emitter api.Emitter, extension *api.Extension, options *api.TrafficFilteringOptions,
 	streamsMap api.TcpStreamMap) *tlsReader {

tap/tlstapper/tls_tapper.go

@@ -6,18 +6,13 @@ import (
 
 	"github.com/cilium/ebpf/rlimit"
 	"github.com/go-errors/errors"
-	"github.com/moby/moby/pkg/parsers/kernel"
 	"github.com/up9inc/mizu/logger"
 	"github.com/up9inc/mizu/tap/api"
 )
 
 const GlobalTapPid = 0
 
-// TODO: cilium/ebpf does not support .kconfig Therefore; for now, we build object files per kernel version.
-
-//go:generate go run github.com/cilium/ebpf/cmd/bpf2go@v0.9.0 -target $BPF_TARGET -cflags $BPF_CFLAGS -type tls_chunk -type goid_offsets tlsTapper bpf/tls_tapper.c
-
-//go:generate go run github.com/cilium/ebpf/cmd/bpf2go@v0.9.0 -target $BPF_TARGET -cflags "${BPF_CFLAGS} -DKERNEL_BEFORE_4_6" -type tls_chunk -type goid_offsets tlsTapper46 bpf/tls_tapper.c
+//go:generate go run github.com/cilium/ebpf/cmd/bpf2go@0d0727ef53e2f53b1731c73f4c61e0f58693083a -target $BPF_TARGET -cflags $BPF_CFLAGS -type tls_chunk tlsTapper bpf/tls_tapper.c
 
 type TlsTapper struct {
 	bpfObjects      tlsTapperObjects
@@ -32,30 +27,13 @@ type TlsTapper struct {
 func (t *TlsTapper) Init(chunksBufferSize int, logBufferSize int, procfs string, extension *api.Extension) error {
 	logger.Log.Infof("Initializing tls tapper (chunksSize: %d) (logSize: %d)", chunksBufferSize, logBufferSize)
 
-	var err error
-	err = setupRLimit()
-	if err != nil {
+	if err := setupRLimit(); err != nil {
 		return err
 	}
 
-	var kernelVersion *kernel.VersionInfo
-	kernelVersion, err = kernel.GetKernelVersion()
-	if err != nil {
-		return err
-	}
-
-	logger.Log.Infof("Detected Linux kernel version: %s", kernelVersion)
-
 	t.bpfObjects = tlsTapperObjects{}
-	// TODO: cilium/ebpf does not support .kconfig Therefore; for now, we load object files according to kernel version.
-	if kernel.CompareKernelVersion(*kernelVersion, kernel.VersionInfo{Kernel: 4, Major: 6, Minor: 0}) < 1 {
-		if err := loadTlsTapper46Objects(&t.bpfObjects, nil); err != nil {
-			return errors.Wrap(err, 0)
-		}
-	} else {
-		if err := loadTlsTapperObjects(&t.bpfObjects, nil); err != nil {
-			return errors.Wrap(err, 0)
-		}
+	if err := loadTlsTapperObjects(&t.bpfObjects, nil); err != nil {
+		return errors.Wrap(err, 0)
 	}
 
 	t.syscallHooks = syscallHooks{}
@@ -70,6 +48,7 @@ func (t *TlsTapper) Init(chunksBufferSize int, logBufferSize int, procfs string,
 		return err
 	}
 
+	var err error
 	t.poller, err = newTlsPoller(t, extension, procfs)
 
 	if err != nil {

tap/tlstapper/tlstapper46_bpfel_arm64.go

@@ -1,244 +0,0 @@
-// Code generated by bpf2go; DO NOT EDIT.
-//go:build arm64
-// +build arm64
-
-package tlstapper
-
-import (
-	"bytes"
-	_ "embed"
-	"fmt"
-	"io"
-
-	"github.com/cilium/ebpf"
-)
-
-type tlsTapper46GoidOffsets struct {
-	G_addrOffset uint64
-	GoidOffset   uint64
-}
-
-type tlsTapper46TlsChunk struct {
-	Pid         uint32
-	Tgid        uint32
-	Len         uint32
-	Start       uint32
-	Recorded    uint32
-	Fd          uint32
-	Flags       uint32
-	AddressInfo struct {
-		Mode  int32
-		Saddr uint32
-		Daddr uint32
-		Sport uint16
-		Dport uint16
-	}
-	Data [4096]uint8
-}
-
-// loadTlsTapper46 returns the embedded CollectionSpec for tlsTapper46.
-func loadTlsTapper46() (*ebpf.CollectionSpec, error) {
-	reader := bytes.NewReader(_TlsTapper46Bytes)
-	spec, err := ebpf.LoadCollectionSpecFromReader(reader)
-	if err != nil {
-		return nil, fmt.Errorf("can't load tlsTapper46: %w", err)
-	}
-
-	return spec, err
-}
-
-// loadTlsTapper46Objects loads tlsTapper46 and converts it into a struct.
-//
-// The following types are suitable as obj argument:
-//
-//     *tlsTapper46Objects
-//     *tlsTapper46Programs
-//     *tlsTapper46Maps
-//
-// See ebpf.CollectionSpec.LoadAndAssign documentation for details.
-func loadTlsTapper46Objects(obj interface{}, opts *ebpf.CollectionOptions) error {
-	spec, err := loadTlsTapper46()
-	if err != nil {
-		return err
-	}
-
-	return spec.LoadAndAssign(obj, opts)
-}
-
-// tlsTapper46Specs contains maps and programs before they are loaded into the kernel.
-//
-// It can be passed ebpf.CollectionSpec.Assign.
-type tlsTapper46Specs struct {
-	tlsTapper46ProgramSpecs
-	tlsTapper46MapSpecs
-}
-
-// tlsTapper46Specs contains programs before they are loaded into the kernel.
-//
-// It can be passed ebpf.CollectionSpec.Assign.
-type tlsTapper46ProgramSpecs struct {
-	GoCryptoTlsAbi0Read           *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_read"`
-	GoCryptoTlsAbi0ReadEx         *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_read_ex"`
-	GoCryptoTlsAbi0Write          *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_write"`
-	GoCryptoTlsAbi0WriteEx        *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_write_ex"`
-	GoCryptoTlsAbiInternalRead    *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_read"`
-	GoCryptoTlsAbiInternalReadEx  *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_read_ex"`
-	GoCryptoTlsAbiInternalWrite   *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_write"`
-	GoCryptoTlsAbiInternalWriteEx *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_write_ex"`
-	SslRead                       *ebpf.ProgramSpec `ebpf:"ssl_read"`
-	SslReadEx                     *ebpf.ProgramSpec `ebpf:"ssl_read_ex"`
-	SslRetRead                    *ebpf.ProgramSpec `ebpf:"ssl_ret_read"`
-	SslRetReadEx                  *ebpf.ProgramSpec `ebpf:"ssl_ret_read_ex"`
-	SslRetWrite                   *ebpf.ProgramSpec `ebpf:"ssl_ret_write"`
-	SslRetWriteEx                 *ebpf.ProgramSpec `ebpf:"ssl_ret_write_ex"`
-	SslWrite                      *ebpf.ProgramSpec `ebpf:"ssl_write"`
-	SslWriteEx                    *ebpf.ProgramSpec `ebpf:"ssl_write_ex"`
-	SysEnterAccept4               *ebpf.ProgramSpec `ebpf:"sys_enter_accept4"`
-	SysEnterConnect               *ebpf.ProgramSpec `ebpf:"sys_enter_connect"`
-	SysEnterRead                  *ebpf.ProgramSpec `ebpf:"sys_enter_read"`
-	SysEnterWrite                 *ebpf.ProgramSpec `ebpf:"sys_enter_write"`
-	SysExitAccept4                *ebpf.ProgramSpec `ebpf:"sys_exit_accept4"`
-	SysExitConnect                *ebpf.ProgramSpec `ebpf:"sys_exit_connect"`
-	TcpRecvmsg                    *ebpf.ProgramSpec `ebpf:"tcp_recvmsg"`
-	TcpSendmsg                    *ebpf.ProgramSpec `ebpf:"tcp_sendmsg"`
-}
-
-// tlsTapper46MapSpecs contains maps before they are loaded into the kernel.
-//
-// It can be passed ebpf.CollectionSpec.Assign.
-type tlsTapper46MapSpecs struct {
-	AcceptSyscallContext *ebpf.MapSpec `ebpf:"accept_syscall_context"`
-	ChunksBuffer         *ebpf.MapSpec `ebpf:"chunks_buffer"`
-	ConnectSyscallInfo   *ebpf.MapSpec `ebpf:"connect_syscall_info"`
-	FileDescriptorToIpv4 *ebpf.MapSpec `ebpf:"file_descriptor_to_ipv4"`
-	GoReadContext        *ebpf.MapSpec `ebpf:"go_read_context"`
-	GoWriteContext       *ebpf.MapSpec `ebpf:"go_write_context"`
-	GoidOffsetsMap       *ebpf.MapSpec `ebpf:"goid_offsets_map"`
-	Heap                 *ebpf.MapSpec `ebpf:"heap"`
-	LogBuffer            *ebpf.MapSpec `ebpf:"log_buffer"`
-	OpensslReadContext   *ebpf.MapSpec `ebpf:"openssl_read_context"`
-	OpensslWriteContext  *ebpf.MapSpec `ebpf:"openssl_write_context"`
-	PidsMap              *ebpf.MapSpec `ebpf:"pids_map"`
-}
-
-// tlsTapper46Objects contains all objects after they have been loaded into the kernel.
-//
-// It can be passed to loadTlsTapper46Objects or ebpf.CollectionSpec.LoadAndAssign.
-type tlsTapper46Objects struct {
-	tlsTapper46Programs
-	tlsTapper46Maps
-}
-
-func (o *tlsTapper46Objects) Close() error {
-	return _TlsTapper46Close(
-		&o.tlsTapper46Programs,
-		&o.tlsTapper46Maps,
-	)
-}
-
-// tlsTapper46Maps contains all maps after they have been loaded into the kernel.
-//
-// It can be passed to loadTlsTapper46Objects or ebpf.CollectionSpec.LoadAndAssign.
-type tlsTapper46Maps struct {
-	AcceptSyscallContext *ebpf.Map `ebpf:"accept_syscall_context"`
-	ChunksBuffer         *ebpf.Map `ebpf:"chunks_buffer"`
-	ConnectSyscallInfo   *ebpf.Map `ebpf:"connect_syscall_info"`
-	FileDescriptorToIpv4 *ebpf.Map `ebpf:"file_descriptor_to_ipv4"`
-	GoReadContext        *ebpf.Map `ebpf:"go_read_context"`
-	GoWriteContext       *ebpf.Map `ebpf:"go_write_context"`
-	GoidOffsetsMap       *ebpf.Map `ebpf:"goid_offsets_map"`
-	Heap                 *ebpf.Map `ebpf:"heap"`
-	LogBuffer            *ebpf.Map `ebpf:"log_buffer"`
-	OpensslReadContext   *ebpf.Map `ebpf:"openssl_read_context"`
-	OpensslWriteContext  *ebpf.Map `ebpf:"openssl_write_context"`
-	PidsMap              *ebpf.Map `ebpf:"pids_map"`
-}
-
-func (m *tlsTapper46Maps) Close() error {
-	return _TlsTapper46Close(
-		m.AcceptSyscallContext,
-		m.ChunksBuffer,
-		m.ConnectSyscallInfo,
-		m.FileDescriptorToIpv4,
-		m.GoReadContext,
-		m.GoWriteContext,
-		m.GoidOffsetsMap,
-		m.Heap,
-		m.LogBuffer,
-		m.OpensslReadContext,
-		m.OpensslWriteContext,
-		m.PidsMap,
-	)
-}
-
-// tlsTapper46Programs contains all programs after they have been loaded into the kernel.
-//
-// It can be passed to loadTlsTapper46Objects or ebpf.CollectionSpec.LoadAndAssign.
-type tlsTapper46Programs struct {
-	GoCryptoTlsAbi0Read           *ebpf.Program `ebpf:"go_crypto_tls_abi0_read"`
-	GoCryptoTlsAbi0ReadEx         *ebpf.Program `ebpf:"go_crypto_tls_abi0_read_ex"`
-	GoCryptoTlsAbi0Write          *ebpf.Program `ebpf:"go_crypto_tls_abi0_write"`
-	GoCryptoTlsAbi0WriteEx        *ebpf.Program `ebpf:"go_crypto_tls_abi0_write_ex"`
-	GoCryptoTlsAbiInternalRead    *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_read"`
-	GoCryptoTlsAbiInternalReadEx  *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_read_ex"`
-	GoCryptoTlsAbiInternalWrite   *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_write"`
-	GoCryptoTlsAbiInternalWriteEx *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_write_ex"`
-	SslRead                       *ebpf.Program `ebpf:"ssl_read"`
-	SslReadEx                     *ebpf.Program `ebpf:"ssl_read_ex"`
-	SslRetRead                    *ebpf.Program `ebpf:"ssl_ret_read"`
-	SslRetReadEx                  *ebpf.Program `ebpf:"ssl_ret_read_ex"`
-	SslRetWrite                   *ebpf.Program `ebpf:"ssl_ret_write"`
-	SslRetWriteEx                 *ebpf.Program `ebpf:"ssl_ret_write_ex"`
-	SslWrite                      *ebpf.Program `ebpf:"ssl_write"`
-	SslWriteEx                    *ebpf.Program `ebpf:"ssl_write_ex"`
-	SysEnterAccept4               *ebpf.Program `ebpf:"sys_enter_accept4"`
-	SysEnterConnect               *ebpf.Program `ebpf:"sys_enter_connect"`
-	SysEnterRead                  *ebpf.Program `ebpf:"sys_enter_read"`
-	SysEnterWrite                 *ebpf.Program `ebpf:"sys_enter_write"`
-	SysExitAccept4                *ebpf.Program `ebpf:"sys_exit_accept4"`
-	SysExitConnect                *ebpf.Program `ebpf:"sys_exit_connect"`
-	TcpRecvmsg                    *ebpf.Program `ebpf:"tcp_recvmsg"`
-	TcpSendmsg                    *ebpf.Program `ebpf:"tcp_sendmsg"`
-}
-
-func (p *tlsTapper46Programs) Close() error {
-	return _TlsTapper46Close(
-		p.GoCryptoTlsAbi0Read,
-		p.GoCryptoTlsAbi0ReadEx,
-		p.GoCryptoTlsAbi0Write,
-		p.GoCryptoTlsAbi0WriteEx,
-		p.GoCryptoTlsAbiInternalRead,
-		p.GoCryptoTlsAbiInternalReadEx,
-		p.GoCryptoTlsAbiInternalWrite,
-		p.GoCryptoTlsAbiInternalWriteEx,
-		p.SslRead,
-		p.SslReadEx,
-		p.SslRetRead,
-		p.SslRetReadEx,
-		p.SslRetWrite,
-		p.SslRetWriteEx,
-		p.SslWrite,
-		p.SslWriteEx,
-		p.SysEnterAccept4,
-		p.SysEnterConnect,
-		p.SysEnterRead,
-		p.SysEnterWrite,
-		p.SysExitAccept4,
-		p.SysExitConnect,
-		p.TcpRecvmsg,
-		p.TcpSendmsg,
-	)
-}
-
-func _TlsTapper46Close(closers ...io.Closer) error {
-	for _, closer := range closers {
-		if err := closer.Close(); err != nil {
-			return err
-		}
-	}
-	return nil
-}
-
-// Do not access this directly.
-//go:embed tlstapper46_bpfel_arm64.o
-var _TlsTapper46Bytes []byte

tap/tlstapper/tlstapper46_bpfel_x86.go

@@ -1,244 +0,0 @@
-// Code generated by bpf2go; DO NOT EDIT.
-//go:build 386 || amd64
-// +build 386 amd64
-
-package tlstapper
-
-import (
-	"bytes"
-	_ "embed"
-	"fmt"
-	"io"
-
-	"github.com/cilium/ebpf"
-)
-
-type tlsTapper46GoidOffsets struct {
-	G_addrOffset uint64
-	GoidOffset   uint64
-}
-
-type tlsTapper46TlsChunk struct {
-	Pid         uint32
-	Tgid        uint32
-	Len         uint32
-	Start       uint32
-	Recorded    uint32
-	Fd          uint32
-	Flags       uint32
-	AddressInfo struct {
-		Mode  int32
-		Saddr uint32
-		Daddr uint32
-		Sport uint16
-		Dport uint16
-	}
-	Data [4096]uint8
-}
-
-// loadTlsTapper46 returns the embedded CollectionSpec for tlsTapper46.
-func loadTlsTapper46() (*ebpf.CollectionSpec, error) {
-	reader := bytes.NewReader(_TlsTapper46Bytes)
-	spec, err := ebpf.LoadCollectionSpecFromReader(reader)
-	if err != nil {
-		return nil, fmt.Errorf("can't load tlsTapper46: %w", err)
-	}
-
-	return spec, err
-}
-
-// loadTlsTapper46Objects loads tlsTapper46 and converts it into a struct.
-//
-// The following types are suitable as obj argument:
-//
-//     *tlsTapper46Objects
-//     *tlsTapper46Programs
-//     *tlsTapper46Maps
-//
-// See ebpf.CollectionSpec.LoadAndAssign documentation for details.
-func loadTlsTapper46Objects(obj interface{}, opts *ebpf.CollectionOptions) error {
-	spec, err := loadTlsTapper46()
-	if err != nil {
-		return err
-	}
-
-	return spec.LoadAndAssign(obj, opts)
-}
-
-// tlsTapper46Specs contains maps and programs before they are loaded into the kernel.
-//
-// It can be passed ebpf.CollectionSpec.Assign.
-type tlsTapper46Specs struct {
-	tlsTapper46ProgramSpecs
-	tlsTapper46MapSpecs
-}
-
-// tlsTapper46Specs contains programs before they are loaded into the kernel.
-//
-// It can be passed ebpf.CollectionSpec.Assign.
-type tlsTapper46ProgramSpecs struct {
-	GoCryptoTlsAbi0Read           *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_read"`
-	GoCryptoTlsAbi0ReadEx         *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_read_ex"`
-	GoCryptoTlsAbi0Write          *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_write"`
-	GoCryptoTlsAbi0WriteEx        *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_write_ex"`
-	GoCryptoTlsAbiInternalRead    *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_read"`
-	GoCryptoTlsAbiInternalReadEx  *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_read_ex"`
-	GoCryptoTlsAbiInternalWrite   *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_write"`
-	GoCryptoTlsAbiInternalWriteEx *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_write_ex"`
-	SslRead                       *ebpf.ProgramSpec `ebpf:"ssl_read"`
-	SslReadEx                     *ebpf.ProgramSpec `ebpf:"ssl_read_ex"`
-	SslRetRead                    *ebpf.ProgramSpec `ebpf:"ssl_ret_read"`
-	SslRetReadEx                  *ebpf.ProgramSpec `ebpf:"ssl_ret_read_ex"`
-	SslRetWrite                   *ebpf.ProgramSpec `ebpf:"ssl_ret_write"`
-	SslRetWriteEx                 *ebpf.ProgramSpec `ebpf:"ssl_ret_write_ex"`
-	SslWrite                      *ebpf.ProgramSpec `ebpf:"ssl_write"`
-	SslWriteEx                    *ebpf.ProgramSpec `ebpf:"ssl_write_ex"`
-	SysEnterAccept4               *ebpf.ProgramSpec `ebpf:"sys_enter_accept4"`
-	SysEnterConnect               *ebpf.ProgramSpec `ebpf:"sys_enter_connect"`
-	SysEnterRead                  *ebpf.ProgramSpec `ebpf:"sys_enter_read"`
-	SysEnterWrite                 *ebpf.ProgramSpec `ebpf:"sys_enter_write"`
-	SysExitAccept4                *ebpf.ProgramSpec `ebpf:"sys_exit_accept4"`
-	SysExitConnect                *ebpf.ProgramSpec `ebpf:"sys_exit_connect"`
-	TcpRecvmsg                    *ebpf.ProgramSpec `ebpf:"tcp_recvmsg"`
-	TcpSendmsg                    *ebpf.ProgramSpec `ebpf:"tcp_sendmsg"`
-}
-
-// tlsTapper46MapSpecs contains maps before they are loaded into the kernel.
-//
-// It can be passed ebpf.CollectionSpec.Assign.
-type tlsTapper46MapSpecs struct {
-	AcceptSyscallContext *ebpf.MapSpec `ebpf:"accept_syscall_context"`
-	ChunksBuffer         *ebpf.MapSpec `ebpf:"chunks_buffer"`
-	ConnectSyscallInfo   *ebpf.MapSpec `ebpf:"connect_syscall_info"`
-	FileDescriptorToIpv4 *ebpf.MapSpec `ebpf:"file_descriptor_to_ipv4"`
-	GoReadContext        *ebpf.MapSpec `ebpf:"go_read_context"`
-	GoWriteContext       *ebpf.MapSpec `ebpf:"go_write_context"`
-	GoidOffsetsMap       *ebpf.MapSpec `ebpf:"goid_offsets_map"`
-	Heap                 *ebpf.MapSpec `ebpf:"heap"`
-	LogBuffer            *ebpf.MapSpec `ebpf:"log_buffer"`
-	OpensslReadContext   *ebpf.MapSpec `ebpf:"openssl_read_context"`
-	OpensslWriteContext  *ebpf.MapSpec `ebpf:"openssl_write_context"`
-	PidsMap              *ebpf.MapSpec `ebpf:"pids_map"`
-}
-
-// tlsTapper46Objects contains all objects after they have been loaded into the kernel.
-//
-// It can be passed to loadTlsTapper46Objects or ebpf.CollectionSpec.LoadAndAssign.
-type tlsTapper46Objects struct {
-	tlsTapper46Programs
-	tlsTapper46Maps
-}
-
-func (o *tlsTapper46Objects) Close() error {
-	return _TlsTapper46Close(
-		&o.tlsTapper46Programs,
-		&o.tlsTapper46Maps,
-	)
-}
-
-// tlsTapper46Maps contains all maps after they have been loaded into the kernel.
-//
-// It can be passed to loadTlsTapper46Objects or ebpf.CollectionSpec.LoadAndAssign.
-type tlsTapper46Maps struct {
-	AcceptSyscallContext *ebpf.Map `ebpf:"accept_syscall_context"`
-	ChunksBuffer         *ebpf.Map `ebpf:"chunks_buffer"`
-	ConnectSyscallInfo   *ebpf.Map `ebpf:"connect_syscall_info"`
-	FileDescriptorToIpv4 *ebpf.Map `ebpf:"file_descriptor_to_ipv4"`
-	GoReadContext        *ebpf.Map `ebpf:"go_read_context"`
-	GoWriteContext       *ebpf.Map `ebpf:"go_write_context"`
-	GoidOffsetsMap       *ebpf.Map `ebpf:"goid_offsets_map"`
-	Heap                 *ebpf.Map `ebpf:"heap"`
-	LogBuffer            *ebpf.Map `ebpf:"log_buffer"`
-	OpensslReadContext   *ebpf.Map `ebpf:"openssl_read_context"`
-	OpensslWriteContext  *ebpf.Map `ebpf:"openssl_write_context"`
-	PidsMap              *ebpf.Map `ebpf:"pids_map"`
-}
-
-func (m *tlsTapper46Maps) Close() error {
-	return _TlsTapper46Close(
-		m.AcceptSyscallContext,
-		m.ChunksBuffer,
-		m.ConnectSyscallInfo,
-		m.FileDescriptorToIpv4,
-		m.GoReadContext,
-		m.GoWriteContext,
-		m.GoidOffsetsMap,
-		m.Heap,
-		m.LogBuffer,
-		m.OpensslReadContext,
-		m.OpensslWriteContext,
-		m.PidsMap,
-	)
-}
-
-// tlsTapper46Programs contains all programs after they have been loaded into the kernel.
-//
-// It can be passed to loadTlsTapper46Objects or ebpf.CollectionSpec.LoadAndAssign.
-type tlsTapper46Programs struct {
-	GoCryptoTlsAbi0Read           *ebpf.Program `ebpf:"go_crypto_tls_abi0_read"`
-	GoCryptoTlsAbi0ReadEx         *ebpf.Program `ebpf:"go_crypto_tls_abi0_read_ex"`
-	GoCryptoTlsAbi0Write          *ebpf.Program `ebpf:"go_crypto_tls_abi0_write"`
-	GoCryptoTlsAbi0WriteEx        *ebpf.Program `ebpf:"go_crypto_tls_abi0_write_ex"`
-	GoCryptoTlsAbiInternalRead    *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_read"`
-	GoCryptoTlsAbiInternalReadEx  *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_read_ex"`
-	GoCryptoTlsAbiInternalWrite   *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_write"`
-	GoCryptoTlsAbiInternalWriteEx *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_write_ex"`
-	SslRead                       *ebpf.Program `ebpf:"ssl_read"`
-	SslReadEx                     *ebpf.Program `ebpf:"ssl_read_ex"`
-	SslRetRead                    *ebpf.Program `ebpf:"ssl_ret_read"`
-	SslRetReadEx                  *ebpf.Program `ebpf:"ssl_ret_read_ex"`
-	SslRetWrite                   *ebpf.Program `ebpf:"ssl_ret_write"`
-	SslRetWriteEx                 *ebpf.Program `ebpf:"ssl_ret_write_ex"`
-	SslWrite                      *ebpf.Program `ebpf:"ssl_write"`
-	SslWriteEx                    *ebpf.Program `ebpf:"ssl_write_ex"`
-	SysEnterAccept4               *ebpf.Program `ebpf:"sys_enter_accept4"`
-	SysEnterConnect               *ebpf.Program `ebpf:"sys_enter_connect"`
-	SysEnterRead                  *ebpf.Program `ebpf:"sys_enter_read"`
-	SysEnterWrite                 *ebpf.Program `ebpf:"sys_enter_write"`
-	SysExitAccept4                *ebpf.Program `ebpf:"sys_exit_accept4"`
-	SysExitConnect                *ebpf.Program `ebpf:"sys_exit_connect"`
-	TcpRecvmsg                    *ebpf.Program `ebpf:"tcp_recvmsg"`
-	TcpSendmsg                    *ebpf.Program `ebpf:"tcp_sendmsg"`
-}
-
-func (p *tlsTapper46Programs) Close() error {
-	return _TlsTapper46Close(
-		p.GoCryptoTlsAbi0Read,
-		p.GoCryptoTlsAbi0ReadEx,
-		p.GoCryptoTlsAbi0Write,
-		p.GoCryptoTlsAbi0WriteEx,
-		p.GoCryptoTlsAbiInternalRead,
-		p.GoCryptoTlsAbiInternalReadEx,
-		p.GoCryptoTlsAbiInternalWrite,
-		p.GoCryptoTlsAbiInternalWriteEx,
-		p.SslRead,
-		p.SslReadEx,
-		p.SslRetRead,
-		p.SslRetReadEx,
-		p.SslRetWrite,
-		p.SslRetWriteEx,
-		p.SslWrite,
-		p.SslWriteEx,
-		p.SysEnterAccept4,
-		p.SysEnterConnect,
-		p.SysEnterRead,
-		p.SysEnterWrite,
-		p.SysExitAccept4,
-		p.SysExitConnect,
-		p.TcpRecvmsg,
-		p.TcpSendmsg,
-	)
-}
-
-func _TlsTapper46Close(closers ...io.Closer) error {
-	for _, closer := range closers {
-		if err := closer.Close(); err != nil {
-			return err
-		}
-	}
-	return nil
-}
-
-// Do not access this directly.
-//go:embed tlstapper46_bpfel_x86.o
-var _TlsTapper46Bytes []byte

tap/tlstapper/tlstapper_bpfel_arm64.go

@@ -13,27 +13,16 @@ import (
 	"github.com/cilium/ebpf"
 )
 
-type tlsTapperGoidOffsets struct {
-	G_addrOffset uint64
-	GoidOffset   uint64
-}
-
 type tlsTapperTlsChunk struct {
-	Pid         uint32
-	Tgid        uint32
-	Len         uint32
-	Start       uint32
-	Recorded    uint32
-	Fd          uint32
-	Flags       uint32
-	AddressInfo struct {
-		Mode  int32
-		Saddr uint32
-		Daddr uint32
-		Sport uint16
-		Dport uint16
-	}
-	Data [4096]uint8
+	Pid      uint32
+	Tgid     uint32
+	Len      uint32
+	Start    uint32
+	Recorded uint32
+	Fd       uint32
+	Flags    uint32
+	Address  [16]uint8
+	Data     [4096]uint8
 }
 
 // loadTlsTapper returns the embedded CollectionSpec for tlsTapper.
@@ -77,30 +66,24 @@ type tlsTapperSpecs struct {
 //
 // It can be passed ebpf.CollectionSpec.Assign.
 type tlsTapperProgramSpecs struct {
-	GoCryptoTlsAbi0Read           *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_read"`
-	GoCryptoTlsAbi0ReadEx         *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_read_ex"`
-	GoCryptoTlsAbi0Write          *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_write"`
-	GoCryptoTlsAbi0WriteEx        *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_write_ex"`
-	GoCryptoTlsAbiInternalRead    *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_read"`
-	GoCryptoTlsAbiInternalReadEx  *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_read_ex"`
-	GoCryptoTlsAbiInternalWrite   *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_write"`
-	GoCryptoTlsAbiInternalWriteEx *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_write_ex"`
-	SslRead                       *ebpf.ProgramSpec `ebpf:"ssl_read"`
-	SslReadEx                     *ebpf.ProgramSpec `ebpf:"ssl_read_ex"`
-	SslRetRead                    *ebpf.ProgramSpec `ebpf:"ssl_ret_read"`
-	SslRetReadEx                  *ebpf.ProgramSpec `ebpf:"ssl_ret_read_ex"`
-	SslRetWrite                   *ebpf.ProgramSpec `ebpf:"ssl_ret_write"`
-	SslRetWriteEx                 *ebpf.ProgramSpec `ebpf:"ssl_ret_write_ex"`
-	SslWrite                      *ebpf.ProgramSpec `ebpf:"ssl_write"`
-	SslWriteEx                    *ebpf.ProgramSpec `ebpf:"ssl_write_ex"`
-	SysEnterAccept4               *ebpf.ProgramSpec `ebpf:"sys_enter_accept4"`
-	SysEnterConnect               *ebpf.ProgramSpec `ebpf:"sys_enter_connect"`
-	SysEnterRead                  *ebpf.ProgramSpec `ebpf:"sys_enter_read"`
-	SysEnterWrite                 *ebpf.ProgramSpec `ebpf:"sys_enter_write"`
-	SysExitAccept4                *ebpf.ProgramSpec `ebpf:"sys_exit_accept4"`
-	SysExitConnect                *ebpf.ProgramSpec `ebpf:"sys_exit_connect"`
-	TcpRecvmsg                    *ebpf.ProgramSpec `ebpf:"tcp_recvmsg"`
-	TcpSendmsg                    *ebpf.ProgramSpec `ebpf:"tcp_sendmsg"`
+	GoCryptoTlsRead    *ebpf.ProgramSpec `ebpf:"go_crypto_tls_read"`
+	GoCryptoTlsReadEx  *ebpf.ProgramSpec `ebpf:"go_crypto_tls_read_ex"`
+	GoCryptoTlsWrite   *ebpf.ProgramSpec `ebpf:"go_crypto_tls_write"`
+	GoCryptoTlsWriteEx *ebpf.ProgramSpec `ebpf:"go_crypto_tls_write_ex"`
+	SslRead            *ebpf.ProgramSpec `ebpf:"ssl_read"`
+	SslReadEx          *ebpf.ProgramSpec `ebpf:"ssl_read_ex"`
+	SslRetRead         *ebpf.ProgramSpec `ebpf:"ssl_ret_read"`
+	SslRetReadEx       *ebpf.ProgramSpec `ebpf:"ssl_ret_read_ex"`
+	SslRetWrite        *ebpf.ProgramSpec `ebpf:"ssl_ret_write"`
+	SslRetWriteEx      *ebpf.ProgramSpec `ebpf:"ssl_ret_write_ex"`
+	SslWrite           *ebpf.ProgramSpec `ebpf:"ssl_write"`
+	SslWriteEx         *ebpf.ProgramSpec `ebpf:"ssl_write_ex"`
+	SysEnterAccept4    *ebpf.ProgramSpec `ebpf:"sys_enter_accept4"`
+	SysEnterConnect    *ebpf.ProgramSpec `ebpf:"sys_enter_connect"`
+	SysEnterRead       *ebpf.ProgramSpec `ebpf:"sys_enter_read"`
+	SysEnterWrite      *ebpf.ProgramSpec `ebpf:"sys_enter_write"`
+	SysExitAccept4     *ebpf.ProgramSpec `ebpf:"sys_exit_accept4"`
+	SysExitConnect     *ebpf.ProgramSpec `ebpf:"sys_exit_connect"`
 }
 
 // tlsTapperMapSpecs contains maps before they are loaded into the kernel.
@@ -113,7 +96,6 @@ type tlsTapperMapSpecs struct {
 	FileDescriptorToIpv4 *ebpf.MapSpec `ebpf:"file_descriptor_to_ipv4"`
 	GoReadContext        *ebpf.MapSpec `ebpf:"go_read_context"`
 	GoWriteContext       *ebpf.MapSpec `ebpf:"go_write_context"`
-	GoidOffsetsMap       *ebpf.MapSpec `ebpf:"goid_offsets_map"`
 	Heap                 *ebpf.MapSpec `ebpf:"heap"`
 	LogBuffer            *ebpf.MapSpec `ebpf:"log_buffer"`
 	OpensslReadContext   *ebpf.MapSpec `ebpf:"openssl_read_context"`
@@ -146,7 +128,6 @@ type tlsTapperMaps struct {
 	FileDescriptorToIpv4 *ebpf.Map `ebpf:"file_descriptor_to_ipv4"`
 	GoReadContext        *ebpf.Map `ebpf:"go_read_context"`
 	GoWriteContext       *ebpf.Map `ebpf:"go_write_context"`
-	GoidOffsetsMap       *ebpf.Map `ebpf:"goid_offsets_map"`
 	Heap                 *ebpf.Map `ebpf:"heap"`
 	LogBuffer            *ebpf.Map `ebpf:"log_buffer"`
 	OpensslReadContext   *ebpf.Map `ebpf:"openssl_read_context"`
@@ -162,7 +143,6 @@ func (m *tlsTapperMaps) Close() error {
 		m.FileDescriptorToIpv4,
 		m.GoReadContext,
 		m.GoWriteContext,
-		m.GoidOffsetsMap,
 		m.Heap,
 		m.LogBuffer,
 		m.OpensslReadContext,
@@ -175,42 +155,32 @@ func (m *tlsTapperMaps) Close() error {
 //
 // It can be passed to loadTlsTapperObjects or ebpf.CollectionSpec.LoadAndAssign.
 type tlsTapperPrograms struct {
-	GoCryptoTlsAbi0Read           *ebpf.Program `ebpf:"go_crypto_tls_abi0_read"`
-	GoCryptoTlsAbi0ReadEx         *ebpf.Program `ebpf:"go_crypto_tls_abi0_read_ex"`
-	GoCryptoTlsAbi0Write          *ebpf.Program `ebpf:"go_crypto_tls_abi0_write"`
-	GoCryptoTlsAbi0WriteEx        *ebpf.Program `ebpf:"go_crypto_tls_abi0_write_ex"`
-	GoCryptoTlsAbiInternalRead    *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_read"`
-	GoCryptoTlsAbiInternalReadEx  *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_read_ex"`
-	GoCryptoTlsAbiInternalWrite   *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_write"`
-	GoCryptoTlsAbiInternalWriteEx *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_write_ex"`
-	SslRead                       *ebpf.Program `ebpf:"ssl_read"`
-	SslReadEx                     *ebpf.Program `ebpf:"ssl_read_ex"`
-	SslRetRead                    *ebpf.Program `ebpf:"ssl_ret_read"`
-	SslRetReadEx                  *ebpf.Program `ebpf:"ssl_ret_read_ex"`
-	SslRetWrite                   *ebpf.Program `ebpf:"ssl_ret_write"`
-	SslRetWriteEx                 *ebpf.Program `ebpf:"ssl_ret_write_ex"`
-	SslWrite                      *ebpf.Program `ebpf:"ssl_write"`
-	SslWriteEx                    *ebpf.Program `ebpf:"ssl_write_ex"`
-	SysEnterAccept4               *ebpf.Program `ebpf:"sys_enter_accept4"`
-	SysEnterConnect               *ebpf.Program `ebpf:"sys_enter_connect"`
-	SysEnterRead                  *ebpf.Program `ebpf:"sys_enter_read"`
-	SysEnterWrite                 *ebpf.Program `ebpf:"sys_enter_write"`
-	SysExitAccept4                *ebpf.Program `ebpf:"sys_exit_accept4"`
-	SysExitConnect                *ebpf.Program `ebpf:"sys_exit_connect"`
-	TcpRecvmsg                    *ebpf.Program `ebpf:"tcp_recvmsg"`
-	TcpSendmsg                    *ebpf.Program `ebpf:"tcp_sendmsg"`
+	GoCryptoTlsRead    *ebpf.Program `ebpf:"go_crypto_tls_read"`
+	GoCryptoTlsReadEx  *ebpf.Program `ebpf:"go_crypto_tls_read_ex"`
+	GoCryptoTlsWrite   *ebpf.Program `ebpf:"go_crypto_tls_write"`
+	GoCryptoTlsWriteEx *ebpf.Program `ebpf:"go_crypto_tls_write_ex"`
+	SslRead            *ebpf.Program `ebpf:"ssl_read"`
+	SslReadEx          *ebpf.Program `ebpf:"ssl_read_ex"`
+	SslRetRead         *ebpf.Program `ebpf:"ssl_ret_read"`
+	SslRetReadEx       *ebpf.Program `ebpf:"ssl_ret_read_ex"`
+	SslRetWrite        *ebpf.Program `ebpf:"ssl_ret_write"`
+	SslRetWriteEx      *ebpf.Program `ebpf:"ssl_ret_write_ex"`
+	SslWrite           *ebpf.Program `ebpf:"ssl_write"`
+	SslWriteEx         *ebpf.Program `ebpf:"ssl_write_ex"`
+	SysEnterAccept4    *ebpf.Program `ebpf:"sys_enter_accept4"`
+	SysEnterConnect    *ebpf.Program `ebpf:"sys_enter_connect"`
+	SysEnterRead       *ebpf.Program `ebpf:"sys_enter_read"`
+	SysEnterWrite      *ebpf.Program `ebpf:"sys_enter_write"`
+	SysExitAccept4     *ebpf.Program `ebpf:"sys_exit_accept4"`
+	SysExitConnect     *ebpf.Program `ebpf:"sys_exit_connect"`
 }
 
 func (p *tlsTapperPrograms) Close() error {
 	return _TlsTapperClose(
-		p.GoCryptoTlsAbi0Read,
-		p.GoCryptoTlsAbi0ReadEx,
-		p.GoCryptoTlsAbi0Write,
-		p.GoCryptoTlsAbi0WriteEx,
-		p.GoCryptoTlsAbiInternalRead,
-		p.GoCryptoTlsAbiInternalReadEx,
-		p.GoCryptoTlsAbiInternalWrite,
-		p.GoCryptoTlsAbiInternalWriteEx,
+		p.GoCryptoTlsRead,
+		p.GoCryptoTlsReadEx,
+		p.GoCryptoTlsWrite,
+		p.GoCryptoTlsWriteEx,
 		p.SslRead,
 		p.SslReadEx,
 		p.SslRetRead,
@@ -225,8 +195,6 @@ func (p *tlsTapperPrograms) Close() error {
 		p.SysEnterWrite,
 		p.SysExitAccept4,
 		p.SysExitConnect,
-		p.TcpRecvmsg,
-		p.TcpSendmsg,
 	)
 }
 

tap/tlstapper/tlstapper_bpfel_x86.go

@@ -13,27 +13,16 @@ import (
 	"github.com/cilium/ebpf"
 )
 
-type tlsTapperGoidOffsets struct {
-	G_addrOffset uint64
-	GoidOffset   uint64
-}
-
 type tlsTapperTlsChunk struct {
-	Pid         uint32
-	Tgid        uint32
-	Len         uint32
-	Start       uint32
-	Recorded    uint32
-	Fd          uint32
-	Flags       uint32
-	AddressInfo struct {
-		Mode  int32
-		Saddr uint32
-		Daddr uint32
-		Sport uint16
-		Dport uint16
-	}
-	Data [4096]uint8
+	Pid      uint32
+	Tgid     uint32
+	Len      uint32
+	Start    uint32
+	Recorded uint32
+	Fd       uint32
+	Flags    uint32
+	Address  [16]uint8
+	Data     [4096]uint8
 }
 
 // loadTlsTapper returns the embedded CollectionSpec for tlsTapper.
@@ -77,30 +66,24 @@ type tlsTapperSpecs struct {
 //
 // It can be passed ebpf.CollectionSpec.Assign.
 type tlsTapperProgramSpecs struct {
-	GoCryptoTlsAbi0Read           *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_read"`
-	GoCryptoTlsAbi0ReadEx         *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_read_ex"`
-	GoCryptoTlsAbi0Write          *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_write"`
-	GoCryptoTlsAbi0WriteEx        *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi0_write_ex"`
-	GoCryptoTlsAbiInternalRead    *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_read"`
-	GoCryptoTlsAbiInternalReadEx  *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_read_ex"`
-	GoCryptoTlsAbiInternalWrite   *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_write"`
-	GoCryptoTlsAbiInternalWriteEx *ebpf.ProgramSpec `ebpf:"go_crypto_tls_abi_internal_write_ex"`
-	SslRead                       *ebpf.ProgramSpec `ebpf:"ssl_read"`
-	SslReadEx                     *ebpf.ProgramSpec `ebpf:"ssl_read_ex"`
-	SslRetRead                    *ebpf.ProgramSpec `ebpf:"ssl_ret_read"`
-	SslRetReadEx                  *ebpf.ProgramSpec `ebpf:"ssl_ret_read_ex"`
-	SslRetWrite                   *ebpf.ProgramSpec `ebpf:"ssl_ret_write"`
-	SslRetWriteEx                 *ebpf.ProgramSpec `ebpf:"ssl_ret_write_ex"`
-	SslWrite                      *ebpf.ProgramSpec `ebpf:"ssl_write"`
-	SslWriteEx                    *ebpf.ProgramSpec `ebpf:"ssl_write_ex"`
-	SysEnterAccept4               *ebpf.ProgramSpec `ebpf:"sys_enter_accept4"`
-	SysEnterConnect               *ebpf.ProgramSpec `ebpf:"sys_enter_connect"`
-	SysEnterRead                  *ebpf.ProgramSpec `ebpf:"sys_enter_read"`
-	SysEnterWrite                 *ebpf.ProgramSpec `ebpf:"sys_enter_write"`
-	SysExitAccept4                *ebpf.ProgramSpec `ebpf:"sys_exit_accept4"`
-	SysExitConnect                *ebpf.ProgramSpec `ebpf:"sys_exit_connect"`
-	TcpRecvmsg                    *ebpf.ProgramSpec `ebpf:"tcp_recvmsg"`
-	TcpSendmsg                    *ebpf.ProgramSpec `ebpf:"tcp_sendmsg"`
+	GoCryptoTlsRead    *ebpf.ProgramSpec `ebpf:"go_crypto_tls_read"`
+	GoCryptoTlsReadEx  *ebpf.ProgramSpec `ebpf:"go_crypto_tls_read_ex"`
+	GoCryptoTlsWrite   *ebpf.ProgramSpec `ebpf:"go_crypto_tls_write"`
+	GoCryptoTlsWriteEx *ebpf.ProgramSpec `ebpf:"go_crypto_tls_write_ex"`
+	SslRead            *ebpf.ProgramSpec `ebpf:"ssl_read"`
+	SslReadEx          *ebpf.ProgramSpec `ebpf:"ssl_read_ex"`
+	SslRetRead         *ebpf.ProgramSpec `ebpf:"ssl_ret_read"`
+	SslRetReadEx       *ebpf.ProgramSpec `ebpf:"ssl_ret_read_ex"`
+	SslRetWrite        *ebpf.ProgramSpec `ebpf:"ssl_ret_write"`
+	SslRetWriteEx      *ebpf.ProgramSpec `ebpf:"ssl_ret_write_ex"`
+	SslWrite           *ebpf.ProgramSpec `ebpf:"ssl_write"`
+	SslWriteEx         *ebpf.ProgramSpec `ebpf:"ssl_write_ex"`
+	SysEnterAccept4    *ebpf.ProgramSpec `ebpf:"sys_enter_accept4"`
+	SysEnterConnect    *ebpf.ProgramSpec `ebpf:"sys_enter_connect"`
+	SysEnterRead       *ebpf.ProgramSpec `ebpf:"sys_enter_read"`
+	SysEnterWrite      *ebpf.ProgramSpec `ebpf:"sys_enter_write"`
+	SysExitAccept4     *ebpf.ProgramSpec `ebpf:"sys_exit_accept4"`
+	SysExitConnect     *ebpf.ProgramSpec `ebpf:"sys_exit_connect"`
 }
 
 // tlsTapperMapSpecs contains maps before they are loaded into the kernel.
@@ -113,7 +96,6 @@ type tlsTapperMapSpecs struct {
 	FileDescriptorToIpv4 *ebpf.MapSpec `ebpf:"file_descriptor_to_ipv4"`
 	GoReadContext        *ebpf.MapSpec `ebpf:"go_read_context"`
 	GoWriteContext       *ebpf.MapSpec `ebpf:"go_write_context"`
-	GoidOffsetsMap       *ebpf.MapSpec `ebpf:"goid_offsets_map"`
 	Heap                 *ebpf.MapSpec `ebpf:"heap"`
 	LogBuffer            *ebpf.MapSpec `ebpf:"log_buffer"`
 	OpensslReadContext   *ebpf.MapSpec `ebpf:"openssl_read_context"`
@@ -146,7 +128,6 @@ type tlsTapperMaps struct {
 	FileDescriptorToIpv4 *ebpf.Map `ebpf:"file_descriptor_to_ipv4"`
 	GoReadContext        *ebpf.Map `ebpf:"go_read_context"`
 	GoWriteContext       *ebpf.Map `ebpf:"go_write_context"`
-	GoidOffsetsMap       *ebpf.Map `ebpf:"goid_offsets_map"`
 	Heap                 *ebpf.Map `ebpf:"heap"`
 	LogBuffer            *ebpf.Map `ebpf:"log_buffer"`
 	OpensslReadContext   *ebpf.Map `ebpf:"openssl_read_context"`
@@ -162,7 +143,6 @@ func (m *tlsTapperMaps) Close() error {
 		m.FileDescriptorToIpv4,
 		m.GoReadContext,
 		m.GoWriteContext,
-		m.GoidOffsetsMap,
 		m.Heap,
 		m.LogBuffer,
 		m.OpensslReadContext,
@@ -175,42 +155,32 @@ func (m *tlsTapperMaps) Close() error {
 //
 // It can be passed to loadTlsTapperObjects or ebpf.CollectionSpec.LoadAndAssign.
 type tlsTapperPrograms struct {
-	GoCryptoTlsAbi0Read           *ebpf.Program `ebpf:"go_crypto_tls_abi0_read"`
-	GoCryptoTlsAbi0ReadEx         *ebpf.Program `ebpf:"go_crypto_tls_abi0_read_ex"`
-	GoCryptoTlsAbi0Write          *ebpf.Program `ebpf:"go_crypto_tls_abi0_write"`
-	GoCryptoTlsAbi0WriteEx        *ebpf.Program `ebpf:"go_crypto_tls_abi0_write_ex"`
-	GoCryptoTlsAbiInternalRead    *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_read"`
-	GoCryptoTlsAbiInternalReadEx  *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_read_ex"`
-	GoCryptoTlsAbiInternalWrite   *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_write"`
-	GoCryptoTlsAbiInternalWriteEx *ebpf.Program `ebpf:"go_crypto_tls_abi_internal_write_ex"`
-	SslRead                       *ebpf.Program `ebpf:"ssl_read"`
-	SslReadEx                     *ebpf.Program `ebpf:"ssl_read_ex"`
-	SslRetRead                    *ebpf.Program `ebpf:"ssl_ret_read"`
-	SslRetReadEx                  *ebpf.Program `ebpf:"ssl_ret_read_ex"`
-	SslRetWrite                   *ebpf.Program `ebpf:"ssl_ret_write"`
-	SslRetWriteEx                 *ebpf.Program `ebpf:"ssl_ret_write_ex"`
-	SslWrite                      *ebpf.Program `ebpf:"ssl_write"`
-	SslWriteEx                    *ebpf.Program `ebpf:"ssl_write_ex"`
-	SysEnterAccept4               *ebpf.Program `ebpf:"sys_enter_accept4"`
-	SysEnterConnect               *ebpf.Program `ebpf:"sys_enter_connect"`
-	SysEnterRead                  *ebpf.Program `ebpf:"sys_enter_read"`
-	SysEnterWrite                 *ebpf.Program `ebpf:"sys_enter_write"`
-	SysExitAccept4                *ebpf.Program `ebpf:"sys_exit_accept4"`
-	SysExitConnect                *ebpf.Program `ebpf:"sys_exit_connect"`
-	TcpRecvmsg                    *ebpf.Program `ebpf:"tcp_recvmsg"`
-	TcpSendmsg                    *ebpf.Program `ebpf:"tcp_sendmsg"`
+	GoCryptoTlsRead    *ebpf.Program `ebpf:"go_crypto_tls_read"`
+	GoCryptoTlsReadEx  *ebpf.Program `ebpf:"go_crypto_tls_read_ex"`
+	GoCryptoTlsWrite   *ebpf.Program `ebpf:"go_crypto_tls_write"`
+	GoCryptoTlsWriteEx *ebpf.Program `ebpf:"go_crypto_tls_write_ex"`
+	SslRead            *ebpf.Program `ebpf:"ssl_read"`
+	SslReadEx          *ebpf.Program `ebpf:"ssl_read_ex"`
+	SslRetRead         *ebpf.Program `ebpf:"ssl_ret_read"`
+	SslRetReadEx       *ebpf.Program `ebpf:"ssl_ret_read_ex"`
+	SslRetWrite        *ebpf.Program `ebpf:"ssl_ret_write"`
+	SslRetWriteEx      *ebpf.Program `ebpf:"ssl_ret_write_ex"`
+	SslWrite           *ebpf.Program `ebpf:"ssl_write"`
+	SslWriteEx         *ebpf.Program `ebpf:"ssl_write_ex"`
+	SysEnterAccept4    *ebpf.Program `ebpf:"sys_enter_accept4"`
+	SysEnterConnect    *ebpf.Program `ebpf:"sys_enter_connect"`
+	SysEnterRead       *ebpf.Program `ebpf:"sys_enter_read"`
+	SysEnterWrite      *ebpf.Program `ebpf:"sys_enter_write"`
+	SysExitAccept4     *ebpf.Program `ebpf:"sys_exit_accept4"`
+	SysExitConnect     *ebpf.Program `ebpf:"sys_exit_connect"`
 }
 
 func (p *tlsTapperPrograms) Close() error {
 	return _TlsTapperClose(
-		p.GoCryptoTlsAbi0Read,
-		p.GoCryptoTlsAbi0ReadEx,
-		p.GoCryptoTlsAbi0Write,
-		p.GoCryptoTlsAbi0WriteEx,
-		p.GoCryptoTlsAbiInternalRead,
-		p.GoCryptoTlsAbiInternalReadEx,
-		p.GoCryptoTlsAbiInternalWrite,
-		p.GoCryptoTlsAbiInternalWriteEx,
+		p.GoCryptoTlsRead,
+		p.GoCryptoTlsReadEx,
+		p.GoCryptoTlsWrite,
+		p.GoCryptoTlsWriteEx,
 		p.SslRead,
 		p.SslReadEx,
 		p.SslRetRead,
@@ -225,8 +195,6 @@ func (p *tlsTapperPrograms) Close() error {
 		p.SysEnterWrite,
 		p.SysExitAccept4,
 		p.SysExitConnect,
-		p.TcpRecvmsg,
-		p.TcpSendmsg,
 	)
 }
 

ui-common/package.json

@@ -65,7 +65,6 @@
     "recharts": "^2.1.10",
     "redoc": "^2.0.0-rc.71",
     "styled-components": "^5.3.5",
-    "use-file-picker": "^1.4.2",
     "web-vitals": "^2.1.4",
     "xml-formatter": "^2.6.1"
   },

ui-common/src/components.scss

@@ -17,6 +17,6 @@
       width: 100%;
       width: -moz-available;
       width: -webkit-fill-available;
-      width: stretch;
+      width: strech;
     }
-}
+}

ui-common/src/components/EntriesList/EntriesList.tsx

@@ -1,20 +1,20 @@
-import React, { useCallback, useEffect, useMemo, useState } from "react";
+import React, {useCallback, useEffect, useMemo, useState} from "react";
 import styles from './EntriesList.module.sass';
 import ScrollableFeedVirtualized from "react-scrollable-feed-virtualized";
-import { EntryItem } from "../EntryListItem/EntryListItem";
+import Moment from 'moment';
+import {EntryItem} from "../EntryListItem/EntryListItem";
 import down from "assets/downImg.svg";
 import spinner from 'assets/spinner.svg';
-import { RecoilState, useRecoilState, useRecoilValue, useSetRecoilState } from "recoil";
+import {RecoilState, useRecoilState, useRecoilValue, useSetRecoilState} from "recoil";
 import entriesAtom from "../../recoil/entries";
 import queryAtom from "../../recoil/query";
 import TrafficViewerApiAtom from "../../recoil/TrafficViewerApi";
 import TrafficViewerApi from "../TrafficViewer/TrafficViewerApi";
 import focusedEntryIdAtom from "../../recoil/focusedEntryId";
-import { toast } from "react-toastify";
-import { MAX_ENTRIES, TOAST_CONTAINER_ID } from "../../configs/Consts";
+import {toast} from "react-toastify";
+import {MAX_ENTRIES, TOAST_CONTAINER_ID} from "../../configs/Consts";
 import tappingStatusAtom from "../../recoil/tappingStatus";
 import leftOffTopAtom from "../../recoil/leftOffTop";
-import Moment from "moment";
 
 interface EntriesListProps {
   listEntryREF: any;

ui-common/src/components/EntryDetailed/EntryDetailed.tsx

@@ -12,8 +12,8 @@ import TrafficViewerApiAtom from "../../recoil/TrafficViewerApi/atom";
 import queryAtom from "../../recoil/query/atom";
 import useWindowDimensions, { useRequestTextByWidth } from "../../hooks/WindowDimensionsHook";
 import { TOAST_CONTAINER_ID } from "../../configs/Consts";
+import spinner from "assets/spinner.svg";
 import entryDataAtom from "../../recoil/entryData";
-import { LoadingWrapper } from "../UI/withLoading/withLoading";
 
 const useStyles = makeStyles(() => ({
     entryTitle: {
@@ -135,11 +135,19 @@ export const EntryDetailed = () => {
         // eslint-disable-next-line
     }, [focusedEntryId]);
 
-    return <LoadingWrapper isLoading={isLoading} loaderMargin={50} loaderHeight={60}>
-        {entryData && <React.Fragment>
-            <EntryTitle protocol={entryData.protocol} data={entryData.data} elapsedTime={entryData.data.elapsedTime} />
-            <EntrySummary entry={entryData.base} namespace={entryData.data.namespace} />
-            <EntryViewer representation={entryData.representation} color={entryData.protocol.backgroundColor} />
-        </React.Fragment>}
-    </LoadingWrapper>
+    return <React.Fragment>
+      {isLoading && <div style={{textAlign: "center", width: "100%", marginTop: 50}}><img alt="spinner" src={spinner} style={{height: 60}}/></div>}
+      {!isLoading && entryData && <EntryTitle
+            protocol={entryData.protocol}
+            data={entryData.data}
+            elapsedTime={entryData.data.elapsedTime}
+        />}
+        {!isLoading && entryData && <EntrySummary entry={entryData.base} namespace={entryData.data.namespace} />}
+        <React.Fragment>
+            {!isLoading && entryData && <EntryViewer
+                representation={entryData.representation}
+                color={entryData.protocol.backgroundColor}
+            />}
+        </React.Fragment>
+    </React.Fragment>
 };

ui-common/src/components/EntryDetailed/EntryViewer/AutoRepresentation.tsx

@@ -6,7 +6,6 @@ import { ReactComponent as ReplayIcon } from './replay.svg';
 import styles from './EntryViewer.module.sass';
 import { Tabs } from "../../UI";
 import replayRequestModalOpenAtom from "../../../recoil/replayRequestModalOpen";
-import entryDetailedConfigAtom, { EntryDetailedConfig } from "../../../recoil/entryDetailedConfig";
 
 const enabledProtocolsForReplay = ["http"]
 
@@ -17,11 +16,10 @@ export enum TabsEnum {
 
 export const AutoRepresentation: React.FC<any> = ({ representation, color, openedTab = TabsEnum.Request, isDisplayReplay = false }) => {
     const entryData = useRecoilValue(entryDataAtom)
-    const { isReplayEnabled } = useRecoilValue<EntryDetailedConfig>(entryDetailedConfigAtom)
     const setIsOpenRequestModal = useSetRecoilState(replayRequestModalOpenAtom)
     const isReplayDisplayed = useCallback(() => {
-        return enabledProtocolsForReplay.find(x => x === entryData.protocol.name) && isDisplayReplay && isReplayEnabled
-    }, [entryData.protocol.name, isDisplayReplay, isReplayEnabled])
+        return enabledProtocolsForReplay.find(x => x === entryData.protocol.name) && isDisplayReplay
+    }, [entryData.protocol.name, isDisplayReplay])
 
     const { request, response } = JSON.parse(representation);
 
@@ -29,18 +27,20 @@ export const AutoRepresentation: React.FC<any> = ({ representation, color, opene
         const arr = [
             {
                 tab: 'Request',
-                badge: null
+                badge: isReplayDisplayed() && <span title="Replay Request"><ReplayIcon fill={color} stroke={color} style={{ marginLeft: "10px", cursor: "pointer", height: "22px" }} onClick={() => setIsOpenRequestModal(true)} /></span>
             }]
 
         if (response) {
-            arr.push({
-                tab: 'Response',
-                badge: null
-            });
+            arr.push(
+                {
+                    tab: 'Response',
+                    badge: null
+                }
+            );
         }
 
         return arr
-    }, [response]);
+    }, [color, isReplayDisplayed, response, setIsOpenRequestModal]);
 
     const [currentTab, setCurrentTab] = useState(TABS[0].tab);
 
@@ -66,7 +66,6 @@ export const AutoRepresentation: React.FC<any> = ({ representation, color, opene
         {<div className={styles.body}>
             <div className={styles.bodyHeader}>
                 <Tabs tabs={TABS} currentTab={currentTab} color={color} onChange={setCurrentTab} leftAligned />
-                {isReplayDisplayed() && <span title="Replay Request"><ReplayIcon fill={color} stroke={color} style={{ marginLeft: "10px", cursor: "pointer", height: "22px" }} onClick={() => setIsOpenRequestModal(true)} /></span>}
             </div>
             {getOpenedTabIndex() === TabsEnum.Request && <React.Fragment>
                 <SectionsRepresentation data={request} color={color} requestRepresentation={request} />

ui-common/src/components/EntryDetailed/EntryViewer/EntryViewer.module.sass

@@ -52,13 +52,8 @@
         border-radius: 4px
         padding: 10px
         position: relative
-        
         .bodyHeader
             padding: 0 1rem
-            display: flex
-            align-items: center
-            justify-content: space-between
-
         .endpointURL
             font-size: .75rem
             display: block

ui-common/src/components/TrafficViewer/TrafficViewer.tsx

@@ -22,7 +22,6 @@ import leftOffTopAtom from "../../recoil/leftOffTop";
 import { DEFAULT_LEFTOFF, DEFAULT_FETCH, DEFAULT_FETCH_TIMEOUT_MS } from '../../hooks/useWS';
 import ReplayRequestModalContainer from "../modals/ReplayRequestModal/ReplayRequestModal";
 import replayRequestModalOpenAtom from "../../recoil/replayRequestModalOpen";
-import entryDetailedConfigAtom, { EntryDetailedConfig } from "../../recoil/entryDetailedConfig";
 
 const useLayoutStyles = makeStyles(() => ({
   details: {
@@ -52,22 +51,18 @@ interface TrafficViewerProps {
   webSocketUrl: string,
   shouldCloseWebSocket: boolean,
   setShouldCloseWebSocket: (flag: boolean) => void,
-  isDemoBannerView: boolean,
-  entryDetailedConfig: EntryDetailedConfig
+  isDemoBannerView: boolean
 }
 
 export const TrafficViewer: React.FC<TrafficViewerProps> = ({
-  trafficViewerApiProp,
-  webSocketUrl,
-  actionButtons,
-  isShowStatusBar, isDemoBannerView,
-  shouldCloseWebSocket, setShouldCloseWebSocket,
-  entryDetailedConfig }) => {
+                                                              trafficViewerApiProp,
+                                                              actionButtons, isShowStatusBar, webSocketUrl,
+                                                              shouldCloseWebSocket, setShouldCloseWebSocket, isDemoBannerView
+                                                            }) => {
 
   const classes = useLayoutStyles();
   const setEntries = useSetRecoilState(entriesAtom);
   const setFocusedEntryId = useSetRecoilState(focusedEntryIdAtom);
-  const setEntryDetailedConfigAtom = useSetRecoilState(entryDetailedConfigAtom)
   const query = useRecoilValue(queryAtom);
   const setTrafficViewerApiState = useSetRecoilState(trafficViewerApiAtom as RecoilState<TrafficViewerApi>)
   const [tappingStatus, setTappingStatus] = useRecoilState(tappingStatusAtom);
@@ -188,10 +183,6 @@ export const TrafficViewer: React.FC<TrafficViewerProps> = ({
     };
   }, []);
 
-  useEffect(() => {
-    setEntryDetailedConfigAtom(entryDetailedConfig)
-  }, [entryDetailedConfig, setEntryDetailedConfigAtom])
-
   const getConnectionIndicator = () => {
     switch (wsReadyState) {
       case WebSocket.OPEN:
@@ -267,7 +258,7 @@ export const TrafficViewer: React.FC<TrafficViewerProps> = ({
           </div>
         </div>
         <div className={classes.details} id="rightSideContainer">
-          <EntryDetailed />
+          <EntryDetailed/>
         </div>
       </div>}
     </div>
@@ -275,19 +266,25 @@ export const TrafficViewer: React.FC<TrafficViewerProps> = ({
 };
 
 const MemorizedTrafficViewer = React.memo(TrafficViewer)
-const TrafficViewerContainer: React.FC<TrafficViewerProps> = (props) => {
+const TrafficViewerContainer: React.FC<TrafficViewerProps> = ({
+                                                                trafficViewerApiProp,
+                                                                actionButtons, isShowStatusBar = true,
+                                                                webSocketUrl, shouldCloseWebSocket, setShouldCloseWebSocket, isDemoBannerView
+                                                              }) => {
   return <RecoilRoot>
-    <MemorizedTrafficViewer  {...props} />
+    <MemorizedTrafficViewer actionButtons={actionButtons} isShowStatusBar={isShowStatusBar} webSocketUrl={webSocketUrl}
+                          shouldCloseWebSocket={shouldCloseWebSocket} setShouldCloseWebSocket={setShouldCloseWebSocket} trafficViewerApiProp={trafficViewerApiProp}
+                          isDemoBannerView={isDemoBannerView}/>
     <ToastContainer enableMultiContainer containerId={TOAST_CONTAINER_ID}
-      position="bottom-right"
-      autoClose={5000}
-      hideProgressBar={false}
-      newestOnTop={false}
-      closeOnClick
-      rtl={false}
-      pauseOnFocusLoss
-      draggable
-      pauseOnHover />
+                    position="bottom-right"
+                    autoClose={5000}
+                    hideProgressBar={false}
+                    newestOnTop={false}
+                    closeOnClick
+                    rtl={false}
+                    pauseOnFocusLoss
+                    draggable
+                    pauseOnHover/>
     <ReplayRequestModalContainer />
   </RecoilRoot>
 }

ui-common/src/components/UI/CodeEditor/CodeEditor.tsx

@@ -37,6 +37,11 @@ const CodeEditor: React.FC<CodeEditorProps> = ({
             theme="github"
             onChange={onChange}
             editorProps={{ $blockScrolling: true }}
+            setOptions={{
+                enableBasicAutocompletion: true,
+                enableLiveAutocompletion: true,
+                enableSnippets: true
+            }}
             showPrintMargin={false}
             value={code}
             width="100%"

ui-common/src/components/UI/FilePicker/FilePicker.tsx

@@ -1,33 +0,0 @@
-import React from 'react';
-import { useEffect } from 'react';
-import { useFilePicker } from 'use-file-picker';
-import { FileContent } from 'use-file-picker/dist/interfaces';
-
-interface IFilePickerProps {
-    onLoadingComplete: (file: FileContent) => void;
-    elem: any
-}
-
-const FilePicker = ({ elem, onLoadingComplete }: IFilePickerProps) => {
-    const [openFileSelector, { filesContent }] = useFilePicker({
-        accept: ['.json'],
-        limitFilesConfig: { max: 1 },
-        maxFileSize: 1
-    });
-
-    const onFileSelectorClick = (e) => {
-        e.preventDefault();
-        e.stopPropagation();
-        openFileSelector();
-    }
-
-    useEffect(() => {
-        filesContent.length && onLoadingComplete(filesContent[0])
-    }, [filesContent, onLoadingComplete]);
-
-    return (<React.Fragment>
-        {React.cloneElement(elem, { onClick: onFileSelectorClick })}
-    </React.Fragment>)
-}
-
-export default FilePicker;

ui-common/src/components/UI/KeyValueTable/KeyValueTable.tsx

@@ -75,6 +75,5 @@ const KeyValueTable: React.FC<KeyValueTableProps> = ({ data, onDataChange, keyPl
         })}
     </div>
 }
-export const convertParamsToArr = (paramsObj) => Object.entries(paramsObj).map(([key, value]) => { return { key, value } })
-export const convertArrToKeyValueObject = (arr) => arr.reduce((acc, curr) => { acc[curr.key] = curr.value; return acc }, {})
+
 export default KeyValueTable

ui-common/src/components/UI/index.ts

@@ -8,7 +8,6 @@ import CustomModal from "./CustomModal/CustomModal";
 import { InformationIcon, Link } from "./InformationIcon/InformationIcon";
 import SelectList from "./SelectList/SelectList";
 import NoDataMessage from "./NoDataMessage/NoDataMessage";
-import withLoading from "./withLoading/withLoading";
 
-export { LoadingOverlay, Select, Tabs, Tooltip, Checkbox, CustomModal, InformationIcon, SelectList, NoDataMessage, withLoading, Link };
+export { LoadingOverlay, Select, Tabs, Tooltip, Checkbox, CustomModal, InformationIcon, SelectList, NoDataMessage, Link };
 export { StatusBar }

ui-common/src/components/UI/withLoading/spinner.svg

@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" style="margin: auto; background: none; display: block; shape-rendering: auto;" width="200px" height="200px" viewBox="0 0 100 100" preserveAspectRatio="xMidYMid">
-<circle cx="50" cy="50" fill="none" stroke="#1d3f72" stroke-width="10" r="35" stroke-dasharray="164.93361431346415 56.97787143782138" transform="rotate(275.903 50 50)">
-  <animateTransform attributeName="transform" type="rotate" repeatCount="indefinite" dur="1s" values="0 50 50;360 50 50" keyTimes="0;1"></animateTransform>
-</circle>
-<!-- [ldio] generated by https://loading.io/ --></svg>

ui-common/src/components/UI/withLoading/withLoading.tsx

@@ -1,33 +0,0 @@
-import React from "react";
-import spinner from 'spinner.svg';
-
-export interface WithLoadingProps {
-    isLoading: boolean
-    loaderMargin?: number,
-    loaderHeight?: number
-}
-
-const Loader = ({ loaderMargin = 20, loaderHeight = 35 }: Omit<WithLoadingProps, "isLoading">) => {
-    return <div style={{ textAlign: "center", margin: loaderMargin }}>
-        <img alt="spinner" src={spinner} style={{ height: loaderHeight }} />
-    </div>
-}
-
-const withLoading = <P extends object>(
-    Component: React.ComponentType<P>
-): React.FC<P & WithLoadingProps> => ({
-    isLoading,
-    loaderMargin,
-    loaderHeight,
-    ...props
-}: WithLoadingProps) => isLoading ?
-            <Loader loaderMargin={loaderMargin} loaderHeight={loaderHeight} /> :
-            <Component {...props as P} />;
-
-export const LoadingWrapper: React.FC<WithLoadingProps> = ({ loaderMargin, loaderHeight, isLoading, children }) => {
-    return isLoading ?
-        <Loader loaderMargin={loaderMargin} loaderHeight={loaderHeight} /> :
-        <React.Fragment>{children}</React.Fragment>
-}
-
-export default withLoading

ui-common/src/components/modals/ReplayRequestModal/ReplayRequestModal.module.sass

@@ -79,12 +79,5 @@
     overflow: hidden
     
     b::after
-        content: '\b'
+       content: '\b'
         display: inline
-
-.icon
-    width: 24px
-    height: 26px
-    stroke-width: 0px
-    fill: $blue-color
-    stroke: $blue-color

ui-common/src/components/modals/ReplayRequestModal/ReplayRequestModal.tsx

@@ -1,30 +1,25 @@
-import ExpandMoreIcon from '@mui/icons-material/ExpandMore';
-import DownloadIcon from '@mui/icons-material/FileDownloadOutlined';
-import UploadIcon from '@mui/icons-material/UploadFile';
-import closeIcon from "assets/close.svg";
-import refreshImg from "assets/refresh.svg";
 import { Accordion, AccordionDetails, AccordionSummary, Backdrop, Box, Button, Fade, Modal } from "@mui/material";
+import ExpandMoreIcon from '@mui/icons-material/ExpandMore';
 import React, { Fragment, useCallback, useEffect, useState } from "react";
-import { toast } from "react-toastify";
-import { RecoilState, useRecoilState, useRecoilValue } from "recoil";
-import { FileContent } from "use-file-picker/dist/interfaces";
-import { TOAST_CONTAINER_ID } from "../../../configs/Consts";
 import { useCommonStyles } from "../../../helpers/commonStyle";
-import { Utils } from "../../../helpers/Utils";
-import useDebounce from "../../../hooks/useDebounce";
-import entryDataAtom from "../../../recoil/entryData";
-import replayRequestModalOpenAtom from "../../../recoil/replayRequestModalOpen";
-import TrafficViewerApiAtom from "../../../recoil/TrafficViewerApi/atom";
-import { formatRequestWithOutError } from "../../EntryDetailed/EntrySections/EntrySections";
-import { AutoRepresentation, TabsEnum } from "../../EntryDetailed/EntryViewer/AutoRepresentation";
-import TrafficViewerApi from "../../TrafficViewer/TrafficViewerApi";
 import { Tabs } from "../../UI";
+import KeyValueTable from "../../UI/KeyValueTable/KeyValueTable";
 import CodeEditor from "../../UI/CodeEditor/CodeEditor";
-import FilePicker from '../../UI/FilePicker/FilePicker';
-import KeyValueTable, { convertArrToKeyValueObject, convertParamsToArr } from "../../UI/KeyValueTable/KeyValueTable";
-import { LoadingWrapper } from "../../UI/withLoading/withLoading";
-import { IReplayRequestData, KeyValuePair } from './interfaces';
-import styles from './ReplayRequestModal.module.sass';
+import { useRecoilValue, RecoilState, useRecoilState } from "recoil";
+import TrafficViewerApiAtom from "../../../recoil/TrafficViewerApi/atom";
+import TrafficViewerApi from "../../TrafficViewer/TrafficViewerApi";
+import { toast } from "react-toastify";
+import { TOAST_CONTAINER_ID } from "../../../configs/Consts";
+import styles from './ReplayRequestModal.module.sass'
+import closeIcon from "assets/close.svg"
+import spinnerImg from "assets/spinner.svg"
+import refreshImg from "assets/refresh.svg"
+import { formatRequestWithOutError } from "../../EntryDetailed/EntrySections/EntrySections";
+import entryDataAtom from "../../../recoil/entryData";
+import { AutoRepresentation, TabsEnum } from "../../EntryDetailed/EntryViewer/AutoRepresentation";
+import useDebounce from "../../../hooks/useDebounce"
+import replayRequestModalOpenAtom from "../../../recoil/replayRequestModalOpen";
+import { Utils } from "../../../helpers/Utils";
 
 const modalStyle = {
     position: 'absolute',
@@ -42,6 +37,11 @@ const modalStyle = {
     paddingBottom: "15px"
 };
 
+interface ReplayRequestModalProps {
+    isOpen: boolean;
+    onClose: () => void;
+}
+
 enum RequestTabs {
     Params = "params",
     Headers = "headers",
@@ -51,6 +51,8 @@ enum RequestTabs {
 const HTTP_METHODS = ["get", "post", "put", "head", "options", "delete"]
 const TABS = [{ tab: RequestTabs.Headers }, { tab: RequestTabs.Params }, { tab: RequestTabs.Body }];
 
+const convertParamsToArr = (paramsObj) => Object.entries(paramsObj).map(([key, value]) => { return { key, value } })
+
 const getQueryStringParams = (link: String) => {
 
     if (link) {
@@ -67,61 +69,43 @@ const decodeQueryParam = (p) => {
     return decodeURIComponent(p.replace(/\+/g, ' '));
 }
 
-interface ReplayRequestModalProps {
-    isOpen: boolean;
-    onClose: () => void;
-}
-
 const ReplayRequestModal: React.FC<ReplayRequestModalProps> = ({ isOpen, onClose }) => {
     const entryData = useRecoilValue(entryDataAtom)
     const request = entryData.data.request
+    const [method, setMethod] = useState(request?.method?.toLowerCase() as string)
     const getHostUrl = useCallback(() => {
         return entryData.data.dst.name ? entryData.data?.dst?.name : entryData.data.dst.ip
     }, [entryData.data.dst.ip, entryData.data.dst.name])
-    const getHostPortVal = useCallback(() => {
-        return `${entryData.base.proto.name}://${getHostUrl()}:${entryData.data.dst.port}`
-    }, [entryData.base.proto.name, entryData.data.dst.port, getHostUrl])
-    const [hostPortInput, setHostPortInput] = useState(getHostPortVal())
+    const [hostPortInput, setHostPortInput] = useState(`${entryData.base.proto.name}://${getHostUrl()}:${entryData.data.dst.port}`)
     const [pathInput, setPathInput] = useState(request.path);
     const commonClasses = useCommonStyles();
     const [currentTab, setCurrentTab] = useState(TABS[0].tab);
     const [response, setResponse] = useState(null);
+    const [postData, setPostData] = useState(request?.postData?.text || JSON.stringify(request?.postData?.params));
+    const [params, setParams] = useState(convertParamsToArr(request?.queryString || {}))
+    const [headers, setHeaders] = useState(convertParamsToArr(request?.headers || {}))
     const trafficViewerApi = useRecoilValue(TrafficViewerApiAtom as RecoilState<TrafficViewerApi>)
     const [isLoading, setIsLoading] = useState(false)
     const [requestExpanded, setRequestExpanded] = useState(true)
     const [responseExpanded, setResponseExpanded] = useState(false)
 
-    const getInitialRequestData = useCallback((): IReplayRequestData => {
-        return {
-            method: request?.method?.toLowerCase() as string,
-            hostPort: `${entryData.base.proto.name}://${getHostUrl()}:${entryData.data.dst.port}`,
-            path: request.path,
-            postData: request.postData?.text || JSON.stringify(request.postData?.params),
-            headers: convertParamsToArr(request.headers || {}),
-            params: convertParamsToArr(request.queryString || {})
-        }
-    }, [entryData.base.proto.name, entryData.data.dst.port, getHostUrl, request.headers, request?.method, request.path, request.postData?.params, request.postData?.text, request.queryString])
-
-    const [requestDataModel, setRequestData] = useState<IReplayRequestData>(getInitialRequestData())
-
     const debouncedPath = useDebounce(pathInput, 500);
 
-    const addParamsToUrl = useCallback((url: string, params: KeyValuePair[]) => {
-        const urlParams = new URLSearchParams("");
-        params.forEach(param => urlParams.append(param.key, param.value as string))
-        return `${url}?${urlParams.toString()}`
-    }, [])
-
     const onParamsChange = useCallback((newParams) => {
+        setParams(newParams);
         let newUrl = `${debouncedPath ? debouncedPath.split('?')[0] : ""}`
-        newUrl = addParamsToUrl(newUrl, newParams)
+        newParams.forEach(({ key, value }, index) => {
+            newUrl += index > 0 ? '&' : '?'
+            newUrl += `${key}` + (value ? `=${value}` : "")
+        })
+
         setPathInput(newUrl)
-    }, [addParamsToUrl, debouncedPath])
+
+    }, [debouncedPath])
 
     useEffect(() => {
-        const params = convertParamsToArr(getQueryStringParams(debouncedPath));
-        setRequestData({ ...requestDataModel, params })
-        // eslint-disable-next-line react-hooks/exhaustive-deps
+        const newParams = getQueryStringParams(debouncedPath);
+        setParams(convertParamsToArr(newParams))
     }, [debouncedPath])
 
     const onModalClose = () => {
@@ -130,28 +114,33 @@ const ReplayRequestModal: React.FC<ReplayRequestModalProps> = ({ isOpen, onClose
         onClose()
     }
 
-    const resetModal = useCallback((requestDataModel: IReplayRequestData, hostPortInputVal, pathVal) => {
-        setRequestData(requestDataModel)
-        setHostPortInput(hostPortInputVal)
-        setPathInput(addParamsToUrl(pathVal, requestDataModel.params));
+    const resetModel = useCallback(() => {
+        setMethod(request?.method?.toLowerCase() as string)
+        setHostPortInput(`${entryData.base.proto.name}://${getHostUrl()}:${entryData.data.dst.port}`)
+        setPathInput(request.path);
         setResponse(null);
-        setRequestExpanded(true);
-    }, [addParamsToUrl])
+        setPostData(request?.postData?.text || JSON.stringify(request?.postData?.params));
+        setParams(convertParamsToArr(request?.queryString || {}))
+        setHeaders(convertParamsToArr(request?.headers || {}))
+        setRequestExpanded(true)
+    }, [entryData.base.proto.name, entryData.data.dst.port, getHostUrl, request?.headers, request?.method, request.path, request?.postData?.params, request?.postData?.text, request?.queryString])
 
     const onRefreshRequest = useCallback((event) => {
-        event.stopPropagation();
-        const hostPortInputVal = getHostPortVal();
-        resetModal(getInitialRequestData(), hostPortInputVal, request.path);
-    }, [getHostPortVal, getInitialRequestData, request.path, resetModal])
+        event.stopPropagation()
+        resetModel()
+    }, [resetModel])
 
 
     const sendRequest = useCallback(async () => {
         setResponse(null)
-        const headersData = convertArrToKeyValueObject(requestDataModel.headers)
-
+        const headersData = headers.reduce((prev, corrent) => {
+            prev[corrent.key] = corrent.value
+            return prev
+        }, {})
+        const buildUrl = `${hostPortInput}${pathInput}`
+        const requestData = { url: buildUrl, headers: headersData, data: postData, method }
         try {
             setIsLoading(true)
-            const requestData = { url: `${hostPortInput}${pathInput}`, headers: headersData, data: requestDataModel.postData, method: requestDataModel.method }
             const response = await trafficViewerApi.replayRequest(requestData)
             setResponse(response?.data?.representation)
             if (response.errorMessage) {
@@ -161,6 +150,7 @@ const ReplayRequestModal: React.FC<ReplayRequestModalProps> = ({ isOpen, onClose
                 setRequestExpanded(false)
                 setResponseExpanded(true)
             }
+
         } catch (error) {
             setRequestExpanded(true)
             toast.error("Error occurred while fetching response", { containerId: TOAST_CONTAINER_ID });
@@ -169,37 +159,27 @@ const ReplayRequestModal: React.FC<ReplayRequestModalProps> = ({ isOpen, onClose
         finally {
             setIsLoading(false)
         }
-    }, [hostPortInput, pathInput, requestDataModel.headers, requestDataModel.method, requestDataModel.postData, trafficViewerApi])
 
-    const onDownloadRequest = useCallback((e) => {
-        e.stopPropagation()
-        const date = Utils.getNow()
-        Utils.exportToJson(requestDataModel, `${getHostUrl()} - ${date}`)
-    }, [getHostUrl, requestDataModel])
-
-    const onLoadingComplete = useCallback((fileContent: FileContent) => {
-        const requestData = JSON.parse(fileContent.content) as IReplayRequestData
-        resetModal(requestData, requestData.hostPort, requestData.path)
-    }, [resetModal])
+    }, [headers, hostPortInput, method, pathInput, postData, trafficViewerApi])
 
     let innerComponent
     switch (currentTab) {
         case RequestTabs.Params:
-            innerComponent = <div className={styles.keyValueContainer}><KeyValueTable data={requestDataModel.params} onDataChange={onParamsChange} key={"params"} valuePlaceholder="New Param Value" keyPlaceholder="New param Key" /></div>
+            innerComponent = <div className={styles.keyValueContainer}><KeyValueTable data={params} onDataChange={onParamsChange} key={"params"} valuePlaceholder="New Param Value" keyPlaceholder="New param Key" /></div>
             break;
         case RequestTabs.Headers:
             innerComponent = <Fragment>
-                <div className={styles.keyValueContainer}><KeyValueTable data={requestDataModel.headers} onDataChange={(headers) => setRequestData({ ...requestDataModel, headers: headers })} key={"Header"} valuePlaceholder="New Headers Value" keyPlaceholder="New Headers Key" />
+                <div className={styles.keyValueContainer}><KeyValueTable data={headers} onDataChange={(heaedrs) => setHeaders(heaedrs)} key={"Header"} valuePlaceholder="New Headers Value" keyPlaceholder="New Headers Key" />
                 </div>
-                <span className={styles.note}><b>* </b> X-Mizu Header added to requests</span>
+                <span className={styles.note}><b>* </b> X-Mizu Header added to reuqests</span>
             </Fragment>
             break;
         case RequestTabs.Body:
-            const formattedCode = formatRequestWithOutError(requestDataModel.postData || "", request?.postData?.mimeType)
+            const formatedCode = formatRequestWithOutError(postData || "", request?.postData?.mimeType)
             innerComponent = <div className={styles.codeEditor}>
                 <CodeEditor language={request?.postData?.mimeType.split("/")[1]}
-                    code={Utils.isJson(formattedCode) ? JSON.stringify(JSON.parse(formattedCode || "{}"), null, 2) : formattedCode}
-                    onChange={(postData) => setRequestData({ ...requestDataModel, postData })} />
+                    code={Utils.isJson(formatedCode) ? JSON.stringify(JSON.parse(formatedCode || "{}"), null, 2) : formatedCode}
+                    onChange={setPostData} />
             </div>
             break;
         default:
@@ -224,43 +204,17 @@ const ReplayRequestModal: React.FC<ReplayRequestModalProps> = ({ isOpen, onClose
                     <div className={styles.headerContainer}>
                         <div className={styles.headerSection}>
                             <span className={styles.title}>Replay Request</span>
-                            <Button style={{ marginLeft: "2%", textTransform: 'unset' }}
-                                startIcon={<img src={refreshImg} className="custom" alt="Refresh Request"></img>}
-                                size="medium"
-                                variant="contained"
-                                className={commonClasses.outlinedButton + " " + commonClasses.imagedButton}
-                                onClick={onRefreshRequest}
-                            >
-                                Refresh
-                            </Button>
-                            <Button style={{ marginLeft: "2%", textTransform: 'unset' }}
-                                startIcon={<DownloadIcon className={`custom ${styles.icon}`} />}
-                                size="medium"
-                                variant="contained"
-                                className={commonClasses.outlinedButton + " " + commonClasses.imagedButton}
-                                onClick={onDownloadRequest}
-                            >
-                                Download
-                            </Button>
-                            <FilePicker onLoadingComplete={onLoadingComplete}
-                                elem={<Button style={{ marginLeft: "2%", textTransform: 'unset' }}
-                                    startIcon={<UploadIcon className={`custom ${styles.icon}`} />}
-                                    size="medium"
-                                    variant="contained"
-                                    className={commonClasses.outlinedButton + " " + commonClasses.imagedButton}>
-                                    Upload
-                                </Button>}
-                            />
                         </div>
                     </div>
                     <div className={styles.modalContainer}>
                         <Accordion TransitionProps={{ unmountOnExit: true }} expanded={requestExpanded} onChange={() => setRequestExpanded(!requestExpanded)}>
                             <AccordionSummary expandIcon={<ExpandMoreIcon />} aria-controls="response-content">
                                 <span className={styles.sectionHeader}>REQUEST</span>
+                                <img src={refreshImg} style={{ marginLeft: "10px" }} title="Refresh Reuqest" alt="Refresh Reuqest" onClick={onRefreshRequest} />
                             </AccordionSummary>
                             <AccordionDetails>
                                 <div className={styles.path}>
-                                    <select className={styles.select} value={requestDataModel.method} onChange={(e) => setRequestData({ ...requestDataModel, method: e.target.value })}>
+                                    <select className={styles.select} value={method} onChange={(e) => setMethod(e.target.value)}>
                                         {HTTP_METHODS.map(method => <option value={method} key={method}>{method}</option>)}
                                     </select>
                                     <input placeholder="Host:Port" value={hostPortInput} onChange={(event) => setHostPortInput(event.target.value)} className={`${commonClasses.textField} ${styles.hostPort}`} />
@@ -279,20 +233,19 @@ const ReplayRequestModal: React.FC<ReplayRequestModalProps> = ({ isOpen, onClose
                                 </div>
                             </AccordionDetails>
                         </Accordion>
-                        <LoadingWrapper isLoading={isLoading} loaderMargin={10} loaderHeight={50}>
-                            {response && (<Accordion TransitionProps={{ unmountOnExit: true }} expanded={responseExpanded} onChange={() => setResponseExpanded(!responseExpanded)}>
-                                <AccordionSummary expandIcon={<ExpandMoreIcon />} aria-controls="response-content">
-                                    <span className={styles.sectionHeader}>RESPONSE</span>
-                                </AccordionSummary>
-                                <AccordionDetails>
-                                    <AutoRepresentation representation={response} color={entryData.protocol.backgroundColor} openedTab={TabsEnum.Response} />
-                                </AccordionDetails>
-                            </Accordion>)}
-                        </LoadingWrapper>
+                        {isLoading && <img alt="spinner" src={spinnerImg} style={{ height: 50 }} />}
+                        {response && !isLoading && (<Accordion TransitionProps={{ unmountOnExit: true }} expanded={responseExpanded} onChange={() => setResponseExpanded(!responseExpanded)}>
+                            <AccordionSummary expandIcon={<ExpandMoreIcon />} aria-controls="response-content">
+                                <span className={styles.sectionHeader}>RESPONSE</span>
+                            </AccordionSummary>
+                            <AccordionDetails>
+                                <AutoRepresentation representation={response} color={entryData.protocol.backgroundColor} openedTab={TabsEnum.Response} />
+                            </AccordionDetails>
+                        </Accordion>)}
                     </div>
                 </Box>
             </Fade>
-        </Modal >
+        </Modal>
     );
 }
 

ui-common/src/components/modals/ReplayRequestModal/interfaces.ts

@@ -1,13 +0,0 @@
-export interface KeyValuePair {
-    key: string;
-    value: unknown;
-}
-
-export interface IReplayRequestData {
-    method: string;
-    hostPort: string;
-    path: string;
-    postData: string;
-    headers: KeyValuePair[]
-    params: KeyValuePair[]
-}

ui-common/src/components/modals/ServiceMapModal/ServiceMapModal.module.sass

@@ -35,7 +35,6 @@ $modalMargin-from-edge : 35px
     color: $blue-gray
     font-weight: 600
     margin-right: 35px
-    white-space: nowrap
 
 .graphSection
   flex: 85%
@@ -75,7 +74,6 @@ $modalMargin-from-edge : 35px
   width: -moz-available
   width: -webkit-fill-available
   width: fill-available
-  width: strech
   max-width: 200px
   box-shadow: 0px 1px 5px #979797
   margin-left: 10px
@@ -97,4 +95,12 @@ $modalMargin-from-edge : 35px
   overflow: hidden
 
 .servicesFilterList
-  height: calc(100% - 30px - 52px)
+  height: calc(100% - 30px)
+
+.spinnerContainer
+  display: flex
+  justify-content: center
+  margin-bottom: 10px
+
+.protocolsFilterList
+  height: 100%

ui-common/src/components/modals/ServiceMapModal/ServiceMapModal.tsx

@@ -1,6 +1,7 @@
 import React, { useState, useEffect, useCallback, useMemo } from "react";
 import { Box, Fade, Modal, Backdrop, Button } from "@mui/material";
 import { toast } from "react-toastify";
+import spinnerImg from 'assets/spinner.svg';
 import Graph from "react-graph-vis";
 import debounce from 'lodash/debounce';
 import ServiceMapOptions from './ServiceMapOptions'
@@ -15,7 +16,6 @@ import { GraphData, ServiceMapGraph } from "./ServiceMapModalTypes"
 import { Utils } from "../../../helpers/Utils";
 import { TOAST_CONTAINER_ID } from "../../../configs/Consts";
 import Resizeable from "../../UI/Resizeable/Resizeable"
-import { LoadingWrapper } from "../../UI/withLoading/withLoading";
 
 const modalStyle = {
     position: 'absolute',
@@ -197,14 +197,14 @@ export const ServiceMapModal: React.FC<ServiceMapModalProps> = ({ isOpen, onClos
             <Fade in={isOpen}>
                 <Box sx={modalStyle}>
                     <div className={styles.closeIcon}>
-                        <img src={closeIcon} alt="close" onClick={() => onClose()} style={{ cursor: "pointer", userSelect: "none" }} />
+                        <img src={closeIcon} alt="close" onClick={() => onClose()} style={{ cursor: "pointer", userSelect: "none" }}/>
                     </div>
                     <div className={styles.headerContainer}>
                         <div className={styles.headerSection}>
                             <span className={styles.title}>Services</span>
                             <Button size="medium"
                                 variant="contained"
-                                startIcon={<img src={isFilterClicked ? filterIconClicked : filterIcon} className="custom" alt="refresh" style={{ height: "26px", width: "26px" }} />}
+                                startIcon={<img src={isFilterClicked ? filterIconClicked : filterIcon} className="custom" alt="refresh" style={{ height: "26px", width: "26px" }}/>}
                                 className={commonClasses.outlinedButton + " " + commonClasses.imagedButton + ` ${isFilterClicked ? commonClasses.clickedButton : ""}`}
                                 onClick={() => setIsFilterClicked(prevState => !prevState)}
                                 style={{ textTransform: 'unset' }}>
@@ -228,7 +228,7 @@ export const ServiceMapModal: React.FC<ServiceMapModalProps> = ({ isOpen, onClos
                                 <div className={styles.filterWrapper}>
                                     <div className={styles.card}>
                                         <SelectList items={getProtocolsForFilter} checkBoxWidth="5%" tableName={"PROTOCOLS"} multiSelect={true}
-                                            checkedValues={checkedProtocols} setCheckedValues={onProtocolsChange} tableClassName={styles.filters}
+                                            checkedValues={checkedProtocols} setCheckedValues={onProtocolsChange} tableClassName={styles.filters + ` ${styles.protocolsFilterList}`}
                                             inputSearchClass={styles.servicesFilterSearch} isFilterable={false} />
                                     </div>
                                     <div className={styles.servicesFilterWrapper + ` ${styles.card}`}>
@@ -243,14 +243,16 @@ export const ServiceMapModal: React.FC<ServiceMapModalProps> = ({ isOpen, onClos
                         <div className={styles.graphSection}>
                             <div style={{ display: "flex", justifyContent: "space-between" }}>
                             </div>
-                            <LoadingWrapper isLoading={isLoading} loaderHeight={50} loaderMargin={20}>
-                                <div style={{ height: "100%", width: "100%" }}>
-                                    <Graph
-                                        graph={graphData}
-                                        options={graphOptions}
-                                    />
-                                </div>
-                            </LoadingWrapper>
+                            {isLoading && <div className={styles.spinnerContainer}>
+                                <img alt="spinner" src={spinnerImg} style={{ height: 50 }} />
+                            </div>}
+                            {!isLoading && <div style={{ height: "100%", width: "100%" }}>
+                                <Graph
+                                    graph={graphData}
+                                    options={graphOptions}
+                                />
+                            </div>
+                            }
                         </div>
                     </div>
                 </Box>

ui-common/src/components/modals/TrafficStatsModal/TimelineBarChart/TimelineBarChart.module.sass

@@ -2,7 +2,3 @@
     width: 100%
     display: flex 
     justify-content: center
-
-.axisText
-    font-size: 12px
-    opacity: 0.9

ui-common/src/components/modals/TrafficStatsModal/TimelineBarChart/TimelineBarChart.tsx

@@ -1,4 +1,5 @@
 import styles from "./TimelineBarChart.module.sass";
+import { ALL_PROTOCOLS, StatsMode } from "../TrafficStatsModal"
 import React, { useEffect, useMemo, useState } from "react";
 import {
     BarChart,
@@ -8,7 +9,6 @@ import {
     Tooltip,
 } from "recharts";
 import { Utils } from "../../../../helpers/Utils";
-import { ALL_PROTOCOLS, StatsMode } from "../consts";
 
 interface TimelineBarChartProps {
     timeLineBarChartMode: string;
@@ -19,71 +19,72 @@ interface TimelineBarChartProps {
 export const TimelineBarChart: React.FC<TimelineBarChartProps> = ({ timeLineBarChartMode, data, selectedProtocol }) => {
     const [protocolStats, setProtocolStats] = useState([]);
     const [protocolsNamesAndColors, setProtocolsNamesAndColors] = useState([]);
-    const [methodsStats, setMethodsStats] = useState(null);
-    const [methodsNamesAndColors, setMethodsNamesAndColors] = useState(null);
+    const [commandStats, setCommandStats] = useState(null);
+    const [commandNames, setcommandNames] = useState(null);
 
     useEffect(() => {
         if (!data) return;
         const protocolsBarsData = [];
         const prtcNames = [];
         data.sort((a, b) => a.timestamp < b.timestamp ? -1 : 1).forEach(protocolObj => {
-            let newProtocolObj: { [k: string]: any } = {};
-            newProtocolObj.timestamp = Utils.formatDate(protocolObj.timestamp);
+            let newProtocolbj: { [k: string]: any } = {};
+            newProtocolbj.timestamp = Utils.getHoursAndMinutes(protocolObj.timestamp);
             protocolObj.protocols.forEach(protocol => {
-                newProtocolObj[`${protocol.name}`] = protocol[StatsMode[timeLineBarChartMode]];
+                newProtocolbj[`${protocol.name}`] = protocol[StatsMode[timeLineBarChartMode]];
                 prtcNames.push({ name: protocol.name, color: protocol.color });
             })
-            protocolsBarsData.push(newProtocolObj);
+            protocolsBarsData.push(newProtocolbj);
         })
-        const uniqueObjArray = Utils.createUniqueObjArrayByProp(prtcNames, "name")
+        const uniqueObjArray = Utils.creatUniqueObjArrayByProp(prtcNames, "name")
         setProtocolStats(protocolsBarsData);
         setProtocolsNamesAndColors(uniqueObjArray);
     }, [data, timeLineBarChartMode])
 
     useEffect(() => {
         if (selectedProtocol === ALL_PROTOCOLS) {
-            setMethodsStats(null);
-            setMethodsNamesAndColors(null);
+            setCommandStats(null);
+            setcommandNames(null);
             return;
         }
-        const protocolsMethodsNamesAndColors = [];
-        const protocolsMethods = [];
+        const commandsNames = [];
+        const protocolsCommands = [];
         data.sort((a, b) => a.timestamp < b.timestamp ? -1 : 1).forEach(protocolObj => {
-            let newMethodObj: { [k: string]: any } = {};
-            newMethodObj.timestamp = Utils.formatDate(protocolObj.timestamp);
-            protocolObj.protocols.find(protocol => protocol.name === selectedProtocol)?.methods.forEach(method => {
-                newMethodObj[`${method.name}`] = method[StatsMode[timeLineBarChartMode]]
-                protocolsMethodsNamesAndColors.push({ name: method.name, color: method.color });
+            let newCommandlbj: { [k: string]: any } = {};
+            newCommandlbj.timestamp = Utils.getHoursAndMinutes(protocolObj.timestamp);
+            protocolObj.protocols.find(protocol => protocol.name === selectedProtocol)?.methods.forEach(command => {
+                newCommandlbj[`${command.name}`] = command[StatsMode[timeLineBarChartMode]]
+                if (commandsNames.indexOf(command.name) === -1)
+                    commandsNames.push(command.name);
             })
-            protocolsMethods.push(newMethodObj);
+            protocolsCommands.push(newCommandlbj);
         })
-        const uniqueObjArray = Utils.createUniqueObjArrayByProp(protocolsMethodsNamesAndColors, "name")
-        setMethodsNamesAndColors(uniqueObjArray);
-        setMethodsStats(protocolsMethods);
+        setcommandNames(commandsNames);
+        setCommandStats(protocolsCommands);
     }, [data, timeLineBarChartMode, selectedProtocol])
 
-    const bars = useMemo(() => (methodsNamesAndColors || protocolsNamesAndColors).map((entry) => {
-        return <Bar key={entry.name} dataKey={entry.name} stackId="a" fill={entry.color} />
-    }), [protocolsNamesAndColors, methodsNamesAndColors])
+    const bars = useMemo(() => (commandNames || protocolsNamesAndColors).map((entry) => {
+        return <Bar key={entry.name || entry} dataKey={entry.name || entry} stackId="a" fill={entry.color || Utils.stringToColor(entry)} barSize={30} />
+    }), [protocolsNamesAndColors, commandNames])
 
     const renderTick = (tickProps) => {
         const { x, y, payload } = tickProps;
-        const { offset, value } = payload;
-        const pathX = Math.floor(x - offset) + 0.5;
+        const { index, value } = payload;
 
-        return <React.Fragment>
-            <text x={pathX} y={y + 10} textAnchor="middle" className={styles.axisText}>{`${value}`}</text>;
-            <path d={`M${pathX},${y - 4}v${-10}`} stroke="red" />;
-        </React.Fragment>
+        if (index % 3 === 0) {
+            return <text x={x} y={y + 10} textAnchor="end">{`${value}`}</text>;
+        }
+        return null;
     };
 
+
     return (
         <div className={styles.barChartContainer}>
             {protocolStats.length > 0 && <BarChart
                 width={750}
                 height={250}
-                data={methodsStats || protocolStats}
-                barCategoryGap={1}
+                data={commandStats || protocolStats}
+                barCategoryGap={0}
+                barSize={30}
                 margin={{
                     top: 20,
                     right: 30,
@@ -91,8 +92,8 @@ export const TimelineBarChart: React.FC<TimelineBarChartProps> = ({ timeLineBarC
                     bottom: 5
                 }}
             >
-                <XAxis dataKey="timestamp" tickLine={false} tick={renderTick} interval="preserveStart"/>
-                <YAxis tickFormatter={(value) => timeLineBarChartMode === "VOLUME" ? Utils.humanFileSize(value) : value} interval="preserveEnd" />
+                <XAxis dataKey="timestamp" tick={renderTick} tickLine={false} />
+                <YAxis tickFormatter={(value) => timeLineBarChartMode === "VOLUME" ? Utils.humanFileSize(value) : value} />
                 <Tooltip formatter={(value) => timeLineBarChartMode === "VOLUME" ? Utils.humanFileSize(value) : value + " Requests"} />
                 {bars}
             </BarChart>}

ui-common/src/components/modals/TrafficStatsModal/TrafficPieChart/TrafficPieChart.tsx

@@ -1,7 +1,7 @@
 import React, { useEffect, useMemo, useState } from "react";
 import { Cell, Legend, Pie, PieChart, Tooltip } from "recharts";
 import { Utils } from "../../../../helpers/Utils";
-import { ALL_PROTOCOLS ,StatsMode as PieChartMode } from "../consts"
+import { ALL_PROTOCOLS, StatsMode as PieChartMode } from "../TrafficStatsModal"
 
 const RADIAN = Math.PI / 180;
 const renderCustomizedLabel = ({
@@ -41,7 +41,7 @@ interface TrafficPieChartProps {
 export const TrafficPieChart: React.FC<TrafficPieChartProps> = ({ pieChartMode, data, selectedProtocol }) => {
 
   const [protocolsStats, setProtocolsStats] = useState([]);
-  const [methodsStats, setMethodsStats] = useState(null);
+  const [commandStats, setCommandStats] = useState(null);
 
   useEffect(() => {
     if (!data) return;
@@ -57,17 +57,16 @@ export const TrafficPieChart: React.FC<TrafficPieChartProps> = ({ pieChartMode,
 
   useEffect(() => {
     if (selectedProtocol === ALL_PROTOCOLS) {
-      setMethodsStats(null);
+      setCommandStats(null);
       return;
     }
-    const methodsPieData = data.find(protocol => protocol.name === selectedProtocol)?.methods.map(method => {
+    const commandsPieData = data.find(protocol => protocol.name === selectedProtocol)?.methods.map(command => {
       return {
-        name: method.name,
-        value: method[PieChartMode[pieChartMode]],
-        color: method.color
+        name: command.name,
+        value: command[PieChartMode[pieChartMode]]
       }
     })
-    setMethodsStats(methodsPieData);
+    setCommandStats(commandsPieData);
   }, [selectedProtocol, pieChartMode, data])
 
   const pieLegend = useMemo(() => {
@@ -83,7 +82,7 @@ export const TrafficPieChart: React.FC<TrafficPieChartProps> = ({ pieChartMode,
     } else {
       legend = data.find(protocol => protocol.name === selectedProtocol)?.methods.map((method) => <div
         style={{ marginBottom: 5, display: "flex" }}>
-        <div style={{ height: 15, width: 30, background: method.color}} />
+        <div style={{ height: 15, width: 30, background: Utils.stringToColor(method.name)}} />
         <span style={{ marginLeft: 5 }}>
           {method.name}
         </span>
@@ -97,7 +96,7 @@ export const TrafficPieChart: React.FC<TrafficPieChartProps> = ({ pieChartMode,
       {protocolsStats?.length > 0 && <div style={{ width: "100%", display: "flex", justifyContent: "center" }}>
         <PieChart width={300} height={300}>
           <Pie
-            data={methodsStats || protocolsStats}
+            data={commandStats || protocolsStats}
             dataKey="value"
             cx={150}
             cy={125}
@@ -105,8 +104,8 @@ export const TrafficPieChart: React.FC<TrafficPieChartProps> = ({ pieChartMode,
             label={renderCustomizedLabel}
             outerRadius={125}
             fill="#8884d8">
-            {(methodsStats || protocolsStats).map((entry, index) => (
-              <Cell key={`cell-${index}`} fill={entry.color} />)
+            {(commandStats || protocolsStats).map((entry, index) => (
+              <Cell key={`cell-${index}`} fill={entry.color || Utils.stringToColor(entry.name)} />)
             )}
           </Pie>
           <Legend wrapperStyle={{ position: "absolute", width: "auto", height: "auto", right: -150, top: 0 }} content={pieLegend} />

ui-common/src/components/modals/TrafficStatsModal/TrafficStatsModal.tsx

@@ -4,10 +4,9 @@ import styles from "./TrafficStatsModal.module.sass";
 import closeIcon from "assets/close.svg";
 import { TrafficPieChart } from "./TrafficPieChart/TrafficPieChart";
 import { TimelineBarChart } from "./TimelineBarChart/TimelineBarChart";
+import spinnerImg from "assets/spinner.svg";
 import refreshIcon from "assets/refresh.svg";
 import { useCommonStyles } from "../../../helpers/commonStyle";
-import { LoadingWrapper } from "../../UI/withLoading/withLoading";
-import { ALL_PROTOCOLS, StatsMode } from "./consts";
 
 const modalStyle = {
   position: 'absolute',
@@ -23,12 +22,21 @@ const modalStyle = {
   color: '#000',
 };
 
+export enum StatsMode {
+  REQUESTS = "entriesCount",
+  VOLUME = "volumeSizeBytes"
+}
+
 interface TrafficStatsModalProps {
   isOpen: boolean;
   onClose: () => void;
   getTrafficStatsDataApi: () => Promise<any>
 }
 
+
+export const PROTOCOLS = ["ALL", "gRPC", "REDIS", "HTTP", "GQL", "AMQP", "KAFKA"];
+export const ALL_PROTOCOLS = PROTOCOLS[0];
+
 export const TrafficStatsModal: React.FC<TrafficStatsModalProps> = ({ isOpen, onClose, getTrafficStatsDataApi }) => {
 
   const modes = Object.keys(StatsMode).filter(x => !(parseInt(x) >= 0));
@@ -36,7 +44,6 @@ export const TrafficStatsModal: React.FC<TrafficStatsModalProps> = ({ isOpen, on
   const [selectedProtocol, setSelectedProtocol] = useState(ALL_PROTOCOLS);
   const [pieStatsData, setPieStatsData] = useState(null);
   const [timelineStatsData, setTimelineStatsData] = useState(null);
-  const [protocols, setProtocols] = useState([])
   const [isLoading, setIsLoading] = useState(false);
   const commonClasses = useCommonStyles();
 
@@ -48,7 +55,6 @@ export const TrafficStatsModal: React.FC<TrafficStatsModalProps> = ({ isOpen, on
           const statsData = await getTrafficStatsDataApi();
           setPieStatsData(statsData.pie);
           setTimelineStatsData(statsData.timeline);
-          setProtocols(statsData.protocols)
         } catch (e) {
           console.error(e)
         } finally {
@@ -103,17 +109,18 @@ export const TrafficStatsModal: React.FC<TrafficStatsModalProps> = ({ isOpen, on
               <div>
                 <span style={{ marginRight: 15 }}>Protocol</span>
                 <select className={styles.select} value={selectedProtocol} onChange={(e) => setSelectedProtocol(e.target.value)}>
-                  {protocols.map(protocol => <option key={protocol} value={protocol}>{protocol}</option>)}
+                  {PROTOCOLS.map(protocol => <option key={protocol} value={protocol}>{protocol}</option>)}
                 </select>
               </div>
             </div>
             <div>
-              <LoadingWrapper isLoading={isLoading} loaderMargin={20} loaderHeight={50}>
+              {isLoading ? <div style={{ textAlign: "center", marginTop: 20 }}>
+                <img alt="spinner" src={spinnerImg} style={{ height: 50 }} />
+              </div> :
                 <div>
-                  <TrafficPieChart pieChartMode={statsMode} data={pieStatsData} selectedProtocol={selectedProtocol} />
-                  <TimelineBarChart timeLineBarChartMode={statsMode} data={timelineStatsData} selectedProtocol={selectedProtocol} />
-                </div>
-              </LoadingWrapper>
+                  <TrafficPieChart pieChartMode={statsMode} data={pieStatsData} selectedProtocol={selectedProtocol}/>
+                  <TimelineBarChart timeLineBarChartMode={statsMode} data={timelineStatsData} selectedProtocol={selectedProtocol}/>
+                </div>}
             </div>
           </div>
         </Box>

ui-common/src/components/modals/TrafficStatsModal/consts.ts

@@ -1,5 +0,0 @@
-export const ALL_PROTOCOLS = "ALL";
-export enum StatsMode {
-    REQUESTS = "entriesCount",
-    VOLUME = "volumeSizeBytes"
-  }

ui-common/src/helpers/Utils.ts

@@ -1,13 +1,5 @@
-import Moment from 'moment';
-
 const IP_ADDRESS_REGEX = /([0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3})(:([0-9]{1,5}))?/
 
-type JSONValue =
-  | string
-  | number
-  | boolean
-  | Object
-
 
 export class Utils {
   static isIpAddress = (address: string): boolean => IP_ADDRESS_REGEX.test(address)
@@ -45,21 +37,7 @@ export class Utils {
     return hoursAndMinutes;
   }
 
-  static formatDate = (date) => {
-    let d = new Date(date),
-        month = '' + (d.getMonth() + 1),
-        day = '' + d.getDate(),
-        year = d.getFullYear();
-    const hoursAndMinutes = Utils.getHoursAndMinutes(date);
-    if (month.length < 2) 
-        month = '0' + month;
-    if (day.length < 2) 
-        day = '0' + day;
-    const newDate = [year, month, day].join('-');
-    return [hoursAndMinutes, newDate].join(' ');
-}
-
-  static createUniqueObjArrayByProp = (objArray, prop) => {
+  static creatUniqueObjArrayByProp = (objArray, prop) => {
     const map = new Map(objArray.map((item) => [item[prop], item])).values()
     return Array.from(map);
   }
@@ -73,24 +51,17 @@ export class Utils {
     return true;
   }
 
-  static downloadFile = (data: string, filename: string, fileType: string) => {
-    const blob = new Blob([data], { type: fileType })
-    const a = document.createElement('a');
-    a.href = window.URL.createObjectURL(blob);
-    a.download = filename;
-    a.click();
-    a.remove();
+  static stringToColor = (str) => {
+    let colors = ["#e51c23", "#e91e63", "#9c27b0", "#673ab7", "#3f51b5", "#5677fc", "#03a9f4", "#00bcd4", "#009688", "#259b24", "#8bc34a", "#afb42b", "#ff9800", "#ff5722", "#795548", "#607d8b"]
+
+    let hash = 0;
+    if (str.length === 0) return hash;
+    for (let i = 0; i < str.length; i++) {
+      hash = str.charCodeAt(i) + ((hash << 5) - hash);
+      hash = hash & hash;
+    }
+    hash = ((hash % colors.length) + colors.length) % colors.length;
+    return colors[hash];
   }
 
-  static exportToJson = (data: JSONValue, name) => {
-    Utils.downloadFile(JSON.stringify(data), `${name}.json`, 'text/json')
-  }
-
-  static getTimeFormatted = (time: Moment.MomentInput) => {
-    return Moment(time).utc().format('MM/DD/YYYY, h:mm:ss.SSS A')
-  }
-
-  static getNow = (format: string = 'MM/DD/YYYY, HH:mm:ss.SSS') => {
-    return Moment().format(format)
-  }
 }

ui-common/src/index.tsx

@@ -7,5 +7,6 @@ import { ServiceMapModal } from './components/modals/ServiceMapModal/ServiceMapM
 import { TrafficStatsModal } from './components/modals/TrafficStatsModal/TrafficStatsModal';
 
 export { CodeEditorWrap as QueryForm } from './components/Filters/Filters';
-export { UI, StatusBar, OasModal, ServiceMapModal, TrafficStatsModal, TrafficViewer }
+export { UI, StatusBar, OasModal, ServiceMapModal, TrafficStatsModal }
 export { useWS, DEFAULT_LEFTOFF }
+export default TrafficViewer;

ui-common/src/recoil/entryDetailedConfig/atom.ts

@@ -1,12 +0,0 @@
-import { atom } from "recoil";
-
-const entryDetailedConfigAtom = atom({
-    key: "entryDetailedConfigAtom",
-    default: null
-});
-
-export type EntryDetailedConfig = {
-    isReplayEnabled: boolean
-}
-
-export default entryDetailedConfigAtom;

ui-common/src/recoil/entryDetailedConfig/index.ts

@@ -1,3 +0,0 @@
-import atom from "./atom"
-export type { EntryDetailedConfig } from "./atom"
-export default atom

ui/src/components/Pages/TrafficPage/TrafficPage.tsx

@@ -5,14 +5,13 @@ import debounce from 'lodash/debounce';
 import { useRecoilState } from "recoil";
 import { useCommonStyles } from "../../../helpers/commonStyle"
 import serviceMapModalOpenAtom from "../../../recoil/serviceMapModalOpen";
-import { TrafficViewer } from "@up9/mizu-common"
+import TrafficViewer from "@up9/mizu-common"
 import "@up9/mizu-common/dist/index.css"
 import oasModalOpenAtom from "../../../recoil/oasModalOpen/atom";
 import serviceMap from "../../assets/serviceMap.svg";
 import services from "../../assets/services.svg";
 import trafficStatsIcon from "../../assets/trafficStats.svg";
 import trafficStatsModalOpenAtom from "../../../recoil/trafficStatsModalOpen";
-import { REPLAY_ENABLED } from "../../../consts";
 
 const api = Api.getInstance();
 
@@ -41,41 +40,39 @@ export const TrafficPage: React.FC = () => {
   }, 500);
 
   const actionButtons = <div style={{ display: 'flex', height: "100%" }}>
-    {window["isOasEnabled"] && <Button
-      startIcon={<img className="custom" src={services} alt="services" />}
-      size="large"
-      variant="contained"
-      className={commonClasses.outlinedButton + " " + commonClasses.imagedButton}
-      style={{ marginRight: 25, textTransform: 'unset' }}
-      onClick={handleOpenOasModal}>
-      Service Catalog
-    </Button>}
-    {window["isServiceMapEnabled"] && <Button
-      startIcon={<img src={serviceMap} className="custom" alt="service-map" style={{ marginRight: "8%" }} />}
-      size="large"
-      variant="contained"
-      className={commonClasses.outlinedButton + " " + commonClasses.imagedButton}
-      onClick={openServiceMapModalDebounce}
-      style={{ marginRight: 25, textTransform: 'unset' }}>
-      Service Map
-    </Button>}
+      {window["isOasEnabled"] && <Button
+        startIcon={<img className="custom" src={services} alt="services" />}
+        size="large"
+        variant="contained"
+        className={commonClasses.outlinedButton + " " + commonClasses.imagedButton}
+        style={{ marginRight: 25, textTransform: 'unset' }}
+        onClick={handleOpenOasModal}>
+        Service Catalog
+      </Button>}
+      {window["isServiceMapEnabled"] && <Button
+        startIcon={<img src={serviceMap} className="custom" alt="service-map" style={{ marginRight: "8%" }} />}
+        size="large"
+        variant="contained"
+        className={commonClasses.outlinedButton + " " + commonClasses.imagedButton}
+        onClick={openServiceMapModalDebounce}
+        style={{ marginRight: 25, textTransform: 'unset' }}>
+        Service Map
+      </Button>}
     <Button
-      startIcon={<img className="custom" src={trafficStatsIcon} alt="services" />}
-      size="large"
-      variant="contained"
-      className={commonClasses.outlinedButton + " " + commonClasses.imagedButton}
-      style={{ textTransform: 'unset' }}
-      onClick={handleOpenStatsModal}>
+        startIcon={<img className="custom" src={trafficStatsIcon} alt="services" />}
+        size="large"
+        variant="contained"
+        className={commonClasses.outlinedButton + " " + commonClasses.imagedButton}
+        style={{ textTransform: 'unset' }}
+        onClick={handleOpenStatsModal}>
       Traffic Stats
     </Button>
-  </div>
+    </div>
 
   return (
     <>
       <TrafficViewer webSocketUrl={MizuWebsocketURL} shouldCloseWebSocket={shouldCloseWebSocket} setShouldCloseWebSocket={setShouldCloseWebSocket}
-        trafficViewerApiProp={trafficViewerApi} actionButtons={actionButtons} isShowStatusBar={!(openOasModal || serviceMapModalOpen || trafficStatsModalOpen)} isDemoBannerView={false} entryDetailedConfig={{
-          isReplayEnabled: REPLAY_ENABLED
-        }} />
+        trafficViewerApiProp={trafficViewerApi} actionButtons={actionButtons} isShowStatusBar={!(openOasModal || serviceMapModalOpen || trafficStatsModalOpen)} isDemoBannerView={false} />
     </>
   );
 };

ui/src/consts.ts

@@ -1,3 +1,2 @@
 export const adminUsername = "admin";
 export const TOAST_CONTAINER_ID = "Community";
-export const REPLAY_ENABLED = true;