github/kubescape
1
0
Fork 0
mirror of https://github.com/kubescape/kubescape.git synced 2026-04-15 06:58:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

append to msg, loop backward on ruleresponses, don't check redundant role/clusterrole k8sresources

Browse Source
This commit is contained in:
yiscah
2021-09-14 16:36:57 +03:00
parent 033ed17125
commit c869f2c962
1 changed files with 7 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cautils/opapolicy/datastructuresmethods.go
+7 -19
View File
@@ -122,13 +122,14 @@ func (ruleReport *RuleReport) GetNumberOfResources() int {
func (ruleReport *RuleReport) GetNumberOfFailedResources() int {
sum := 0
for i := 0; i < len(ruleReport.RuleResponses); i++ {
for i := len(ruleReport.RuleResponses) - 1; i >= 0; i-- {
if ruleReport.RuleResponses[i].GetSingleResultStatus() == "failed" {
if !ruleReport.DeleteIfRedundantResponse(&ruleReport.RuleResponses[i], i) {
sum += 1
} else {
i--
sum++
}
// else {
// i--
// }
}
}
return sum
@@ -144,20 +145,7 @@ func (ruleReport *RuleReport) DeleteIfRedundantResponse(RuleResponse *RuleRespon
}
func (ruleResponse *RuleResponse) AddMessageToResponse(message string) {
// fmt.Printf("adding message\n")
var messages []string
if m, exist := ruleResponse.AlertObject.ExternalObjects["additionalMessages"]; exist {
switch t := m.(type) {
case []string:
messages = append(t, message)
}
} else {
messages = append(messages, message)
}
if ruleResponse.AlertObject.ExternalObjects == nil {
ruleResponse.AlertObject.ExternalObjects = make(map[string]interface{})
}
ruleResponse.AlertObject.ExternalObjects["additionalMessages"] = messages
ruleResponse.AlertMessage += message
}
func (ruleReport *RuleReport) IsDuplicateResponseOfResource(RuleResponse *RuleResponse, index int) (bool, *RuleResponse) {
@@ -167,7 +155,7 @@ func (ruleReport *RuleReport) IsDuplicateResponseOfResource(RuleResponse *RuleRe
for k := range RuleResponse.AlertObject.K8SApiObjects {
w1 := k8sinterface.NewWorkloadObj(ruleReport.RuleResponses[i].AlertObject.K8SApiObjects[j])
w2 := k8sinterface.NewWorkloadObj(RuleResponse.AlertObject.K8SApiObjects[k])
if w1.GetName() == w2.GetName() && w1.GetNamespace() == w2.GetNamespace() {
if w1.GetName() == w2.GetName() && w1.GetNamespace() == w2.GetNamespace() && w1.GetKind() != "Role" && w1.GetKind() != "ClusterRole" {
return true, &ruleReport.RuleResponses[i]
}
}