Fix #127 Insecure Azure Cloud IP detection (#315)

* Fix Insecure Azure Cloud IP detection
Remove verify=False

Co-authored-by: blairch <15134348+blairch@users.noreply.github.com>
Co-authored-by: Yehuda Chikvashvili <yehudaac1@gmail.com>
This commit is contained in:
blrchen
2020-03-03 01:10:16 +02:00
committed by GitHub
co-authored by blairch Yehuda Chikvashvili
parent f33c04bd5b
commit 69a31f87e9
+2 -6
View File
@@ -55,12 +55,8 @@ class HostDiscoveryHelpers:
def get_cloud(host):
try:
logging.debug("Checking whether the cluster is deployed on azure's cloud")
# azurespeed.com provide their API via HTTP only; the service can be queried with
# HTTPS, but doesn't show a proper certificate. Since no encryption is worse then
# any encryption, we go with the verify=false option for the time being. At least
# this prevents leaking internal IP addresses to passive eavesdropping.
# TODO: find a more secure service to detect cloud IPs
metadata = requests.get("https://www.azurespeed.com/api/region?ipOrUrl={ip}".format(ip=host), verify=False).text
# Leverage 3rd tool https://github.com/blrchen/AzureSpeed for Azure cloud ip detection
metadata = requests.get(f"https://api.azurespeed.com/api/region?ipOrUrl={host}").text
except requests.ConnectionError as e:
logging.info("- unable to check cloud: {0}".format(e))
return