fix(tests): move test bindata to a dedicated directory

This ensures that test binary assets are not gonna get served over HTTP.

Makefile

@@ -49,7 +49,7 @@ endif
 	touch $@
 
 cmd/karma/bindata_assetfs.go: .build/deps-build-go.ok .build/artifacts-bindata_assetfs.$(GO_BINDATA_MODE) .build/artifacts-ui.ok
-	go-bindata-assetfs -o cmd/karma/bindata_assetfs.go ui/build/... ui/src/...
+	go-bindata-assetfs -o cmd/karma/bindata_assetfs.go ui/build/... ui/src/... cmd/karma/tests/bindata/...
 
 $(NAME): .build/deps-build-go.ok go.mod cmd/karma/bindata_assetfs.go $(SOURCES)
 	GO111MODULE=on go build -ldflags "-X main.version=$(VERSION)" ./cmd/karma
@@ -202,7 +202,7 @@ mock-assets: .build/deps-build-go.ok
 	rm -fr ui/build
 	mkdir ui/build
 	cp ui/public/* ui/build/
-	go-bindata-assetfs -o cmd/karma/bindata_assetfs.go -nometadata ui/build/...
+	go-bindata-assetfs -o cmd/karma/bindata_assetfs.go -nometadata ui/build/... cmd/karma/tests/bindata/...
 	# force assets rebuild on next make run
 	rm -f .build/bindata_assetfs.*
 

cmd/karma/assets_test.go

@@ -132,7 +132,7 @@ func TestLoadTemplateUnparsable(t *testing.T) {
 	var wasFatal bool
 	log.StandardLogger().ExitFunc = func(int) { wasFatal = true }
 
-	loadTemplate(nil, "ui/build/go-test-invalid.html")
+	loadTemplate(nil, "cmd/karma/tests/bindata/go-test-invalid.html")
 
 	if !wasFatal {
 		t.Error("loadTemplate() with unparsable file didn't cause log.Fatal()")

cmd/karma/script_test.go

@@ -53,6 +53,6 @@ func TestMain(m *testing.M) {
 
 func TestScripts(t *testing.T) {
 	testscript.Run(t, testscript.Params{
-		Dir: "testdata",
+		Dir: "tests/testscript",
 	})
 }