github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-07 03:26:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): check for duplicated values in AlertStore.filters.replaceFilter

Browse Source
This commit is contained in:
Łukasz Mierzwa
2018-08-20 17:10:27 +01:00
parent d7512d5ef3
commit dcc2f0c607
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
ui/src/Stores/AlertStore.js
View File

@@ -102,8 +102,15 @@ class AlertStore {
replaceFilter(oldRaw, newRaw) {
const index = this.values.findIndex(e => e.raw === oldRaw);
if (index >= 0) {
this.values[index] = newUnappliedFilter(newRaw);
UpdateLocationSearch({ q: this.values.map(f => f.raw) });
// first check if we would create a duplicated filter
if (this.values.findIndex(e => e.raw === newRaw) >= 0) {
// we already have newRaw, simply drop oldRaw
this.removeFilter(oldRaw);
} else {
// no dups, continue with a swap
this.values[index] = newUnappliedFilter(newRaw);
UpdateLocationSearch({ q: this.values.map(f => f.raw) });
}
}
},
setFilters(raws) {