github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-09 03:36:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #746 from prymitive/author-email

Browse Source 
fix(ui): allow any string as silence author, not just email
This commit is contained in:
Łukasz Mierzwa
2019-05-31 07:54:20 +01:00
committed by GitHub
parent f16122d734 3839d531e4
commit d76ac78dc9
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ui/src/Components/SilenceModal/SilenceForm.js
View File

@@ -162,9 +162,9 @@ const SilenceForm = observer(
</TooltipWrapper>
<DateTimeSelect silenceFormStore={silenceFormStore} />
<IconInput
type="email"
type="text"
autoComplete="email"
placeholder="Author email"
placeholder="Author"
icon={faUser}
value={silenceFormStore.data.author}
onChange={this.onAuthorChange}

6
ui/src/Components/SilenceModal/SilenceForm.test.js
View File

@@ -127,7 +127,7 @@ describe("<SilenceForm /> inputs", () => {
it("default author value comes from Settings store", () => {
settingsStore.silenceFormConfig.config.author = "foo@example.com";
const tree = MountedSilenceForm();
const input = tree.find("input[placeholder='Author email']");
const input = tree.find("input[placeholder='Author']");
expect(input.props().value).toBe("foo@example.com");
expect(silenceFormStore.data.author).toBe("foo@example.com");
});
@@ -135,14 +135,14 @@ describe("<SilenceForm /> inputs", () => {
it("default author value is empty if nothing is stored in Settings", () => {
settingsStore.silenceFormConfig.config.author = "";
const tree = MountedSilenceForm();
const input = tree.find("input[placeholder='Author email']");
const input = tree.find("input[placeholder='Author']");
expect(input.text()).toBe("");
expect(silenceFormStore.data.author).toBe("");
});
it("changing author input updates SilenceFormStore", () => {
const tree = MountedSilenceForm();
const input = tree.find("input[placeholder='Author email']");
const input = tree.find("input[placeholder='Author']");
input.simulate("change", { target: { value: "me@example.com" } });
expect(silenceFormStore.data.author).toBe("me@example.com");
});