github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-05 03:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correctly sort alerts in dedup code

Browse Source
This commit is contained in:
Łukasz Mierzwa
2017-07-01 10:01:35 -07:00
parent 68b8e5fecf
commit ca0403ea75
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
alertmanager/dedup.go
View File

@@ -33,8 +33,8 @@ func DedupAlerts() []models.AlertGroup {
if found {
for _, am := range alert.Alertmanager {
a.Alertmanager = append(a.Alertmanager, am)
alerts[alertLFP] = a
}
alerts[alertLFP] = a
} else {
alerts[alertLFP] = alert
}
@@ -43,6 +43,10 @@ func DedupAlerts() []models.AlertGroup {
ag := models.AlertGroup(agList[0])
ag.Alerts = models.AlertList{}
for _, alert := range alerts {
// sort Alertmanager instances for every alert
sort.Slice(alert.Alertmanager, func(i, j int) bool {
return alert.Alertmanager[i].Name < alert.Alertmanager[j].Name
})
ag.Alerts = append(ag.Alerts, alert)
}
sort.Sort(ag.Alerts)
@@ -52,7 +56,9 @@ func DedupAlerts() []models.AlertGroup {
// sort alert groups so they are always returned in the same order
// use group ID which is unique and immutable
sort.Slice(dedupedGroups, func(i, j int) bool { return dedupedGroups[i].ID < dedupedGroups[j].ID })
sort.Slice(dedupedGroups, func(i, j int) bool {
return dedupedGroups[i].ID < dedupedGroups[j].ID
})
return dedupedGroups
}