Don't set the default value for flags

Let envconfig handle defaults, setting it for flags means that we'll always pass a value to the env if there was a default one, meaning that we're unable to override via env
This commit is contained in:
Łukasz Mierzwa
2017-03-27 19:38:58 -07:00
parent 870036e497
commit c8348ba325

View File

@@ -77,7 +77,6 @@ func mapEnvConfigToFlags() {
}
envName := f.Tag.Get("envconfig")
defaultVal := f.Tag.Get("default")
helpMsg := fmt.Sprintf("%s. This flag can also be set via %s environment variable.", f.Tag.Get("help"), f.Tag.Get("envconfig"))
if f.Tag.Get("required") == "true" {
@@ -89,7 +88,7 @@ func mapEnvConfigToFlags() {
mapper.isBool = true
mapper.boolVal = flag.Bool(flagName, false, helpMsg)
} else {
mapper.stringVal = flag.String(flagName, defaultVal, helpMsg)
mapper.stringVal = flag.String(flagName, "", helpMsg)
}
flags[envName] = mapper
}