github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-21 04:33:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tests): add missing test coverage

Browse Source
This commit is contained in:
Łukasz Mierzwa
2020-02-12 15:12:54 +00:00
parent d0f59977b0
commit c76b3fcc0d
2 changed files with 75 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/karma/main.go
View File

@@ -281,9 +281,12 @@ func mainSetup(errorHandling pflag.ErrorHandling) (*gin.Engine, error) {
setupRouter(router)
for _, am := range alertmanager.GetAlertmanagers() {
err := setupRouterProxyHandlers(router, am)
if err != nil {
return nil, fmt.Errorf("Failed to setup proxy handlers for Alertmanager '%s': %s", am.Name, err)
if am.ProxyRequests {
log.Infof("[%s] Setting up proxy endpoints", am.Name)
err := setupRouterProxyHandlers(router, am)
if err != nil {
return nil, fmt.Errorf("Failed to setup proxy handlers for Alertmanager '%s': %s", am.Name, err)
}
}
}

90
cmd/karma/proxy_test.go
View File

@@ -7,6 +7,7 @@ import (
"time"
"github.com/prymitive/karma/internal/alertmanager"
"github.com/prymitive/karma/internal/config"
"github.com/jarcoal/httpmock"
)
@@ -230,29 +231,76 @@ func TestProxyToSubURIAlertmanager(t *testing.T) {
httpmock.Activate()
defer httpmock.DeactivateAndReset()
r := ginTestEngine()
am, err := alertmanager.NewAlertmanager(
"suburi",
"http://alertmanager.example.com/suburi",
alertmanager.WithRequestTimeout(time.Second*5),
alertmanager.WithProxy(true),
)
if err != nil {
t.Error(err)
}
err = setupRouterProxyHandlers(r, am)
if err != nil {
t.Errorf("Failed to setup proxy for Alertmanager %s: %s", am.Name, err)
type proxyTest struct {
alertmanagerURI string
requestURI string
listenPrefix string
}
httpmock.RegisterResponder("POST", "http://alertmanager.example.com/suburi/api/v2/silences", func(req *http.Request) (*http.Response, error) {
return httpmock.NewStringResponse(200, "ok"), nil
})
proxyTests := []proxyTest{
{
alertmanagerURI: "http://alertmanager.example.com/suburi",
requestURI: "/proxy/alertmanager/suburi/api/v2/silences",
listenPrefix: "/",
},
{
alertmanagerURI: "http://alertmanager.example.com/suburi/",
requestURI: "/proxy/alertmanager/suburi/api/v2/silences",
listenPrefix: "/",
},
{
alertmanagerURI: "http://alertmanager.example.com/suburi",
requestURI: "/suburi/proxy/alertmanager/suburi/api/v2/silences",
listenPrefix: "/suburi",
},
{
alertmanagerURI: "http://alertmanager.example.com/suburi/",
requestURI: "/suburi/proxy/alertmanager/suburi/api/v2/silences",
listenPrefix: "/suburi",
},
{
alertmanagerURI: "http://alertmanager.example.com/suburi",
requestURI: "/suburi/proxy/alertmanager/suburi/api/v2/silences",
listenPrefix: "/suburi/",
},
{
alertmanagerURI: "http://alertmanager.example.com/suburi/",
requestURI: "/suburi/proxy/alertmanager/suburi/api/v2/silences",
listenPrefix: "/suburi/",
},
}
req := httptest.NewRequest("POST", "/proxy/alertmanager/suburi/api/v2/silences", nil)
resp := newCloseNotifyingRecorder()
r.ServeHTTP(resp, req)
if resp.Code != 200 {
t.Errorf("Got response code %d instead of 200", resp.Code)
for _, testCase := range proxyTests {
t.Run(testCase.alertmanagerURI, func(t *testing.T) {
httpmock.Reset()
r := ginTestEngine()
config.Config.Listen.Prefix = testCase.listenPrefix
am, err := alertmanager.NewAlertmanager(
"suburi",
testCase.alertmanagerURI,
alertmanager.WithRequestTimeout(time.Second*5),
alertmanager.WithProxy(true),
)
if err != nil {
t.Error(err)
}
err = setupRouterProxyHandlers(r, am)
if err != nil {
t.Errorf("Failed to setup proxy for Alertmanager %s: %s", am.Name, err)
}
httpmock.RegisterResponder("POST", "http://alertmanager.example.com/suburi/api/v2/silences", func(req *http.Request) (*http.Response, error) {
return httpmock.NewStringResponse(200, "ok"), nil
})
req := httptest.NewRequest("POST", testCase.requestURI, nil)
resp := newCloseNotifyingRecorder()
r.ServeHTTP(resp, req)
if resp.Code != 200 {
t.Errorf("Got response code %d instead of 200", resp.Code)
}
})
}
}