github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-07 03:26:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): deduplicate filter in query args

Browse Source 
If we get same filter value multiple times we should only use it once
This commit is contained in:
Łukasz Mierzwa
2019-08-14 18:51:52 +01:00
parent 380c5543a4
commit be5b19c8d8
2 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ui/src/Stores/AlertStore.js
View File

@@ -46,8 +46,11 @@ function DecodeLocationSearch(searchString) {
if (parsed.q === "") {
params.q = [];
} else if (Array.isArray(parsed.q)) {
// filter out empty strings, so 'q=' doesn't end up [""] but rather []
params.q = parsed.q.filter(v => v !== "");
// first filter out duplicates
// then filter out empty strings, so 'q=' doesn't end up [""] but rather []
params.q = parsed.q
.filter((v, i) => parsed.q.indexOf(v) === i)
.filter(v => v !== "");
} else {
params.q = [parsed.q];
}

21
ui/src/Stores/AlertStore.test.js
View File

@@ -181,6 +181,13 @@ describe("DecodeLocationSearch", () => {
});
});
it("no value q[]=&q[]= search param is decoded correctly", () => {
expect(DecodeLocationSearch("?q=")).toMatchObject({
defaultsUsed: false,
params: { q: [] }
});
});
it("single value q=foo search param is decoded correctly", () => {
expect(DecodeLocationSearch("?q=foo")).toMatchObject({
defaultsUsed: false,
@@ -201,6 +208,20 @@ describe("DecodeLocationSearch", () => {
params: { q: ["foo", "bar"] }
});
});
it("multi value q[]=foo&q[]=bar&q[]=foo search param is decoded correctly", () => {
expect(DecodeLocationSearch("?q[]=foo&q[]=bar&q[]=foo")).toMatchObject({
defaultsUsed: false,
params: { q: ["foo", "bar"] }
});
});
it("multi value q[]=foo&q[]=&q[]=foo search param is decoded correctly", () => {
expect(DecodeLocationSearch("?q[]=foo&q[]=&q[]=foo")).toMatchObject({
defaultsUsed: false,
params: { q: ["foo"] }
});
});
});
describe("UpdateLocationSearch", () => {