github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-07 03:26:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use a Set() instead of array

Browse Source 
We only want unique values, Set is better for this
This commit is contained in:
Łukasz Mierzwa
2017-08-12 19:57:30 -07:00
parent f0dc85ad0b
commit 9645287d88
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
assets/static/filters.js
View File

@@ -93,7 +93,7 @@ function appendFilterToHistory(text) {
if (!text || !appendsEnabled) return false;
// final filter list we'll save to storage
var filterList = [ text ];
var filterList = new Set([ text ]);
// get current history list from storage and append it to our final list
// of filters, but avoid duplicates
@@ -101,17 +101,14 @@ function appendFilterToHistory(text) {
if (history) {
const historyArr = history.split("\n");
for (var i = 0; i < historyArr.length; i++) {
var h = historyArr[i];
if (filterList.indexOf(h) < 0) {
filterList.push(h);
}
filterList.add(historyArr[i]);
}
}
// truncate the history to up to 11 elements
filterList = filterList.slice(0, 11);
const filterListTrunc = Array.from(filterList).slice(0, 11);
historyStorage.setItem(historyKey, filterList.join("\n"));
historyStorage.setItem(historyKey, filterListTrunc.join("\n"));
}
function setFilters() {