Merge pull request #93 from prymitive/drop-onchanges

chore(tests): drop onchanges, not used frequently, not needed

Makefile

@@ -133,14 +133,6 @@ test-go: .build/vendor.ok
 test-js: .build/deps-build-node.ok
 	cd ui && CI=true npm test -- --coverage
 
-.PHONY: test-js-watch
-test-js-watch: .build/deps-build-node.ok
-	@# hitting issues with jest --watch due to
-	@# https://github.com/facebook/jest/issues/3436
-	@# use onchange for now
-	cd ui && ./node_modules/onchange/cli.js 'src/*.js' 'src/**/*.js' -- \
-		npm test -- --coverage --coverageReporters=lcov
-
 .PHONY: test
 test: lint test-go test-js
 

ui/package-lock.json

@@ -8801,12 +8801,6 @@
       "resolved": "https://registry.npmjs.org/next-tick/-/next-tick-1.0.0.tgz",
       "integrity": "sha1-yobR/ogoFpsBICCOPchCS524NCw="
     },
-    "nice-try": {
-      "version": "1.0.4",
-      "resolved": "https://registry.npmjs.org/nice-try/-/nice-try-1.0.4.tgz",
-      "integrity": "sha512-2NpiFHqC87y/zFke0fC0spBXL3bBsoh/p5H1EFhshxjCR5+0g2d6BiXbUFz9v1sAcxsk2htp2eQnNIci2dIYcA==",
-      "dev": true
-    },
     "no-case": {
       "version": "2.3.2",
       "resolved": "https://registry.npmjs.org/no-case/-/no-case-2.3.2.tgz",
@@ -9201,40 +9195,6 @@
         "wrappy": "1.0.2"
       }
     },
-    "onchange": {
-      "version": "4.1.0",
-      "resolved": "https://registry.npmjs.org/onchange/-/onchange-4.1.0.tgz",
-      "integrity": "sha512-xSuX6stJmPO+V1CBFYUdVS7AzuH2nyXXzW6OW7HLXaBa9Pc7bFGcjCXTha575wTeEe2N8p1gIQhwLMDNU15YPg==",
-      "dev": true,
-      "requires": {
-        "arrify": "1.0.1",
-        "chokidar": "2.0.3",
-        "cross-spawn": "6.0.5",
-        "minimist": "1.2.0",
-        "tree-kill": "1.2.0"
-      },
-      "dependencies": {
-        "cross-spawn": {
-          "version": "6.0.5",
-          "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-6.0.5.tgz",
-          "integrity": "sha512-eTVLrBSt7fjbDygz805pMnstIs2VTBNkRm0qxZd+M7A5XDdxVRWO5MxGBXZhjY4cqLYLdtrGqRf8mBPmzwSpWQ==",
-          "dev": true,
-          "requires": {
-            "nice-try": "1.0.4",
-            "path-key": "2.0.1",
-            "semver": "5.5.0",
-            "shebang-command": "1.2.0",
-            "which": "1.3.1"
-          }
-        },
-        "minimist": {
-          "version": "1.2.0",
-          "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
-          "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=",
-          "dev": true
-        }
-      }
-    },
     "onetime": {
       "version": "2.0.1",
       "resolved": "https://registry.npmjs.org/onetime/-/onetime-2.0.1.tgz",
@@ -12856,12 +12816,6 @@
       "resolved": "https://registry.npmjs.org/traverse/-/traverse-0.6.6.tgz",
       "integrity": "sha1-y99WD9e5r2MlAv7UD5GMFX6pcTc="
     },
-    "tree-kill": {
-      "version": "1.2.0",
-      "resolved": "https://registry.npmjs.org/tree-kill/-/tree-kill-1.2.0.tgz",
-      "integrity": "sha512-DlX6dR0lOIRDFxI0mjL9IYg6OTncLm/Zt+JiBhE5OlFcAR8yc9S7FFXU9so0oda47frdM/JFsk7UjNt9vscKcg==",
-      "dev": true
-    },
     "trim-newlines": {
       "version": "1.0.0",
       "resolved": "https://registry.npmjs.org/trim-newlines/-/trim-newlines-1.0.0.tgz",

ui/package.json

@@ -62,7 +62,6 @@
     "jest-fetch-mock": "1.6.6",
     "jest-localstorage-mock": "2.2.0",
     "markdownlint-cli": "0.13.0",
-    "node-sass": "4.9.3",
-    "onchange": "4.1.0"
+    "node-sass": "4.9.3"
   }
 }