github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-02-13 20:59:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): first try healthy cluster members

Browse Source
This commit is contained in:
Łukasz Mierzwa
2024-04-03 17:26:21 +01:00
committed by Łukasz Mierzwa
parent a049b0fe1a
commit 8009f4aa58
2 changed files with 93 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

86
ui/src/Stores/AlertStore.test.ts
View File

@@ -94,6 +94,92 @@ describe("AlertStore.data", () => {
store.data.getClusterAlertmanagersWithoutReadOnly("default"),
).toEqual([]);
});
it("clustersWithoutReadOnly lists healthy members first", () => {
const store = new AlertStore([]);
store.data.setUpstreams({
counters: { total: 2, healthy: 1, failed: 1 },
clusters: { default: ["am1", "am2"] },
instances: [
{
name: "am1",
uri: "http://localhost",
publicURI: "http://example.com:8080",
readonly: false,
headers: { foo: "bar" },
corsCredentials: "include",
error: "bad",
version: "0.24.0",
cluster: "default",
clusterMembers: ["am1", "am2"],
},
{
name: "am2",
uri: "http://localhost:8081",
publicURI: "http://example.com",
readonly: false,
headers: {},
corsCredentials: "include",
error: "",
version: "0.24.0",
cluster: "default",
clusterMembers: ["am1", "am2"],
},
],
});
expect(store.data.clustersWithoutReadOnly).toEqual({
default: ["am2", "am1"],
});
});
it("clustersWithoutReadOnly keeps healthy order", () => {
const store = new AlertStore([]);
store.data.setUpstreams({
counters: { total: 3, healthy: 3, failed: 0 },
clusters: { default: ["am1", "am2", "am3"] },
instances: [
{
name: "am1",
uri: "http://localhost",
publicURI: "http://example.com:8080",
readonly: false,
headers: { foo: "bar" },
corsCredentials: "include",
error: "",
version: "0.24.0",
cluster: "default",
clusterMembers: ["am1", "am2", "am3"],
},
{
name: "am2",
uri: "http://localhost:8081",
publicURI: "http://example.com",
readonly: false,
headers: {},
corsCredentials: "include",
error: "",
version: "0.24.0",
cluster: "default",
clusterMembers: ["am1", "am2", "am3"],
},
{
name: "am3",
uri: "http://localhost:8081",
publicURI: "http://example.com",
readonly: false,
headers: {},
corsCredentials: "include",
error: "",
version: "0.24.0",
cluster: "default",
clusterMembers: ["am1", "am2", "am3"],
},
],
});
expect(store.data.clustersWithoutReadOnly).toEqual({
default: ["am1", "am2", "am3"],
});
});
});
describe("AlertStore.status", () => {

8
ui/src/Stores/AlertStore.ts
View File

@@ -335,13 +335,19 @@ class AlertStore {
);
},
get clustersWithoutReadOnly(): APIAlertsResponseUpstreamsClusterMapT {
const unhealthy = this.upstreams.instances
.filter((upstream) => upstream.error !== "")
.map((upstream) => upstream.name);
const clusters: APIAlertsResponseUpstreamsClusterMapT = {};
for (const clusterID of Object.keys(this.upstreams.clusters)) {
const members = this.upstreams.clusters[clusterID].filter(
(member) => this.isReadOnlyAlertmanager(member) === false,
);
if (members.length > 0) {
clusters[clusterID] = members;
clusters[clusterID] = [
...members.filter((member) => !unhealthy.includes(member)),
...members.filter((member) => unhealthy.includes(member)),
];
}
}
return clusters;