github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-07 03:26:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #82 from prymitive/error-limit

Browse Source 
fix(ui): don't let multiple exceptions set multiple timers
This commit is contained in:
Łukasz Mierzwa
2018-09-28 07:43:17 +01:00
committed by GitHub
parent 2e03530cf3 bfa021aabf
commit 6851238ca4
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ui/src/ErrorBoundary.js
View File

@@ -35,6 +35,7 @@ class ErrorBoundary extends Component {
constructor(props) {
super(props);
this.timer = null;
this.state = { cachedError: null, reloadSeconds: 60 };
}
@@ -55,7 +56,10 @@ class ErrorBoundary extends Component {
});
Sentry.captureException(error);
// reload after 60s, this is to fix wall monitors automatically
setInterval(this.reloadApp, 1000);
// but only if the timer isn't set yet
if (this.timer === null) {
this.timer = setInterval(this.reloadApp, 1000);
}
}
render() {

15
ui/src/ErrorBoundary.test.js
View File

@@ -70,4 +70,19 @@ describe("<ErrorBoundary />", () => {
expect(reloadSpy).toHaveBeenCalled();
expect(consoleSpy).toHaveBeenCalled();
});
it("reloadSeconds is 40 after 20s with multiple exceptions", () => {
jest.spyOn(console, "error").mockImplementation(() => {});
const tree = MountedFailingComponent();
const instance = tree.instance();
instance.componentDidCatch("foo", { foo: "bar" });
jest.runTimersToTime(1000 * 10);
instance.componentDidCatch("foo", { foo: "bar" });
jest.runTimersToTime(1000 * 5);
instance.componentDidCatch("foo", { foo: "bar" });
jest.runTimersToTime(1000 * 5);
instance.componentDidCatch("foo", { foo: "bar" });
expect(tree.instance().state.reloadSeconds).toBe(40);
});
});