Merge pull request #1424 from prymitive/more-tests

fix(tests): more test coverage

cmd/karma/auth_headers_test.go

@@ -0,0 +1,147 @@
+package main
+
+import (
+	"fmt"
+	"net/http"
+	"testing"
+	"time"
+
+	"github.com/jarcoal/httpmock"
+	cache "github.com/patrickmn/go-cache"
+	"github.com/prymitive/karma/internal/alertmanager"
+	"github.com/prymitive/karma/internal/mock"
+)
+
+type authHeaderTest struct {
+	alertmanagerURI  string
+	alertmanagerHost string
+	authUser         string
+	authPass         string
+	headers          map[string]string
+}
+
+var authHeaderTests = []authHeaderTest{
+	// API v1
+	{
+		alertmanagerURI:  "http://localhost:9093",
+		alertmanagerHost: "localhost:9093",
+	},
+	{
+		alertmanagerURI:  "http://alertmanager.example.com",
+		alertmanagerHost: "alertmanager.example.com",
+	},
+	{
+		alertmanagerURI:  "http://foo:bar@alertmanager.example.com",
+		alertmanagerHost: "alertmanager.example.com",
+		authUser:         "foo",
+		authPass:         "bar",
+	},
+	{
+		alertmanagerURI:  "http://foo@alertmanager.example.com",
+		alertmanagerHost: "alertmanager.example.com",
+		authUser:         "foo",
+		authPass:         "",
+	},
+	// API v2
+	{
+		alertmanagerURI:  "http://localhost:9093",
+		alertmanagerHost: "localhost:9093",
+	},
+	{
+		alertmanagerURI:  "http://alertmanager.example.com",
+		alertmanagerHost: "alertmanager.example.com",
+	},
+	{
+		alertmanagerURI:  "http://foo:bar@alertmanager.example.com",
+		alertmanagerHost: "alertmanager.example.com",
+		authUser:         "foo",
+		authPass:         "bar",
+	},
+	{
+		alertmanagerURI:  "http://foo@alertmanager.example.com",
+		alertmanagerHost: "alertmanager.example.com",
+		authUser:         "foo",
+		authPass:         "",
+	},
+	{
+		alertmanagerURI:  "http://alertmanager.example.com",
+		alertmanagerHost: "alertmanager.example.com",
+		headers:          map[string]string{"X-Foo": "Bar", "X-Auth": "None"},
+	},
+	{
+		alertmanagerURI:  "http://foo@alertmanager.example.com",
+		alertmanagerHost: "alertmanager.example.com",
+		headers:          map[string]string{"X-Foo": "Bar", "X-Auth": "None"},
+	},
+	{
+		alertmanagerURI:  "http://foo:bar@alertmanager.example.com",
+		alertmanagerHost: "alertmanager.example.com",
+		headers:          map[string]string{"X-Foo": "Bar", "X-Auth": "None"},
+	},
+}
+
+func TestAuthHeader(t *testing.T) {
+	httpmock.Activate()
+	defer httpmock.DeactivateAndReset()
+
+	for _, testCase := range authHeaderTests {
+		testCase := testCase //scopelint pin
+		for _, version := range mock.ListAllMocks() {
+			apiCache = cache.New(cache.NoExpiration, 10*time.Second)
+
+			am, err := alertmanager.NewAlertmanager(
+				"dummy",
+				testCase.alertmanagerURI,
+				alertmanager.WithRequestTimeout(time.Second*5),
+				alertmanager.WithHTTPHeaders(testCase.headers),
+			)
+			if err != nil {
+				t.Error(err)
+			}
+
+			httpmock.Reset()
+
+			for _, m := range []string{
+				"metrics",
+				"api/v1/status", "api/v2/status",
+				"api/v1/silences", "api/v2/silences",
+				"api/v1/alerts/groups", "api/v2/alerts/groups"} {
+
+				uri := fmt.Sprintf("http://%s/%s", testCase.alertmanagerHost, m)
+
+				responder := mock.GetMockResponder(uri, version, m)
+				if responder == nil {
+					continue
+				}
+				httpmock.RegisterResponder("GET", uri,
+					func(req *http.Request) (*http.Response, error) {
+						if req.Host != testCase.alertmanagerHost {
+							t.Errorf("req.Host is '%s' while '%s' was expected", req.Host, testCase.alertmanagerHost)
+						}
+						if req.Header.Get("Host") != "" {
+							t.Errorf("req.Header.Host is '%s' while '%s' was expected", req.Header.Get("Host"), testCase.alertmanagerHost)
+						}
+						if testCase.authUser != "" || testCase.authPass != "" {
+							user, password, _ := req.BasicAuth()
+							if testCase.authUser != "" && testCase.authUser != user {
+								t.Errorf("%s was expected to have Basic Auth user '%s', got '%s'",
+									testCase.alertmanagerURI, testCase.authUser, user)
+							}
+							if testCase.authPass != "" && testCase.authPass != password {
+								t.Errorf("%s was expected to have Basic Auth password '%s', got '%s'",
+									testCase.alertmanagerURI, testCase.authPass, password)
+							}
+						}
+						for k, v := range testCase.headers {
+							if req.Header.Get(k) != v {
+								t.Errorf("%s was expecting headers %s=%s, got %s", testCase.alertmanagerURI, k, v, req.Header.Get(k))
+							}
+						}
+						return responder(req)
+					})
+			}
+
+			_ = am.Pull()
+		}
+	}
+}

internal/mock/mock.go

@@ -18,24 +18,29 @@ func GetAbsoluteMockPath(filename string, version string) string {
 	return path.Join(cwd, version, filename)
 }
 
-// RegisterURL for given url and return 200 status register mock http responder
-func RegisterURL(url string, version string, filename string) {
+// GetMockResponder returns a httpmock.Responder for given file/version
+func GetMockResponder(url string, version string, filename string) httpmock.Responder {
 	fullPath := GetAbsoluteMockPath(filename, version)
 
 	if _, err := os.Stat(fullPath); err != nil {
 		if os.IsNotExist(err) {
-			return
+			return nil
 		}
 	}
 
 	mockJSON, err := ioutil.ReadFile(fullPath)
 	if err != nil {
-		panic(err)
+		panic(fmt.Errorf("failed to read %s: %s", fullPath, err))
 	}
 	if len(mockJSON) == 0 {
 		panic(fmt.Errorf("empty mock file '%s'", fullPath))
 	}
-	httpmock.RegisterResponder("GET", url, httpmock.NewBytesResponder(200, mockJSON))
+	return httpmock.NewBytesResponder(200, mockJSON)
+}
+
+// RegisterURL for given url and return 200 status register mock http responder
+func RegisterURL(url string, version string, filename string) {
+	httpmock.RegisterResponder("GET", url, GetMockResponder(url, version, filename))
 }
 
 // ListAllMocks will return a list of all mock versions we have files for