github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-05 03:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tests): pass --unhandled-rejections=strict to nodejs

Browse Source 
This fails tests when there are unhandled promise rejections
This commit is contained in:
Łukasz Mierzwa
2020-04-11 21:47:00 +01:00
committed by Łukasz Mierzwa
parent ceb7e0eb93
commit 2a6cbdc827
4 changed files with 26 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ui/Makefile
View File

@@ -15,7 +15,7 @@ build: build/index.html
.PHONY: test-js
test-js: node_modules/jest/bin/jest.js
CI=true npm test -- --coverage
CI=true NODE_OPTIONS="--unhandled-rejections=strict" npm test -- --coverage
.PHONY: test-percy
test-percy: node_modules/@storybook/react/bin/build.js

9
ui/src/Components/Grid/AlertGrid/AlertGroup/Alert/AlertMenu.test.js
View File

@@ -1,4 +1,5 @@
import React from "react";
import { act } from "react-dom/test-utils";
import { mount } from "enzyme";
@@ -58,14 +59,17 @@ describe("<AlertMenu />", () => {
expect(tree.instance().collapse.value).toBe(true);
});
it("clicking toggle sets collapse value to 'false'", () => {
it("clicking toggle sets collapse value to 'false'", async () => {
const promise = Promise.resolve();
const tree = MountedAlertMenu(group);
const toggle = tree.find(".cursor-pointer");
toggle.simulate("click");
expect(tree.instance().collapse.value).toBe(false);
await act(() => promise);
});
it("handleClickOutside() call sets collapse value to 'true'", () => {
it("handleClickOutside() call sets collapse value to 'true'", async () => {
const promise = Promise.resolve();
const tree = MountedAlertMenu(group);
const toggle = tree.find(".cursor-pointer");
toggle.simulate("click");
@@ -74,6 +78,7 @@ describe("<AlertMenu />", () => {
tree.instance().handleClickOutside();
expect(tree.instance().collapse.value).toBe(true);
await act(() => promise);
});
});

11
ui/src/Components/Grid/AlertGrid/AlertGroup/GroupHeader/GroupMenu.test.js
View File

@@ -1,4 +1,5 @@
import React from "react";
import { act } from "react-dom/test-utils";
import { mount } from "enzyme";
@@ -57,25 +58,29 @@ describe("<GroupMenu />", () => {
expect(tree.instance().collapse.value).toBe(true);
});
it("clicking toggle sets collapse value to 'false'", () => {
it("clicking toggle sets collapse value to 'false'", async () => {
const promise = Promise.resolve();
const group = MockAlertGroup({ alertname: "Fake Alert" }, [], [], {}, {});
const tree = MountedGroupMenu(group, true);
const toggle = tree.find(".cursor-pointer");
toggle.simulate("click");
expect(tree.instance().collapse.value).toBe(false);
await act(() => promise);
});
it("handleClickOutside() call sets collapse value to 'true'", () => {
it("handleClickOutside() call sets collapse value to 'true'", async () => {
const promise = Promise.resolve();
const group = MockAlertGroup({ alertname: "Fake Alert" }, [], [], {}, {});
const tree = MountedGroupMenu(group, true);
const toggle = tree.find(".cursor-pointer");
toggle.simulate("click");
expect(tree.instance().collapse.value).toBe(false);
tree.instance().handleClickOutside();
expect(tree.instance().collapse.value).toBe(true);
await act(() => promise);
});
});

13
ui/src/Components/NavBar/FilterInput/History.test.js
View File

@@ -1,4 +1,5 @@
import React from "react";
import { act } from "react-dom/test-utils";
import { mount, shallow } from "enzyme";
@@ -82,24 +83,29 @@ describe("<History />", () => {
// Due to https://github.com/FezVrasta/popper.js/issues/478 we can't test
// rendered dropdown content, only the fact that toggle value is updated
it("renders dropdown button when menu is visible", () => {
it("renders dropdown button when menu is visible", async () => {
const promise = Promise.resolve();
const tree = MountedHistory();
const toggle = tree.find("button");
expect(tree.instance().collapse.value).toBe(true);
toggle.simulate("click");
expect(tree.instance().collapse.value).toBe(false);
await act(() => promise);
});
it("hides when handleClickOutside() is called", () => {
it("hides when handleClickOutside() is called", async () => {
const promise = Promise.resolve();
const tree = MountedHistory();
const instance = tree.instance();
instance.collapse.value = false;
instance.handleClickOutside();
expect(tree.instance().collapse.value).toBe(true);
await act(() => promise);
});
it("saves only applied filters to history", () => {
it("saves only applied filters to history", async () => {
const promise = Promise.resolve();
alertStore.filters.values = [
AppliedFilter("foo", "=", "bar"),
NewUnappliedFilter("foo=unapplied"),
@@ -114,6 +120,7 @@ describe("<History />", () => {
ReduceFilter(AppliedFilter("baz", "!=", "bar")),
])
);
await act(() => promise);
});
});