github/karma
1
0
Fork 0
mirror of https://github.com/prymitive/karma synced 2026-05-11 03:46:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #108 from cloudflare/codacy-fixes

Browse Source 
Codacy fixes
This commit is contained in:
Łukasz Mierzwa
2017-05-30 18:11:59 +01:00
committed by GitHub
parent 667a6278c6 fa28d43059
commit 2371a8a927
5 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Dockerfile
View File

@@ -1,6 +1,6 @@
FROM golang:1.8.1-alpine
ADD . /go/src/github.com/cloudflare/unsee
COPY . /go/src/github.com/cloudflare/unsee
ARG VERSION

2
filters/filter_test.go
View File

@@ -533,7 +533,7 @@ func TestLimitFilter(t *testing.T) {
}
if f.GetIsValid() {
alert := models.Alert{}
var index int = 0
var index int
for _, isMatch := range ft.IsMatch {
m := f.Match(&alert, index)
if m != isMatch {

2
mock/livemock.py
View File

@@ -1,8 +1,6 @@
#!/usr/bin/env python
import os
import time
import json
import requests
requests.post('http://localhost:9093/api/v1/silences',

14
store/store_test.go
View File

@@ -9,7 +9,7 @@ import (
type silenceTest struct {
silences map[string]models.Silence
silenceId string
silenceID string
found bool
}
@@ -18,7 +18,7 @@ var silenceTests = []silenceTest{
silences: map[string]models.Silence{
"1": models.Silence{},
},
silenceId: "1",
silenceID: "1",
found: true,
},
silenceTest{
@@ -27,12 +27,12 @@ var silenceTests = []silenceTest{
"2": models.Silence{},
"3": models.Silence{},
},
silenceId: "2",
silenceID: "2",
found: true,
},
silenceTest{
silences: map[string]models.Silence{},
silenceId: "1",
silenceID: "1",
found: false,
},
silenceTest{
@@ -40,7 +40,7 @@ var silenceTests = []silenceTest{
"2": models.Silence{},
"3": models.Silence{},
},
silenceId: "1",
silenceID: "1",
found: false,
},
}
@@ -48,10 +48,10 @@ var silenceTests = []silenceTest{
func TestSilences(t *testing.T) {
for _, testCase := range silenceTests {
store.Store.SetSilences(testCase.silences)
silence := store.Store.GetSilence(testCase.silenceId)
silence := store.Store.GetSilence(testCase.silenceID)
found := silence != nil
if found != testCase.found {
t.Errorf("GetSilence('%s') returned %v, %v was expected", testCase.silenceId, found, testCase.found)
t.Errorf("GetSilence('%s') returned %v, %v was expected", testCase.silenceID, found, testCase.found)
}
}
}

2
transform/color_test.go
View File

@@ -74,7 +74,7 @@ func TestColorLabel(t *testing.T) {
}
for key, valueMap := range colorStore {
if _, found := testCase.colors[key]; found {
for value, _ := range valueMap {
for value := range valueMap {
if value != testCase.colors[key] {
t.Errorf("Unexpected value '%s' for label '%s' found in color map", value, key)
}