github/flagger
1
0
Fork 0
mirror of https://github.com/fluxcd/flagger.git synced 2026-08-29 02:37:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

use the existing labelSelector value instead of using the service name as the value

Browse Source
This commit is contained in:
Forrest Thomas
2020-09-02 12:46:02 -07:00
parent c6f3a87bb3
commit f70f43bb3d
9 changed files with 43 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/controller/finalizer.go
+2 -2
View File
@@ -50,13 +50,13 @@ func (c *Controller) finalize(old interface{}) error {
return fmt.Errorf("canary not ready during finalizing: %w", err)
}
labelSelector, ports, err := canaryController.GetMetadata(canary)
labelSelector, labelValue, ports, err := canaryController.GetMetadata(canary)
if err != nil {
return fmt.Errorf("failed to get metadata for router finalizing: %w", err)
}
// Revert the Kubernetes service
router := c.routerFactory.KubernetesRouter(canary.Spec.TargetRef.Kind, labelSelector, ports)
router := c.routerFactory.KubernetesRouter(canary.Spec.TargetRef.Kind, labelSelector, labelValue, ports)
if err := router.Finalize(canary); err != nil {
return fmt.Errorf("failed revert router: %w", err)
}