Update Istio to v1.3.3

pkg/controller/scheduler.go

@@ -751,7 +751,6 @@ func (c *Controller) analyseCanary(r *flaggerv1.Canary) bool {
 
 	// create observer based on the mesh provider
 	observerFactory := c.observerFactory
-	observer := observerFactory.Observer(metricsProvider)
 
 	// override the global metrics server if one is specified in the canary spec
 	metricsServer := c.observerFactory.Client.GetMetricsServer()
@@ -763,8 +762,8 @@ func (c *Controller) analyseCanary(r *flaggerv1.Canary) bool {
 			c.recordEventErrorf(r, "Error building Prometheus client for %s %v", r.Spec.MetricsServer, err)
 			return false
 		}
-		observer = observerFactory.Observer(metricsProvider)
 	}
+	observer := observerFactory.Observer(metricsProvider)
 
 	// run metrics checks
 	for _, metric := range r.Spec.CanaryAnalysis.Metrics {

test/container-push.sh

@@ -13,9 +13,6 @@ push () {
     else
         docker tag test/flagger:latest weaveworks/flagger:${CIRCLE_TAG};
         docker push weaveworks/flagger:${CIRCLE_TAG};
-        LT_VERSION=$(grep 'VERSION' cmd/loadtester/main.go | awk '{ print $4 }' | tr -d '"' | head -n1);
-        docker tag test/flagger-loadtester:latest weaveworks/flagger-loadtester:${LT_VERSION};
-        docker push weaveworks/flagger-loadtester:${LT_VERSION};
     fi
 }
 

test/e2e-gloo-tests.sh

@@ -36,9 +36,6 @@ spec:
           upstreamGroup:
             name: podinfo
             namespace: test
-        routePlugins:
-          prefixRewrite:
-            prefixRewrite: "/"
 EOF
 
 cat <<EOF | kubectl apply -f -

test/e2e-istio.sh

@@ -2,7 +2,7 @@
 
 set -o errexit
 
-ISTIO_VER="1.3.0"
+ISTIO_VER="1.3.3"
 REPO_ROOT=$(git rev-parse --show-toplevel)
 export KUBECONFIG="$(kind get kubeconfig-path --name="kind")"
 

test/e2e-nginx-tests.sh

@@ -122,7 +122,7 @@ failed=false
 until ${ok}; do
     kubectl -n test get canary/podinfo | grep 'Failed' && failed=true || failed=false
     if ${failed}; then
-        kubectl -n ingress-nginx logs deployment/test-flagger
+        kubectl -n ingress-nginx logs deployment/flagger
         echo "Canary failed!"
         exit 1
     fi