Merge pull request #587 from weaveworks/redundant-assertion

pkg/metrics/providers: remove redundant assertion in prometheus test
This commit is contained in:
Takeshi Yoneda
2020-05-14 18:07:50 +09:00
committed by GitHub
-6
View File
@@ -90,9 +90,6 @@ func TestPrometheusProvider_RunQueryWithBasicAuth(t *testing.T) {
promql := r.URL.Query()["query"][0]
assert.Equal(t, expected, promql)
if assert.Contains(t, r.Header, "Authorization") {
}
header, ok := r.Header["Authorization"]
if assert.True(t, ok, "Authorization header not found") {
assert.True(t, strings.Contains(header[0], "Basic"), "Basic authorization header not found")
@@ -174,9 +171,6 @@ func TestPrometheusProvider_IsOnline(t *testing.T) {
promql := r.URL.Query()["query"][0]
assert.Equal(t, expected, promql)
if assert.Contains(t, r.Header, "Authorization") {
}
header, ok := r.Header["Authorization"]
if assert.True(t, ok, "Authorization header not found") {
assert.True(t, strings.Contains(header[0], "Basic"), "Basic authorization header not found")