Merge pull request #380 from weaveworks/skip-primary-check

Skip primary check on skip analysis
This commit is contained in:
Stefan Prodan
2019-11-26 14:25:57 +02:00
committed by GitHub
2 changed files with 2 additions and 2 deletions
+1 -1
View File
@@ -40,7 +40,7 @@ func (c *DeploymentController) Initialize(cd *flaggerv1.Canary, skipLivenessChec
}
if cd.Status.Phase == "" || cd.Status.Phase == flaggerv1.CanaryPhaseInitializing {
if !skipLivenessChecks {
if !skipLivenessChecks && !cd.Spec.SkipAnalysis {
_, readyErr := c.IsPrimaryReady(cd)
if readyErr != nil {
return "", ports, readyErr
+1 -1
View File
@@ -152,7 +152,7 @@ func (c *Controller) advanceCanary(name string, namespace string, skipLivenessCh
}
// check primary deployment status
if !skipLivenessChecks {
if !skipLivenessChecks && !cd.Spec.SkipAnalysis {
if _, err := canaryController.IsPrimaryReady(cd); err != nil {
c.recordEventWarningf(cd, "%v", err)
return