🏁 v2.2.2 Release

Merge pull request #79 from pieveee/fix/#73
fix extraVolumes and extraVolumeMounts (hypen typo) #78 #77
2026-02-18 06:09:50 +00:00 · 2022-08-18 10:20:10 -07:00 · 2022-08-18 10:19:07 -07:00 · 2022-08-18 12:20:21 +02:00 · 2022-08-17 12:22:40 -07:00 · 2022-08-17 12:08:24 -07:00
5 changed files with 15 additions and 8 deletions
--- a/.github/workflows/pr_diff.yaml
+++ b/.github/workflows/pr_diff.yaml
@@ -1,8 +1,8 @@
 name: PR Diff for Helm chart
+
 on:
-  pull_request:
  pull_request_target:
-  
+
 permissions:
  pull-requests: write

@@ -16,14 +16,20 @@ jobs:
        id: diff
        run: |
          OPTIONS=(
+            --namespace meta-namespace
            --set serviceAccount.create=true
            --set priorityClassName=high
            --set podAnnotations.test=annotation
            --set extraEnvVars[0].name=TEST_NAME
            --set extraEnvVars[0].value=TEST_VALUE
+            --set extraVolumes[0].name=test
+            --set extraVolumes[0].emptyDir.medium=Memory
+            --set extraVolumeMounts[0].name=test
+            --set extraVolumeMounts[0].mountPath=/test
            --set secrets.htpasswd=abc
            --set tlsSecretName=abc
            --set garbageCollect.enabled=true
+            --set namespace=target-namespace
            --set proxy.enabled=true
            --set storage=s3
            --set secrets.s3.secretKey=abc
@@ -32,7 +38,7 @@ jobs:
            --set s3.bucket=abc
            --set s3.encrypt=abc
          )
-          helm template --debug ${OPTIONS[@]} --output-dir before ${{ github.server_url }}/${{ github.repository }}/archive/refs/heads/${{ github.base_ref }}.tar.gz
+          helm template --debug ${OPTIONS[@]} --output-dir before https://github.com/twuni/docker-registry.helm/archive/refs/heads/main.tar.gz
          helm template --debug ${OPTIONS[@]} --output-dir after .
          # https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings
          echo 'HELM_DIFF<<EOF' >> $GITHUB_ENV
--- a/Chart.yaml
+++ b/Chart.yaml
@@ -1,8 +1,8 @@
 apiVersion: v1
 description: A Helm chart for Docker Registry
 name: docker-registry
-version: 2.2.1
-appVersion: 2.7.1
+version: 2.2.2
+appVersion: 2.8.1
 home: https://hub.docker.com/_/registry/
 icon: https://helm.twun.io/docker-registry.png
 maintainers:
--- a/templates/_helpers.tpl
+++ b/templates/_helpers.tpl
@@ -168,7 +168,7 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
 {{- end }}

 {{- with .Values.extraVolumeMounts }}
-{{- toYaml . }}
+{{ toYaml . }}
 {{- end }}

 {{- end -}}
@@ -204,6 +204,6 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
 {{- end }}

 {{- with .Values.extraVolumes }}
-{{- toYaml . }}
+{{ toYaml . }}
 {{- end }}
 {{- end -}}
--- a/templates/serviceaccount.yaml
+++ b/templates/serviceaccount.yaml
@@ -7,6 +7,7 @@ metadata:
    chart: {{ .Chart.Name }}-{{ .Chart.Version }}
    heritage: {{ .Release.Service }}
    release: {{ .Release.Name }}
+  namespace: {{ .Values.namespace | default .Release.Namespace }}
 {{- if .Values.serviceAccount.name }}
  name: {{ .Values.serviceAccount.name }}
 {{- else  }}
--- a/values.yaml
+++ b/values.yaml
@@ -19,7 +19,7 @@ serviceAccount:

 image:
  repository: registry
-  tag: 2.7.1
+  tag: 2.8.1
  pullPolicy: IfNotPresent
 # imagePullSecrets:
    # - name: docker
Author	SHA1	Message	Date
Devin Canterberry	405346f80e	🏁 v2.2.2 Release	2022-08-18 10:20:10 -07:00
Devin Canterberry	b152f62233	Merge pull request #79 from pieveee/fix/#73 fix extraVolumes and extraVolumeMounts (hypen typo) #78 #77	2022-08-18 10:19:07 -07:00
Michael Blickenstorfer	55647356c5	fix #73	2022-08-18 12:20:21 +02:00
Devin Canterberry	294d61f9d3	Merge pull request #75 from canterberry/remove-duplicate-check 🐞 Fix duplicate PR diff GitHub action and tweak test values (approved by @ddelange)	2022-08-17 12:22:40 -07:00
Devin Canterberry	836f46131f	🚦 Hard-coding the "before" chart URL in the PR diff GitHub action While this may not be strictly necessary, it's the correct resolution enough of the time that the clarity of explicitly stating the "before" is, I think, worth it.	2022-08-17 12:08:24 -07:00
Devin Canterberry	c7b3257baa	🚦 Add release namespace and target namespaces to PR diff action test values	2022-08-17 11:56:49 -07:00
Devin Canterberry	1315fc281e	Merge pull request #65 from canterberry/namespaced-service-account 🐞 Add missing namespace to ServiceAccount	2022-08-17 11:50:50 -07:00
Devin Canterberry	635fd0fa0c	Merge pull request #72 from edwargix/registr-2.8 Upgrade default image version from 2.7.1 to 2.8.1	2022-08-17 11:49:16 -07:00
Devin Canterberry	91dd5f2928	🚦 Add extraVolumes and extraVolumeMounts to PR diff GitHub action	2022-08-17 11:43:37 -07:00
Devin Canterberry	8ce5a40b47	🔥 Remove duplicate trigger for PR diff GitHub action	2022-08-17 11:40:34 -07:00
David Florness	96ad7c0eb4	Upgrade default image version from 2.7.1 to 2.8.1 Includes changes from releases 2.8.0 and 2.8.1, which mostly contain bugfixes: - https://github.com/distribution/distribution/releases/tag/v2.8.0 - https://github.com/distribution/distribution/releases/tag/v2.8.1	2022-08-16 22:29:59 -04:00
Devin Canterberry	a1cd36f55e	🐞 Add missing namespace to ServiceAccount When `serviceAccount.create` is `true`, this chart creates a service account. Currently, that service account will be created without an explicit namespace. This can be problematic because the Deployment resource does have an explicit namespace set. Because the ServiceAccount and Deployment (ultimately, the Pod) must coexist in the same namespace, we need to follow the same logic when setting the namespace for both. Fixes https://github.com/twuni/docker-registry.helm/issues/60.	2022-07-27 23:50:13 -07:00