* [Documentation] Document how to test a Chart in the Review Guidelines.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* Oops, documentation already exists: improve it, points to it.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* eg instead of example.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* helm chart test != this test tool but still related.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* Better english.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* Better way to state that we need empty file for default values.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* English.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* Guidelines: set matchLabels as being mandatory.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* fixup! Guidelines: set matchLabels as being mandatory.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* fixup! fixup! Guidelines: set matchLabels as being mandatory.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* Update guidelines: mention DaemonSets as well.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* Review guidelines: be more precise + specify upgrade
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* Review guidelines: fix typos, add persistence paragraph and do not repeat component part.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* Review guidelines: add PVC paragraph.
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
* Fix spelling/typos
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
* Fix incorrect typo fix
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
* [Documentation] Add HPA best practices to review guidelines.
After reviewing the nginx-ingress and spark charts which both have HPA's
defined I am making the following recommendations based on the
nginx-ingress chart specifically (after #7560) be added to the
review guidelines.
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
* fixed accidental deletion of pvc.yaml
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
* After repo move to helm/helm, update steps for Owning and Maintaining A Chart
* Change repo URL from kubernetes/helm to helm/helm everywhere above chart directories (those may be separate PRs)
* Fix earlier missing apostrophe and incorrect case
* Add missing k8s/ > helm/ string changes
